[{"id":21508,"web_url":"https://patchwork.libcamera.org/comment/21508/","msgid":"<51ee8357-4b7b-a351-4733-77ecd8282235@ideasonboard.com>","date":"2021-12-01T10:36:22","subject":"Re: [libcamera-devel] [PATCH v5 12/12] android: camera_request: Add\n\tthread safety annotation","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Hiro,\n\n\nOn 12/1/21 1:23 PM, Hirokazu Honda wrote:\n> This applies clang thread safety annotation to\n> Camera3RequestDescriptor.\n>\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_request.h | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index 887dbe86..d9b04f16 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -57,7 +57,8 @@ public:\n> \t};\n> \n> \t/* Keeps track of streams requiring post-processing. */\n> -\tstd::map pendingStreamsToProcess_;\n> +\tstd::map pendingStreamsToProcess_\n> +\t\tLIBCAMERA_TSA_GUARDED_BY(streamsProcessMutex_);\n> \tlibcamera::Mutex streamsProcessMutex_;\n> \n> \tCamera3RequestDescriptor(libcamera::Camera *camera,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90C88BDB13\n\tfor ;\n\tWed, 1 Dec 2021 10:36:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D8C660718;\n\tWed, 1 Dec 2021 11:36:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 128D16011D\n\tfor ;\n\tWed, 1 Dec 2021 11:36:28 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C6B38AE;\n\tWed, 1 Dec 2021 11:36:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NvxGlmlw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638354987;\n\tbh=YbT5UtMQDxkjvKFuX2Bd3kaLLo6D4AA+NYfPaFuNg4E=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=NvxGlmlwyczY3waaGHEjCBh8wdhU9TwWYqBo4bQoOWYX2IvRdcdUsIUbzXta6QGEZ\n\t0+nucemAnxOgxdyQbGBRnIkTgMfkXJZMztcqVdwnOjGdXiijNPqRm7jowmetHQva08\n\t5exEQfmbO+fO6NJ99zQHwnweTo1QbetNO7+ik6zo=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20211201075348.3121186-1-hiroh@chromium.org>\n\t<20211201075348.3121186-13-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"<51ee8357-4b7b-a351-4733-77ecd8282235@ideasonboard.com>","Date":"Wed, 1 Dec 2021 16:06:22 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211201075348.3121186-13-hiroh@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v5 12/12] android: camera_request: Add\n\tthread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]