{"id":14952,"url":"https://patchwork.libcamera.org/api/patches/14952/?format=json","web_url":"https://patchwork.libcamera.org/patch/14952/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211201075348.3121186-13-hiroh@chromium.org>","date":"2021-12-01T07:53:48","name":"[libcamera-devel,v5,12/12] android: camera_request: Add thread safety annotation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0a2c2dc8d25d9d2f64b91642eabbb5bcef3d8b47","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14952/mbox/","series":[{"id":2791,"url":"https://patchwork.libcamera.org/api/series/2791/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2791","date":"2021-12-01T07:53:36","name":"Introduce clang thread safety annotations","version":5,"mbox":"https://patchwork.libcamera.org/series/2791/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14952/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14952/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC4BBBF415\n\tfor ;\n\tWed, 1 Dec 2021 07:54:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8805B60726;\n\tWed, 1 Dec 2021 08:54:19 +0100 (CET)","from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com\n\t[IPv6:2607:f8b0:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 63E626072E\n\tfor ;\n\tWed, 1 Dec 2021 08:54:17 +0100 (CET)","by mail-pg1-x52f.google.com with SMTP id r138so22682216pgr.13\n\tfor ;\n\tTue, 30 Nov 2021 23:54:17 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:3892:a049:59ba:c772])\n\tby smtp.gmail.com with ESMTPSA id\n\tl9sm3500848pfu.55.2021.11.30.23.54.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 23:54:15 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"MYxZEy7d\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uJYG3Nusw/zJT2sBNaxIou0h0BcaN6bUP3w8FXeB2XE=;\n\tb=MYxZEy7d8HWtbbD6Q3PRGz6u/6DmCOmOrNAZEuQZdfLTrys9oYTfg9PnMQPOeSD9u9\n\tquW3sJhb28BZ5PvkUfVBGxQaK1aNInrWoOK25EUM0LkY7IUK1RRg+y3yYS2gQDj9mJEj\n\teC96ngG66r4paGxrn41ZgvmOnfjDBPgUTFd3s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uJYG3Nusw/zJT2sBNaxIou0h0BcaN6bUP3w8FXeB2XE=;\n\tb=XslOSXTUy4VTex5O1grJKvwOdu1pkjVAYTJfLXB01qvcs5UpRj7zGMGrShvld6Ci/U\n\tXTZgrNeHHY5l1VvgAHaSSvlXU2dDZ/0qmMMHQAx8WjNMOno6hBq1rqlwkYqqqi4S7I2L\n\tm+BJCBVrmHROXp+bqjAfRmuJtbUjO4t1+/nOPCWNsn3GrF6UVly8tWk/I0JxA6YvBdQD\n\tEqf/Mb+UAFA58jp31L46iZZdwoezwCdZdEtelqxqfabYF9PdIVqmkYAH638aqilWEMvZ\n\tNz2WvSydtsrG4vFxaJDhXBznAn29bJvHmaVuvBGGal8zM1E2U5uSnHkLEu3J21aDOrSo\n\tLPPw==","X-Gm-Message-State":"AOAM530PIB2rKeO5GD1cGqXoMJERX6dPC3V+42gFdl+UdUk1ZeaTshaX\n\tUdjChGPJlopp6nJqWPeC07dI4IskkxhfRA==","X-Google-Smtp-Source":"ABdhPJyT6cIt08yy25L3+SmnTOpjivWub0TjU/Vhn2eK+jcO0ffOoqAPzb1iBWtRW0T/456K4o/2sQ==","X-Received":"by 2002:a63:1d13:: with SMTP id\n\td19mr3586408pgd.383.1638345255741; \n\tTue, 30 Nov 2021 23:54:15 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Dec 2021 16:53:48 +0900","Message-Id":"<20211201075348.3121186-13-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc2.393.gf8c9666880-goog","In-Reply-To":"<20211201075348.3121186-1-hiroh@chromium.org>","References":"<20211201075348.3121186-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 12/12] android: camera_request: Add\n\tthread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This applies clang thread safety annotation to\nCamera3RequestDescriptor.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_request.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_request.h b/src/android/camera_request.h\nindex 887dbe86..d9b04f16 100644\n--- a/src/android/camera_request.h\n+++ b/src/android/camera_request.h\n@@ -57,7 +57,8 @@ public:\n \t};\n \n \t/* Keeps track of streams requiring post-processing. */\n-\tstd::map pendingStreamsToProcess_;\n+\tstd::map pendingStreamsToProcess_\n+\t\tLIBCAMERA_TSA_GUARDED_BY(streamsProcessMutex_);\n \tlibcamera::Mutex streamsProcessMutex_;\n \n \tCamera3RequestDescriptor(libcamera::Camera *camera,\n","prefixes":["libcamera-devel","v5","12/12"]}