{"id":14947,"url":"https://patchwork.libcamera.org/api/patches/14947/?format=json","web_url":"https://patchwork.libcamera.org/patch/14947/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211201075348.3121186-8-hiroh@chromium.org>","date":"2021-12-01T07:53:43","name":"[libcamera-devel,v5,07/12] android: camera_hal_manager: Add thread safety annotation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c6bd61088a96f9f5edc0f342aba6cfef9c9a68fd","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14947/mbox/","series":[{"id":2791,"url":"https://patchwork.libcamera.org/api/series/2791/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2791","date":"2021-12-01T07:53:36","name":"Introduce clang thread safety annotations","version":5,"mbox":"https://patchwork.libcamera.org/series/2791/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14947/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14947/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF4A4BF415\n\tfor ;\n\tWed, 1 Dec 2021 07:54:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EA5D60723;\n\tWed, 1 Dec 2021 08:54:10 +0100 (CET)","from mail-pl1-x634.google.com (mail-pl1-x634.google.com\n\t[IPv6:2607:f8b0:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58B3F60724\n\tfor ;\n\tWed, 1 Dec 2021 08:54:08 +0100 (CET)","by mail-pl1-x634.google.com with SMTP id o14so17040048plg.5\n\tfor ;\n\tTue, 30 Nov 2021 23:54:08 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:3892:a049:59ba:c772])\n\tby smtp.gmail.com with ESMTPSA id\n\tl9sm3500848pfu.55.2021.11.30.23.54.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 23:54:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"F4B8YGqw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=yfiTHE7WZmDZfQa0nPUIu56mr46Z/OnMWR39IqW4+bk=;\n\tb=F4B8YGqw2F26pQG50le1AIsGG53ZUpOqfteIA66HcQnxv0wfnWut6v9AFyWE3FNnpZ\n\tNINe7ApTKli56zce5j/UK9bhtQfs3MPF5w0aMjupQAaCScKeCyqFcRlAKZAL4q08ESWC\n\tpubiS8bWgXjQlMSiDuYaGUXWvJWhDPZEzIx3o=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=yfiTHE7WZmDZfQa0nPUIu56mr46Z/OnMWR39IqW4+bk=;\n\tb=rzlmjRR2Iub5ogZp3UzTKaP5fZQq5TjGZKRWrCa43eyqCHWqhOHwhEEtGngXLmHKGN\n\tCQfMMlCTtpgl5rmkw2jSDLHj1bRU9zFnq6qax82MfGB7mXDD9FxTfWr6A+7LfB+FfgRT\n\tuCPjY/mxjoVFfkuyoTqBaIl0yT2BQgzb/w5GXZM3H5NeLH8w2bcEAfFC3xTHv85/Z/Oa\n\tZyMvSMbtk9myZZaxDO8uV/KqNmTpgPSA1+RBM3wlQkO3kldoE1Ww4CkK/TG7QPsbEJfU\n\tjr7FWgcgkjIQ4cjwlAmw8+RugC77QvolPNr8HTBBxSth1t8fVX76eB23VOAqfhcMgHx4\n\tSZvA==","X-Gm-Message-State":"AOAM532+5hlPQaHMrJuUnPRvQQgCPhG2XF+O+yQVN6ljvB2D2RLb2u2F\n\tyYByFbV1lZFaeX0Z75DeoCrF9BXQ8sWHhA==","X-Google-Smtp-Source":"ABdhPJxH6Quf09cAe8T168/0LYPZ5MVLKlJpyUcKeKmNQFfrZpgRadwXQ/tAyEQ6e5kx2MQaMKILGg==","X-Received":"by 2002:a17:90a:d481:: with SMTP id\n\ts1mr5405915pju.66.1638345246747; \n\tTue, 30 Nov 2021 23:54:06 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Dec 2021 16:53:43 +0900","Message-Id":"<20211201075348.3121186-8-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc2.393.gf8c9666880-goog","In-Reply-To":"<20211201075348.3121186-1-hiroh@chromium.org>","References":"<20211201075348.3121186-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 07/12] android: camera_hal_manager: Add\n\tthread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This applies clang thread safety annotation to CameraHalManager.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \nReviewed-by: Umang Jain \n---\n src/android/camera_hal_manager.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\nindex 765701b2..a5f8b933 100644\n--- a/src/android/camera_hal_manager.h\n+++ b/src/android/camera_hal_manager.h\n@@ -53,14 +53,14 @@ private:\n \tvoid cameraAdded(std::shared_ptr cam);\n \tvoid cameraRemoved(std::shared_ptr cam);\n \n-\tCameraDevice *cameraDeviceFromHalId(unsigned int id);\n+\tCameraDevice *cameraDeviceFromHalId(unsigned int id) LIBCAMERA_TSA_REQUIRES(mutex_);\n \n \tstd::unique_ptr cameraManager_;\n \tCameraHalConfig halConfig_;\n \n \tconst camera_module_callbacks_t *callbacks_;\n-\tstd::vector> cameras_;\n-\tstd::map cameraIdsMap_;\n+\tstd::vector> cameras_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n+\tstd::map cameraIdsMap_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \tlibcamera::Mutex mutex_;\n \n \tunsigned int numInternalCameras_;\n","prefixes":["libcamera-devel","v5","07/12"]}