[{"id":21504,"web_url":"https://patchwork.libcamera.org/comment/21504/","msgid":"","date":"2021-12-01T10:30:35","subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: Correct include\n\theaders for Mutex classes","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Hiro\n\nOn 12/1/21 1:23 PM, Hirokazu Honda wrote:\n> Mutex classes are defined in mutex.h. This replaces thread.h\n> include for the Mutex classes with mutex.h.\n>\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/base/semaphore.h | 3 ++-\n> include/libcamera/base/thread.h | 1 -\n> src/android/camera_device.cpp | 1 -\n> src/android/camera_device.h | 2 +-\n> src/android/camera_hal_manager.h | 2 +-\n> src/android/camera_request.h | 2 +-\n> src/android/camera_stream.h | 1 +\n> src/libcamera/base/semaphore.cpp | 1 -\n> src/libcamera/base/signal.cpp | 2 +-\n> src/libcamera/base/thread.cpp | 1 +\n> src/libcamera/camera_manager.cpp | 1 +\n> src/v4l2/v4l2_camera.h | 2 +-\n> 12 files changed, 10 insertions(+), 9 deletions(-)\n>\n> diff --git a/include/libcamera/base/semaphore.h b/include/libcamera/base/semaphore.h\n> index ec05fad3..c11e8dd1 100644\n> --- a/include/libcamera/base/semaphore.h\n> +++ b/include/libcamera/base/semaphore.h\n> @@ -8,7 +8,8 @@\n> #pragma once\n> \n> #include \n> -#include \n> +\n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/include/libcamera/base/thread.h b/include/libcamera/base/thread.h\n> index 44678c34..9d00f102 100644\n> --- a/include/libcamera/base/thread.h\n> +++ b/include/libcamera/base/thread.h\n> @@ -14,7 +14,6 @@\n> #include \n> \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f2e0bdbd..d74307a2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -14,7 +14,6 @@\n> #include \n> \n> #include \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index bda0b376..a945f5de 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -17,7 +17,7 @@\n> #include \n> #include \n> #include \n> -#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\n> index cc310f90..765701b2 100644\n> --- a/src/android/camera_hal_manager.h\n> +++ b/src/android/camera_hal_manager.h\n> @@ -17,7 +17,7 @@\n> #include \n> \n> #include \n> -#include \n> +#include \n> \n> #include \n> \n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index 88d501a8..887dbe86 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -12,7 +12,7 @@\n> #include \n> \n> #include \n> -#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index adb5a37d..e4eb953a 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -13,6 +13,7 @@\n> \n> #include \n> \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/base/semaphore.cpp b/src/libcamera/base/semaphore.cpp\n> index bf730c87..4fe30293 100644\n> --- a/src/libcamera/base/semaphore.cpp\n> +++ b/src/libcamera/base/semaphore.cpp\n> @@ -6,7 +6,6 @@\n> */\n> \n> #include \n> -#include \n> \n> /**\n> * \\file base/semaphore.h\n> diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\n> index 9c2319c5..9df45d07 100644\n> --- a/src/libcamera/base/signal.cpp\n> +++ b/src/libcamera/base/signal.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \n> \n> -#include \n> +#include \n> \n> /**\n> * \\file base/signal.h\n> diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n> index b2043b7e..6bda9d14 100644\n> --- a/src/libcamera/base/thread.cpp\n> +++ b/src/libcamera/base/thread.cpp\n> @@ -17,6 +17,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> /**\n> * \\page thread Thread Support\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 77ff3bd1..70d73822 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -12,6 +12,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index bf1b6de4..9307d61d 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -10,8 +10,8 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> -#include \n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2DA6BF415\n\tfor ;\n\tWed, 1 Dec 2021 10:30:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2004C60720;\n\tWed, 1 Dec 2021 11:30:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFFDC6011D\n\tfor ;\n\tWed, 1 Dec 2021 11:30:40 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF7988AE;\n\tWed, 1 Dec 2021 11:30:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KGnBWW0M\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638354640;\n\tbh=ZIGmVQptOyUCj9me03j6/Kg3W6oc2AmA6glC7ietl6Q=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=KGnBWW0M62aMQMtpG1+Z75IpuBW+5qUkbiVicB0NuqB05T72MLnsrGJKHSUK6on8R\n\tr8bFvmqIZBBC83+QSfmOP+FvBQGvcl4eLIdiZu3dBLgXgNlgOf5wRJ6K9FNOYZyrs+\n\tcQluzMwWcTUR36+0c7kjY70j6UKbm+Va9LnrympM=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20211201075348.3121186-1-hiroh@chromium.org>\n\t<20211201075348.3121186-7-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"","Date":"Wed, 1 Dec 2021 16:00:35 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211201075348.3121186-7-hiroh@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: Correct include\n\theaders for Mutex classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21513,"web_url":"https://patchwork.libcamera.org/comment/21513/","msgid":"","date":"2021-12-01T10:54:23","subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: Correct include\n\theaders for Mutex classes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Wed, Dec 01, 2021 at 04:53:42PM +0900, Hirokazu Honda wrote:\n> Mutex classes are defined in mutex.h. This replaces thread.h\n> include for the Mutex classes with mutex.h.\n> \n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n> ---\n> include/libcamera/base/semaphore.h | 3 ++-\n> include/libcamera/base/thread.h | 1 -\n> src/android/camera_device.cpp | 1 -\n> src/android/camera_device.h | 2 +-\n> src/android/camera_hal_manager.h | 2 +-\n> src/android/camera_request.h | 2 +-\n> src/android/camera_stream.h | 1 +\n> src/libcamera/base/semaphore.cpp | 1 -\n> src/libcamera/base/signal.cpp | 2 +-\n> src/libcamera/base/thread.cpp | 1 +\n> src/libcamera/camera_manager.cpp | 1 +\n> src/v4l2/v4l2_camera.h | 2 +-\n> 12 files changed, 10 insertions(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/base/semaphore.h b/include/libcamera/base/semaphore.h\n> index ec05fad3..c11e8dd1 100644\n> --- a/include/libcamera/base/semaphore.h\n> +++ b/include/libcamera/base/semaphore.h\n> @@ -8,7 +8,8 @@\n> #pragma once\n> \n> #include \n> -#include \n> +\n> +#include \n> \n> namespace libcamera {\n> \n> diff --git a/include/libcamera/base/thread.h b/include/libcamera/base/thread.h\n> index 44678c34..9d00f102 100644\n> --- a/include/libcamera/base/thread.h\n> +++ b/include/libcamera/base/thread.h\n> @@ -14,7 +14,6 @@\n> #include \n> \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f2e0bdbd..d74307a2 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -14,7 +14,6 @@\n> #include \n> \n> #include \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index bda0b376..a945f5de 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -17,7 +17,7 @@\n> #include \n> #include \n> #include \n> -#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\n> index cc310f90..765701b2 100644\n> --- a/src/android/camera_hal_manager.h\n> +++ b/src/android/camera_hal_manager.h\n> @@ -17,7 +17,7 @@\n> #include \n> \n> #include \n> -#include \n> +#include \n> \n> #include \n> \n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index 88d501a8..887dbe86 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -12,7 +12,7 @@\n> #include \n> \n> #include \n> -#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index adb5a37d..e4eb953a 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -13,6 +13,7 @@\n> \n> #include \n> \n> +#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/base/semaphore.cpp b/src/libcamera/base/semaphore.cpp\n> index bf730c87..4fe30293 100644\n> --- a/src/libcamera/base/semaphore.cpp\n> +++ b/src/libcamera/base/semaphore.cpp\n> @@ -6,7 +6,6 @@\n> */\n> \n> #include \n> -#include \n> \n> /**\n> * \\file base/semaphore.h\n> diff --git a/src/libcamera/base/signal.cpp b/src/libcamera/base/signal.cpp\n> index 9c2319c5..9df45d07 100644\n> --- a/src/libcamera/base/signal.cpp\n> +++ b/src/libcamera/base/signal.cpp\n> @@ -7,7 +7,7 @@\n> \n> #include \n> \n> -#include \n> +#include \n> \n> /**\n> * \\file base/signal.h\n> diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\n> index b2043b7e..6bda9d14 100644\n> --- a/src/libcamera/base/thread.cpp\n> +++ b/src/libcamera/base/thread.cpp\n> @@ -17,6 +17,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> /**\n> * \\page thread Thread Support\n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 77ff3bd1..70d73822 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -12,6 +12,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> \n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index bf1b6de4..9307d61d 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -10,8 +10,8 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> -#include \n\nThis causes a collateral dammage:\n\n[32/142] Compiling C++ object src/v4l2/v4l2-compat.so.p/v4l2_compat.cpp.o\nFAILED: src/v4l2/v4l2-compat.so.p/v4l2_compat.cpp.o \narm-buildroot-linux-uclibcgnueabihf-g++ -Isrc/v4l2/v4l2-compat.so.p -Isrc/v4l2 -I../../src/v4l2 -Iinclude -I../../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fdiagnostics-color=always -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wno-psabi -Wshadow -include config.h -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -fPIC -DLIBCAMERA_BASE_PRIVATE -U_FILE_OFFSET_BITS -D_FILE_OFFSET_BITS=32 -D_LARGEFILE64_SOURCE -fvisibility=hidden -MD -MQ src/v4l2/v4l2-compat.so.p/v4l2_compat.cpp.o -MF src/v4l2/v4l2-compat.so.p/v4l2_compat.cpp.o.d -o src/v4l2/v4l2-compat.so.p/v4l2_compat.cpp.o -c ../../src/v4l2/v4l2_compat.cpp\n../../src/v4l2/v4l2_compat.cpp: In function ‘int open(const char*, int, ...)’:\n../../src/v4l2/v4l2_compat.cpp:34:33: error: ‘O_TMPFILE’ was not declared in this scope\n 34 | if (oflag & O_CREAT || oflag & O_TMPFILE)\n | ^~~~~~~~~\n../../src/v4l2/v4l2_compat.cpp: In function ‘int open64(const char*, int, ...)’:\n../../src/v4l2/v4l2_compat.cpp:51:33: error: ‘O_TMPFILE’ was not declared in this scope\n 51 | if (oflag & O_CREAT || oflag & O_TMPFILE)\n | ^~~~~~~~~\n../../src/v4l2/v4l2_compat.cpp: In function ‘int openat(int, const char*, int, ...)’:\n../../src/v4l2/v4l2_compat.cpp:67:33: error: ‘O_TMPFILE’ was not declared in this scope\n 67 | if (oflag & O_CREAT || oflag & O_TMPFILE)\n | ^~~~~~~~~\n../../src/v4l2/v4l2_compat.cpp: In function ‘int openat64(int, const char*, int, ...)’:\n../../src/v4l2/v4l2_compat.cpp:82:33: error: ‘O_TMPFILE’ was not declared in this scope\n 82 | if (oflag & O_CREAT || oflag & O_TMPFILE)\n |\n\nI'll add\n\n#include \n\nto v4l2_compat.cpp as part of this patch.\n\n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFCF0BF415\n\tfor ;\n\tWed, 1 Dec 2021 10:54:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4400460720;\n\tWed, 1 Dec 2021 11:54:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C5646011D\n\tfor ;\n\tWed, 1 Dec 2021 11:54:49 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0486A15;\n\tWed, 1 Dec 2021 11:54:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mQvQ/tHJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638356089;\n\tbh=u+G+Uy+yMHfdcJeNmERfdZdWOH3UNL7kKCLEvacNEF0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mQvQ/tHJcjTO32YSp3/uQjKQ0n88ov58ysxvDrGvL/gw1csrgAXx+deiXdOacsXnQ\n\tWQdaghO0e4Y0Z3XYfVLQgHnMmPlzWSzxTDxCi0p91/D7l1bqU06JTi2iZbMRiyBEIV\n\tM+NHJVqjkrTxTKkehvU30P7q0sLIiLCk5jnu/r6Y=","Date":"Wed, 1 Dec 2021 12:54:23 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20211201075348.3121186-1-hiroh@chromium.org>\n\t<20211201075348.3121186-7-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20211201075348.3121186-7-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v5 06/12] libcamera: Correct include\n\theaders for Mutex classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]