[{"id":21501,"web_url":"https://patchwork.libcamera.org/comment/21501/","msgid":"<0e87a4e0-c174-e1bf-6123-36f9a3638e22@ideasonboard.com>","date":"2021-12-01T10:26:02","subject":"Re: [libcamera-devel] [PATCH v5 03/12] v4l2: Consolidate mutex\n\tclasses to Mutex and MutexLocker","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn 12/1/21 1:23 PM, Hirokazu Honda wrote:\n> std::mutex and std::unique_lock are used in v4l2 directory,\n> mixing Mutex and MutexLocker. This consolidates them to Mutex\n> and MutexLocker.\n>\n> This also fixes vidioc_dqbuf argument to take Mutex instead of\n> MutexLocker.\n>\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/v4l2/v4l2_camera.h | 4 ++--\n> src/v4l2/v4l2_camera_proxy.cpp | 8 ++++----\n> src/v4l2/v4l2_camera_proxy.h | 4 +++-\n> 3 files changed, 9 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index 4afbb331..bf1b6de4 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -8,10 +8,10 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -71,7 +71,7 @@ private:\n> \n> \tbool isRunning_;\n> \n> -\tstd::mutex bufferLock_;\n> +\tlibcamera::Mutex bufferLock_;\n> \tlibcamera::FrameBufferAllocator *bufferAllocator_;\n> \n> \tstd::vector> requestPool_;\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 3610e63c..79bc880d 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -575,7 +575,7 @@ int V4L2CameraProxy::vidioc_qbuf(V4L2CameraFile *file, struct v4l2_buffer *arg)\n> }\n> \n> int V4L2CameraProxy::vidioc_dqbuf(V4L2CameraFile *file, struct v4l2_buffer *arg,\n> -\t\t\t\t MutexLocker *locker)\n> +\t\t\t\t Mutex *lock)\n> {\n> \tLOG(V4L2Compat, Debug) << \"Servicing vidioc_dqbuf fd = \" << file->efd();\n> \n> @@ -593,9 +593,9 @@ int V4L2CameraProxy::vidioc_dqbuf(V4L2CameraFile *file, struct v4l2_buffer *arg,\n> \t\treturn -EINVAL;\n> \n> \tif (!file->nonBlocking()) {\n> -\t\tlocker->unlock();\n> +\t\tlock->unlock();\n> \t\tvcam_->waitForBufferAvailable();\n> -\t\tlocker->lock();\n> +\t\tlock->lock();\n> \t} else if (!vcam_->isBufferAvailable())\n> \t\treturn -EAGAIN;\n> \n> @@ -753,7 +753,7 @@ int V4L2CameraProxy::ioctl(V4L2CameraFile *file, unsigned long request, void *ar\n> \t\tret = vidioc_qbuf(file, static_cast(arg));\n> \t\tbreak;\n> \tcase VIDIOC_DQBUF:\n> -\t\tret = vidioc_dqbuf(file, static_cast(arg), &locker);\n> +\t\tret = vidioc_dqbuf(file, static_cast(arg), &proxyMutex_);\n> \t\tbreak;\n> \tcase VIDIOC_STREAMON:\n> \t\tret = vidioc_streamon(file, static_cast(arg));\n> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> index fccec241..040954dd 100644\n> --- a/src/v4l2/v4l2_camera_proxy.h\n> +++ b/src/v4l2/v4l2_camera_proxy.h\n> @@ -14,6 +14,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \n> \n> #include \"v4l2_camera.h\"\n> @@ -57,7 +59,7 @@ private:\n> \tint vidioc_querybuf(V4L2CameraFile *file, struct v4l2_buffer *arg);\n> \tint vidioc_qbuf(V4L2CameraFile *file, struct v4l2_buffer *arg);\n> \tint vidioc_dqbuf(V4L2CameraFile *file, struct v4l2_buffer *arg,\n> -\t\t\t libcamera::MutexLocker *locker);\n> +\t\t\t libcamera::Mutex *lock);\n> \tint vidioc_streamon(V4L2CameraFile *file, int *arg);\n> \tint vidioc_streamoff(V4L2CameraFile *file, int *arg);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4FA6BDB13\n\tfor ;\n\tWed, 1 Dec 2021 10:26:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 807DB60720;\n\tWed, 1 Dec 2021 11:26:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F28B6011D\n\tfor ;\n\tWed, 1 Dec 2021 11:26:08 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 618278AE;\n\tWed, 1 Dec 2021 11:26:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"df9Qatpu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638354368;\n\tbh=nDkEEDcu6WLSQRGC9IpUs+ZXSkrJX1bhP6yKCOWSAtY=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=df9QatpurW8/M2BQv01pNDaszF4mxfe0YomWuSnSVkgg8zL7ySfIXXV4KnOhOKqnA\n\tT0bGRhlCIQlTNWHw2WkVl0ik+3Jp8i4D11heywzHFBbEYNXcHOYbybUSAs5QQMCWd8\n\tH2yBdBrMLoGQUnlZHG/+U6kBaTwH29qwsQfrQgVg=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20211201075348.3121186-1-hiroh@chromium.org>\n\t<20211201075348.3121186-4-hiroh@chromium.org>","From":"Umang Jain ","Message-ID":"<0e87a4e0-c174-e1bf-6123-36f9a3638e22@ideasonboard.com>","Date":"Wed, 1 Dec 2021 15:56:02 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211201075348.3121186-4-hiroh@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v5 03/12] v4l2: Consolidate mutex\n\tclasses to Mutex and MutexLocker","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]