[{"id":21496,"web_url":"https://patchwork.libcamera.org/comment/21496/","msgid":"<YadH6GPvxztQPHew@pendragon.ideasonboard.com>","date":"2021-12-01T10:01:12","subject":"Re: [libcamera-devel] [PATCH v2] test: gstreamer: Avoid call to\n\tdeprecated gst_element_get_request_pad()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Xavier,\n\nThank you for the patch.\n\nOn Wed, Dec 01, 2021 at 08:52:33AM +0100, Xavier Roumegue wrote:\n> gst_element_get_request_pad() is being replaced by gst_element_request_simple()\n> since 1.19.1, throwing a warning in case of use until its definitive\n> replacement on 1.20.\n> \n> Hence, prefer using gst_element_request_simple() in case gstreamer\n> version is >= 1.19.1 to avoid the compilation error below (tested on f35):\n> \n> [258/391] Compiling C++ object test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o\n> FAILED: test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o\n> c++ -Itest/gstreamer/multi_stream_test.p -Itest/gstreamer -I../test/gstreamer -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include config.h -pthread -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o -MF test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o.d -o test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o -c ../test/gstreamer/gstreamer_multi_stream_test.cpp\n> ../test/gstreamer/gstreamer_multi_stream_test.cpp: In member function ‘virtual int GstreamerMultiStreamTest::run()’:\n> ../test/gstreamer/gstreamer_multi_stream_test.cpp:90:76: error: ‘GstPad* gst_element_get_request_pad(GstElement*, const gchar*)’ is deprecated: Use 'gst_element_request_pad_simple' instead [-Werror=deprecated-declarations]\n>    90 |                 g_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, \"src_%u\");\n>       |                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~\n> In file included from /usr/include/gstreamer-1.0/gst/gstbin.h:27,\n>                  from /usr/include/gstreamer-1.0/gst/gst.h:35,\n>                  from ../test/gstreamer/gstreamer_multi_stream_test.cpp:13:\n> /usr/include/gstreamer-1.0/gst/gstelement.h:1042:25: note: declared here\n>  1042 | GstPad*                 gst_element_get_request_pad     (GstElement *element, const gchar *name);\n>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~\n> cc1plus: all warnings being treated as errors\n> \n> Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  test/gstreamer/gstreamer_multi_stream_test.cpp | 10 +++++++++-\n>  1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/gstreamer/gstreamer_multi_stream_test.cpp b/test/gstreamer/gstreamer_multi_stream_test.cpp\n> index d3d7a9d3..112f1dee 100644\n> --- a/test/gstreamer/gstreamer_multi_stream_test.cpp\n> +++ b/test/gstreamer/gstreamer_multi_stream_test.cpp\n> @@ -15,6 +15,14 @@\n>  #include \"gstreamer_test.h\"\n>  #include \"test.h\"\n>  \n> +#if !GST_CHECK_VERSION(1, 19, 1)\n> +static inline GstPad *gst_element_request_pad_simple(GstElement *element,\n> +\t\t\t\t\t\t     const gchar *name)\n> +{\n> +\treturn gst_element_get_request_pad(element, name);\n> +}\n> +#endif\n> +\n>  using namespace std;\n>  \n>  class GstreamerMultiStreamTest : public GstreamerTest, public Test\n> @@ -87,7 +95,7 @@ protected:\n>  \t\t\t\t stream0_, stream1_, NULL);\n>  \n>  \t\tg_autoptr(GstPad) src_pad = gst_element_get_static_pad(libcameraSrc_, \"src\");\n> -\t\tg_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, \"src_%u\");\n> +\t\tg_autoptr(GstPad) request_pad = gst_element_request_pad_simple(libcameraSrc_, \"src_%u\");\n>  \n>  \t\t{\n>  \t\t\tg_autoptr(GstPad) queue0_sink_pad = gst_element_get_static_pad(stream0_, \"sink\");","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A890BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  1 Dec 2021 10:01:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A00CD60720;\n\tWed,  1 Dec 2021 11:01:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B42086011D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  1 Dec 2021 11:01:38 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F2962FD;\n\tWed,  1 Dec 2021 11:01:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sqGvVSMU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638352898;\n\tbh=c0wu/KKsqA8K4XSvtZWSISsAEcFE7qRwfowYdKKcGRY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sqGvVSMUwRLznNATh6UtwqCdfwzm2gPmjfhyiiwSQIi4ceIlm8K8zSZo+Z6CbG1bA\n\t+Uutds36rzlHwaIjCqWVmEZzZ11KpXz8Jgp8c9c/P9g1TptzcRo8GLu9QQmXNLXMJF\n\tl1jOj+/dd6Zzyi+fxHoUJtT07xPF0XgPwBIyMMWI=","Date":"Wed, 1 Dec 2021 12:01:12 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Xavier Roumegue <xavier.roumegue@oss.nxp.com>","Message-ID":"<YadH6GPvxztQPHew@pendragon.ideasonboard.com>","References":"<20211130182315.154181-1-xavier.roumegue@oss.nxp.com>\n\t<20211201075233.218836-1-xavier.roumegue@oss.nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20211201075233.218836-1-xavier.roumegue@oss.nxp.com>","Subject":"Re: [libcamera-devel] [PATCH v2] test: gstreamer: Avoid call to\n\tdeprecated gst_element_get_request_pad()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"nicolas.dufresne@collabora.com, libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":21497,"web_url":"https://patchwork.libcamera.org/comment/21497/","msgid":"<173ef581-0fe6-4d74-9ccb-ffdaf4b73bde@ideasonboard.com>","date":"2021-12-01T10:04:46","subject":"Re: [libcamera-devel] [PATCH v2] test: gstreamer: Avoid call to\n\tdeprecated gst_element_get_request_pad()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Xaiver,\n\nOn 12/1/21 1:22 PM, Xavier Roumegue wrote:\n> gst_element_get_request_pad() is being replaced by gst_element_request_simple()\n> since 1.19.1, throwing a warning in case of use until its definitive\n> replacement on 1.20.\n>\n> Hence, prefer using gst_element_request_simple() in case gstreamer\n> version is >= 1.19.1 to avoid the compilation error below (tested on f35):\n>\n> [258/391] Compiling C++ object test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o\n> FAILED: test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o\n> c++ -Itest/gstreamer/multi_stream_test.p -Itest/gstreamer -I../test/gstreamer -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include config.h -pthread -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o -MF test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o.d -o test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o -c ../test/gstreamer/gstreamer_multi_stream_test.cpp\n> ../test/gstreamer/gstreamer_multi_stream_test.cpp: In member function ‘virtual int GstreamerMultiStreamTest::run()’:\n> ../test/gstreamer/gstreamer_multi_stream_test.cpp:90:76: error: ‘GstPad* gst_element_get_request_pad(GstElement*, const gchar*)’ is deprecated: Use 'gst_element_request_pad_simple' instead [-Werror=deprecated-declarations]\n>     90 |                 g_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, \"src_%u\");\n>        |                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~\n> In file included from /usr/include/gstreamer-1.0/gst/gstbin.h:27,\n>                   from /usr/include/gstreamer-1.0/gst/gst.h:35,\n>                   from ../test/gstreamer/gstreamer_multi_stream_test.cpp:13:\n> /usr/include/gstreamer-1.0/gst/gstelement.h:1042:25: note: declared here\n>   1042 | GstPad*                 gst_element_get_request_pad     (GstElement *element, const gchar *name);\n>        |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~\n> cc1plus: all warnings being treated as errors\n>\n> Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>\n\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n> ---\n>   test/gstreamer/gstreamer_multi_stream_test.cpp | 10 +++++++++-\n>   1 file changed, 9 insertions(+), 1 deletion(-)\n>\n> diff --git a/test/gstreamer/gstreamer_multi_stream_test.cpp b/test/gstreamer/gstreamer_multi_stream_test.cpp\n> index d3d7a9d3..112f1dee 100644\n> --- a/test/gstreamer/gstreamer_multi_stream_test.cpp\n> +++ b/test/gstreamer/gstreamer_multi_stream_test.cpp\n> @@ -15,6 +15,14 @@\n>   #include \"gstreamer_test.h\"\n>   #include \"test.h\"\n>   \n> +#if !GST_CHECK_VERSION(1, 19, 1)\n> +static inline GstPad *gst_element_request_pad_simple(GstElement *element,\n> +\t\t\t\t\t\t     const gchar *name)\n> +{\n> +\treturn gst_element_get_request_pad(element, name);\n> +}\n> +#endif\n> +\n>   using namespace std;\n>   \n>   class GstreamerMultiStreamTest : public GstreamerTest, public Test\n> @@ -87,7 +95,7 @@ protected:\n>   \t\t\t\t stream0_, stream1_, NULL);\n>   \n>   \t\tg_autoptr(GstPad) src_pad = gst_element_get_static_pad(libcameraSrc_, \"src\");\n> -\t\tg_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, \"src_%u\");\n> +\t\tg_autoptr(GstPad) request_pad = gst_element_request_pad_simple(libcameraSrc_, \"src_%u\");\n>   \n>   \t\t{\n>   \t\t\tg_autoptr(GstPad) queue0_sink_pad = gst_element_get_static_pad(stream0_, \"sink\");","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20A0FBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  1 Dec 2021 10:04:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B62060720;\n\tWed,  1 Dec 2021 11:04:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19EFA6011D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  1 Dec 2021 11:04:53 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77B878AE;\n\tWed,  1 Dec 2021 11:04:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OLD62Quq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638353092;\n\tbh=Obb+0RVa901XHHu+RLQLv7Hpn6xdpI9STDRDjT6PNMA=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=OLD62Quqkqpeke/eaq8v6MQLvDNmmv0/qhrVnKzzwwxEV30QmStlQvaFsDB1B3ibE\n\tCS6QiyVddbVw9nen+/rIkMmdSG5PFtsjCeX07J+MxEn6Ty5j5kdLXHPhHiBNAnm1Z4\n\t7yjjVWi/MlRk5kzoRA668TEB2fGACcFu8fvJzx8c=","To":"Xavier Roumegue <xavier.roumegue@oss.nxp.com>,\n\tnicolas.dufresne@collabora.com, laurent.pinchart@ideasonboard.com","References":"<20211130182315.154181-1-xavier.roumegue@oss.nxp.com>\n\t<20211201075233.218836-1-xavier.roumegue@oss.nxp.com>","From":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<173ef581-0fe6-4d74-9ccb-ffdaf4b73bde@ideasonboard.com>","Date":"Wed, 1 Dec 2021 15:34:46 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211201075233.218836-1-xavier.roumegue@oss.nxp.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2] test: gstreamer: Avoid call to\n\tdeprecated gst_element_get_request_pad()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":21512,"web_url":"https://patchwork.libcamera.org/comment/21512/","msgid":"<163835597564.3059017.15791543693042383689@Monstersaurus>","date":"2021-12-01T10:52:55","subject":"Re: [libcamera-devel] [PATCH v2] test: gstreamer: Avoid call to\n\tdeprecated gst_element_get_request_pad()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Xavier Roumegue (2021-12-01 07:52:33)\n> gst_element_get_request_pad() is being replaced by gst_element_request_simple()\n> since 1.19.1, throwing a warning in case of use until its definitive\n> replacement on 1.20.\n> \n> Hence, prefer using gst_element_request_simple() in case gstreamer\n> version is >= 1.19.1 to avoid the compilation error below (tested on f35):\n> \n> [258/391] Compiling C++ object test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o\n> FAILED: test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o\n> c++ -Itest/gstreamer/multi_stream_test.p -Itest/gstreamer -I../test/gstreamer -Itest/libtest -I../test/libtest -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -g -Wshadow -include config.h -pthread -DLIBCAMERA_BASE_PRIVATE -MD -MQ test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o -MF test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o.d -o test/gstreamer/multi_stream_test.p/gstreamer_multi_stream_test.cpp.o -c ../test/gstreamer/gstreamer_multi_stream_test.cpp\n> ../test/gstreamer/gstreamer_multi_stream_test.cpp: In member function ‘virtual int GstreamerMultiStreamTest::run()’:\n> ../test/gstreamer/gstreamer_multi_stream_test.cpp:90:76: error: ‘GstPad* gst_element_get_request_pad(GstElement*, const gchar*)’ is deprecated: Use 'gst_element_request_pad_simple' instead [-Werror=deprecated-declarations]\n>    90 |                 g_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, \"src_%u\");\n>       |                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~\n> In file included from /usr/include/gstreamer-1.0/gst/gstbin.h:27,\n>                  from /usr/include/gstreamer-1.0/gst/gst.h:35,\n>                  from ../test/gstreamer/gstreamer_multi_stream_test.cpp:13:\n> /usr/include/gstreamer-1.0/gst/gstelement.h:1042:25: note: declared here\n>  1042 | GstPad*                 gst_element_get_request_pad     (GstElement *element, const gchar *name);\n>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~\n> cc1plus: all warnings being treated as errors\n> \n> Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>\n> ---\n>  test/gstreamer/gstreamer_multi_stream_test.cpp | 10 +++++++++-\n>  1 file changed, 9 insertions(+), 1 deletion(-)\n> \n> diff --git a/test/gstreamer/gstreamer_multi_stream_test.cpp b/test/gstreamer/gstreamer_multi_stream_test.cpp\n> index d3d7a9d3..112f1dee 100644\n> --- a/test/gstreamer/gstreamer_multi_stream_test.cpp\n> +++ b/test/gstreamer/gstreamer_multi_stream_test.cpp\n> @@ -15,6 +15,14 @@\n>  #include \"gstreamer_test.h\"\n>  #include \"test.h\"\n>  \n> +#if !GST_CHECK_VERSION(1, 19, 1)\n\nI had to go check, at least for myself if this supports later\nversions...\n\n\" Check whether a GStreamer version equal to or greater than\nmajor.minor.micro is present. \"\n\nso that's a pass...\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> +static inline GstPad *gst_element_request_pad_simple(GstElement *element,\n> +                                                    const gchar *name)\n> +{\n> +       return gst_element_get_request_pad(element, name);\n> +}\n> +#endif\n> +\n>  using namespace std;\n>  \n>  class GstreamerMultiStreamTest : public GstreamerTest, public Test\n> @@ -87,7 +95,7 @@ protected:\n>                                  stream0_, stream1_, NULL);\n>  \n>                 g_autoptr(GstPad) src_pad = gst_element_get_static_pad(libcameraSrc_, \"src\");\n> -               g_autoptr(GstPad) request_pad = gst_element_get_request_pad(libcameraSrc_, \"src_%u\");\n> +               g_autoptr(GstPad) request_pad = gst_element_request_pad_simple(libcameraSrc_, \"src_%u\");\n>  \n>                 {\n>                         g_autoptr(GstPad) queue0_sink_pad = gst_element_get_static_pad(stream0_, \"sink\");\n> -- \n> 2.33.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 598E6BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  1 Dec 2021 10:53:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA6AD60718;\n\tWed,  1 Dec 2021 11:52:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 456606011D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  1 Dec 2021 11:52:58 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DA551A15;\n\tWed,  1 Dec 2021 11:52:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jw04xmSx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638355978;\n\tbh=AC0/HGIwDngQG7deiIwVfLOcZJcc/PH0oyYTiAXfzEQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=jw04xmSxxwnyBcEs4Rgb0SQ1bEKWsBV6sxFHtsIzQgOhppy0WlueEDvfkvVJEaPRB\n\to1bAXkoM8K3pY1+tSPNjBho2jKo/q4Mo75jImdkgr6eYlzJJWQI55BbetSQ7b1Y+9u\n\tV+zoDAb+4MXh9rtGI4X+wztKCfalPaAq4mcAWs1Y=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211201075233.218836-1-xavier.roumegue@oss.nxp.com>","References":"<20211130182315.154181-1-xavier.roumegue@oss.nxp.com>\n\t<20211201075233.218836-1-xavier.roumegue@oss.nxp.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Xavier Roumegue <xavier.roumegue@oss.nxp.com>,\n\tlaurent.pinchart@ideasonboard.com, nicolas.dufresne@collabora.com","Date":"Wed, 01 Dec 2021 10:52:55 +0000","Message-ID":"<163835597564.3059017.15791543693042383689@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2] test: gstreamer: Avoid call to\n\tdeprecated gst_element_get_request_pad()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]