[{"id":21478,"web_url":"https://patchwork.libcamera.org/comment/21478/","msgid":"","date":"2021-12-01T00:25:30","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV2680 sensor\n\tproperties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Tue, Nov 30, 2021 at 09:34:11PM +0000, Daniel Scally wrote:\n> Add camera sensor properties for the OV2680 sensor - this is the\n> user facing camera on the Lenovo Miix 510.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 48305ac4..a97552ce 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov2680\", {\n> +\t\t\t.unitCellSize = { 1750, 1750 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n\nDoes this match the colour bars test pattern defined by the CCS\nspecification, as described by the test pattern control documentation ?\nIf not, I wouldn't enable it for now (we don't have support for custom\npatterns yet).\n\n> +\t\t\t\t/*\n> +\t\t\t\t * No corresponding test pattern mode for:\n> +\t\t\t\t * 2. \"Random Data\"\n> +\t\t\t\t * 3. \"Square\"\n> +\t\t\t\t * 4. \"Black Image\n> +\t\t\t\t */\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov5647\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9C09BDB13\n\tfor ;\n\tWed, 1 Dec 2021 00:25:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54C3D60710;\n\tWed, 1 Dec 2021 01:25:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C0F460592\n\tfor ;\n\tWed, 1 Dec 2021 01:25:55 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A6648AE;\n\tWed, 1 Dec 2021 01:25:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jfoIXZUv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638318355;\n\tbh=VhK9FZXuKLqc6mP+kfJlswGlcBBm3cw5KfMKlOlmvsk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jfoIXZUvUZyjf59WRedfDiQCymGXUW/fjSHnl7yXkiOakfq4VuPLUvos1Om6AfSRg\n\txVT/fSedsKe0TanAd3q+Ug+/V08qFHy+A+4YPXXjwaPEn9HRcVNeFwgT/0xCFYaz5E\n\t5NMROQmrDWcub3DgpJOhGTVbuUII/+xINNVu3Lfc=","Date":"Wed, 1 Dec 2021 02:25:30 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Message-ID":"","References":"<20211130213411.20149-1-djrscally@gmail.com>\n\t<20211130213411.20149-3-djrscally@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211130213411.20149-3-djrscally@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add OV2680 sensor\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]