{"id":14905,"url":"https://patchwork.libcamera.org/api/patches/14905/?format=json","web_url":"https://patchwork.libcamera.org/patch/14905/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211130155600.2203123-9-hiroh@chromium.org>","date":"2021-11-30T15:55:56","name":"[libcamera-devel,v3,08/12] android: camera_stream: Protect buffers initialization by mutex_","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bc04f6746da1cadb05a3690909b3a1f8da062293","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14905/mbox/","series":[{"id":2785,"url":"https://patchwork.libcamera.org/api/series/2785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2785","date":"2021-11-30T15:55:48","name":"Introduce clang thread safety annotations","version":3,"mbox":"https://patchwork.libcamera.org/series/2785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14905/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14905/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7BC3C324F\n\tfor ;\n\tTue, 30 Nov 2021 15:56:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BE1560727;\n\tTue, 30 Nov 2021 16:56:26 +0100 (CET)","from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com\n\t[IPv6:2607:f8b0:4864:20::1035])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3468F605C4\n\tfor ;\n\tTue, 30 Nov 2021 16:56:23 +0100 (CET)","by mail-pj1-x1035.google.com with SMTP id h24so15695057pjq.2\n\tfor ;\n\tTue, 30 Nov 2021 07:56:23 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:c90a:5a53:b139:1336])\n\tby smtp.gmail.com with ESMTPSA id\n\tpc10sm3510283pjb.9.2021.11.30.07.56.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 07:56:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"nu5eTPmP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=aisRSY5NBfEGCdy/9ndvSRH0p2htKgt/zk8gIFRC0cU=;\n\tb=nu5eTPmP+cc4a6g2SsJKzg55jkuH8Kn4pITBi/BlD0LS3FN59j4VBGUpK7kus1j4Ks\n\tJeVfZE6FuBYUWjynExev/tbkPLl43I3MtPfznSQFHVtiXLifQrkYQhhjQkjEPSCksBe/\n\tULYHeOik5AoOIxmbXOZ+Gg2Niz3uTBFxdSR6M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=aisRSY5NBfEGCdy/9ndvSRH0p2htKgt/zk8gIFRC0cU=;\n\tb=ybvb37FJZtROlLEzc9+vcLA/NPBwoNxay75T930Csbb0LJBo7ccHJq99bm3YuuNjuT\n\tfUwg8nk/tA50FLHTB0HM97K+oa+G18A8m+CZdZJviDuC7k7L/N4WH+DltFkV701hOTV6\n\t1mkRVNwf4mgPhwSEdMkNihc0kq73cjhQBRNCwehCPuJjV89497a5sz3KP5PJB35240q0\n\tjp440IkmEtsfJandmMpV84qG5SNKPMUs07gSMVJrmPCG09Lvr2RJEybAqFVapjsOqJOh\n\tdMmO9xwtxt2TvZRo5u9VhlQKX/rr+mumTA0ST5kyk8q6gEr27GUCuE3IxYdaZDNh/Dle\n\t2mzA==","X-Gm-Message-State":"AOAM530lRAZQyYHBmDvOt1ZVaAbQU7JSgrSr0s/SEYtTISnWfst9EVeM\n\tEbUBHO7b5Th10T+eyIszbB2QUtFH25FCTg==","X-Google-Smtp-Source":"ABdhPJyZeZBkttFlNHi8w1Ic7qIZjqNSEdPbXf7J8WbaK9xi5zlqBtkX64gdncQUWgwTCjj1J35Q6A==","X-Received":"by 2002:a17:902:b78b:b0:143:baac:2ebc with SMTP id\n\te11-20020a170902b78b00b00143baac2ebcmr187265pls.77.1638287781579; \n\tTue, 30 Nov 2021 07:56:21 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Dec 2021 00:55:56 +0900","Message-Id":"<20211130155600.2203123-9-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc2.393.gf8c9666880-goog","In-Reply-To":"<20211130155600.2203123-1-hiroh@chromium.org>","References":"<20211130155600.2203123-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 08/12] android: camera_stream: Protect\n\tbuffers initialization by mutex_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The initialization on buffers_ in CameraStrean::configure() is not\nprotected by mutex_. It is no problem because configure() is not\ninvoked simultaneously while other functions are called. This\nprotects it to keep the thread safety consistency for buffers access.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_stream.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 5a62b7cd..2181d094 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -125,6 +125,7 @@ int CameraStream::configure()\n \t\tif (ret < 0)\n \t\t\treturn ret;\n \n+\t\tMutexLocker lock(*mutex_);\n \t\t/* Save a pointer to the reserved frame buffers */\n \t\tfor (const auto &frameBuffer : allocator_->buffers(stream()))\n \t\t\tbuffers_.push_back(frameBuffer.get());\n","prefixes":["libcamera-devel","v3","08/12"]}