[{"id":21458,"web_url":"https://patchwork.libcamera.org/comment/21458/","msgid":"<163829000208.3059017.14688388096506623377@Monstersaurus>","date":"2021-11-30T16:33:22","subject":"Re: [libcamera-devel] [PATCH v1.1] ipa: rkisp1: Initialize numCells\n\tin constructor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-30 07:10:58)\n> The non-static class member \"numCells_\" is not initialized in the\n> constructor. Fix it.\n> \n\nThis is never used uninitialised, as it's always set in the configure\ncall, but I think it's fine to clean it up.\n\n\nReviewed-by: Kieran Bingham \n\n> Reported-by: Coverity CID 365801\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Umang Jain \n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 650fe2dae..d6abdc310 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -53,7 +53,7 @@ static constexpr uint32_t kNumStartupFrames = 10;\n> static constexpr double kRelativeLuminanceTarget = 0.4;\n> \n> Agc::Agc()\n> - : frameCount_(0), filteredExposure_(0s)\n> + : frameCount_(0), numCells_(0), filteredExposure_(0s)\n> {\n> }\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FA1CBDB13\n\tfor ;\n\tTue, 30 Nov 2021 16:33:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73EFB60720;\n\tTue, 30 Nov 2021 17:33:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33880605C4\n\tfor ;\n\tTue, 30 Nov 2021 17:33:25 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3FF88F0;\n\tTue, 30 Nov 2021 17:33:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m3I9SePV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638290004;\n\tbh=2WIh+YhbVkchjOAlfV9U5FGpIwD7R1tSx+/8TGvPFxM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=m3I9SePV1M7oF75FHf66el/NC92WcPBNuGIfIHwGwE+oO9hKY9sJMpupiXiJUDDAH\n\tg/Ee7QvzLTmTc91rnO8/yGO0/c0qMmwtdOMaomSRYXMvpyj3hfuE3IcbSRFxKIURtt\n\t1atYrG1GMTvbFA7fjqHk4iwvcbnTNFzI6vBRg72M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211130071058.47834-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211130071058.47834-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 30 Nov 2021 16:33:22 +0000","Message-ID":"<163829000208.3059017.14688388096506623377@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v1.1] ipa: rkisp1: Initialize numCells\n\tin constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]