[{"id":21415,"web_url":"https://patchwork.libcamera.org/comment/21415/","msgid":"<5cd1bfb5-b826-5b55-b422-50d1cdfe2420@ideasonboard.com>","date":"2021-11-30T07:02:17","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Initialize numCells in\n\tconstructor","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM,\n\nOn 11/30/21 12:15 PM, Jean-Michel Hautbois wrote:\n> The non-static class member \"numCells_\" is not initialized in the\n> constructor, leading to a coverity scan report (UNINIT_CTOR).\n>\n> Fix it.\n\n\nUsually we should also mention the report as per:\n\n     $ git log --grep=Coverity | grep CID\n\n     Reported-by: Coverity CID=361652\n     Reported-by: Coverity CID=354657\n     ...\n\n\nReviewed-by: Umang Jain \n\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 650fe2dae..d6abdc310 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -53,7 +53,7 @@ static constexpr uint32_t kNumStartupFrames = 10;\n> static constexpr double kRelativeLuminanceTarget = 0.4;\n> \n> Agc::Agc()\n> -\t: frameCount_(0), filteredExposure_(0s)\n> +\t: frameCount_(0), numCells_(0), filteredExposure_(0s)\n> {\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12D9CBDB13\n\tfor ;\n\tTue, 30 Nov 2021 07:02:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64D1E604FC;\n\tTue, 30 Nov 2021 08:02:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB288604FC\n\tfor ;\n\tTue, 30 Nov 2021 08:02:22 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C83E98F0;\n\tTue, 30 Nov 2021 08:02:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p7GHzhSD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638255742;\n\tbh=mIn6p9sgza1M8jf89hi2tOHPB9O0VGAfDWe78qWaDNc=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=p7GHzhSD3NuxcmOQpc0+EkGaD8Q1ldLAAmCmkm6wY/F0meLvXV0/hM0FZo3hBc+Um\n\tly9kUVVsJKDgRfINC9nRnabAyrU+Qs6Su+Hzzs1BhiMmbMp8ulqpqy+EngcmBnejai\n\ts546FRVnCS4Tbbek9eFAFBRaZ79MSa26bQV3oV8w=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<5cd1bfb5-b826-5b55-b422-50d1cdfe2420@ideasonboard.com>","Date":"Tue, 30 Nov 2021 12:32:17 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Initialize numCells in\n\tconstructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21417,"web_url":"https://patchwork.libcamera.org/comment/21417/","msgid":"","date":"2021-11-30T07:11:28","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Initialize numCells in\n\tconstructor","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Umang,\n\nOn 30/11/2021 08:02, Umang Jain wrote:\n> Hi JM,\n> \n> On 11/30/21 12:15 PM, Jean-Michel Hautbois wrote:\n>> The non-static class member \"numCells_\" is not initialized in the\n>> constructor, leading to a coverity scan report (UNINIT_CTOR).\n>>\n>> Fix it.\n> \n> \n> Usually we should also mention the report as per:\n> \n>     $ git log --grep=Coverity | grep CID\n> \n>     Reported-by: Coverity CID=361652\n>     Reported-by: Coverity CID=354657\n>     ...\n> \n> \n> Reviewed-by: Umang Jain \n\nThanks, fixed the reported-by in v1.1 ;-).\n\n> \n>> Signed-off-by: Jean-Michel Hautbois \n>> \n>> ---\n>>   src/ipa/rkisp1/algorithms/agc.cpp | 2 +-\n>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp \n>> b/src/ipa/rkisp1/algorithms/agc.cpp\n>> index 650fe2dae..d6abdc310 100644\n>> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n>> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n>> @@ -53,7 +53,7 @@ static constexpr uint32_t kNumStartupFrames = 10;\n>>   static constexpr double kRelativeLuminanceTarget = 0.4;\n>>   Agc::Agc()\n>> -    : frameCount_(0), filteredExposure_(0s)\n>> +    : frameCount_(0), numCells_(0), filteredExposure_(0s)\n>>   {\n>>   }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F20C0BF415\n\tfor ;\n\tTue, 30 Nov 2021 07:11:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A91B6605B4;\n\tTue, 30 Nov 2021 08:11:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56F8C604FC\n\tfor ;\n\tTue, 30 Nov 2021 08:11:31 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:699a:a10f:5b1e:89b7] (unknown\n\t[IPv6:2a01:e0a:169:7140:699a:a10f:5b1e:89b7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A4BB8F0;\n\tTue, 30 Nov 2021 08:11:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jTbH3fce\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638256291;\n\tbh=ZwwwyIiHaOp2fT8EY519RzVmFoV1AfWivJkorficO9A=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=jTbH3fceemAmMlK79FkMcQTYe0ifEac3WVba0pzLdrcYzhh6MqKf5m0lGg3gruaHa\n\tHQoISlo16eGrqfWAuZhrAM9VnmKoCuXU3prYu6t1X7WOp0mqyP+LpoRStulBbfBiNi\n\tJRy0aVYZQcjfvJZekBPmpsaM6Uvg5sA3+ALMjZDc=","Message-ID":"","Date":"Tue, 30 Nov 2021 08:11:28 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.3.1","Content-Language":"en-US","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211130064547.37598-1-jeanmichel.hautbois@ideasonboard.com>\n\t<5cd1bfb5-b826-5b55-b422-50d1cdfe2420@ideasonboard.com>","From":"Jean-Michel Hautbois ","In-Reply-To":"<5cd1bfb5-b826-5b55-b422-50d1cdfe2420@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Initialize numCells in\n\tconstructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]