[{"id":21402,"web_url":"https://patchwork.libcamera.org/comment/21402/","msgid":"","date":"2021-11-30T04:34:25","subject":"Re: [libcamera-devel] [PATCH v2 11/11] android: camera_request: Add\n\tthread safety annotation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Mon, Nov 29, 2021 at 08:44:53PM +0900, Hirokazu Honda wrote:\n> This applies clang thread safety annotation to\n> Camera3RequestDescriptor. Mutex and MutexLocker there are\n> replaced with Mutex2 and MutexLocer2.\n\nNot anymore :-)\n\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Umang Jain \n> ---\n> src/android/camera_request.h | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_request.h b/src/android/camera_request.h\n> index 88d501a8..dfdc3324 100644\n> --- a/src/android/camera_request.h\n> +++ b/src/android/camera_request.h\n> @@ -12,7 +12,8 @@\n> #include \n> \n> #include \n> -#include \n> +#include \n> +#include \n\n02/11 too.\n\nReviewed-by: Laurent Pinchart \n\n> \n> #include \n> #include \n> @@ -57,7 +58,8 @@ public:\n> \t};\n> \n> \t/* Keeps track of streams requiring post-processing. */\n> -\tstd::map pendingStreamsToProcess_;\n> +\tstd::map pendingStreamsToProcess_\n> +\t\tLIBCAMERA_TSA_GUARDED_BY(streamsProcessMutex_);\n> \tlibcamera::Mutex streamsProcessMutex_;\n> \n> \tCamera3RequestDescriptor(libcamera::Camera *camera,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C65ABF415\n\tfor ;\n\tTue, 30 Nov 2021 04:34:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2769605B4;\n\tTue, 30 Nov 2021 05:34:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F97E604FC\n\tfor ;\n\tTue, 30 Nov 2021 05:34:50 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A1288F0;\n\tTue, 30 Nov 2021 05:34:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D2a5LqVt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638246889;\n\tbh=7hFisobb7pkNZ4yNDhMZe847SJiEWPTq5+4VUzZM8xk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=D2a5LqVtd/jolocGD+IElXzH2bPZ0pEKxAsU8vOt+5KpztmU2AJ9GIqNtz7TY9r3G\n\tGt9D5GjYh0fDXG36xx7ZqKMvCPmLkfZOChn9Onvemw6Y/+G3CpZ+O32h1Tt7ruGgCK\n\tmWuR+gb06A24okgg2m5HIaXiIabjuPZQpSX/EAqU=","Date":"Tue, 30 Nov 2021 06:34:25 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20211129114453.3186042-1-hiroh@chromium.org>\n\t<20211129114453.3186042-12-hiroh@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211129114453.3186042-12-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 11/11] android: camera_request: Add\n\tthread safety annotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]