{"id":14843,"url":"https://patchwork.libcamera.org/api/patches/14843/?format=json","web_url":"https://patchwork.libcamera.org/patch/14843/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211129114453.3186042-8-hiroh@chromium.org>","date":"2021-11-29T11:44:49","name":"[libcamera-devel,v2,07/11] android: camera_stream: Protect buffers initialization by mutex_","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"bc04f6746da1cadb05a3690909b3a1f8da062293","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14843/mbox/","series":[{"id":2770,"url":"https://patchwork.libcamera.org/api/series/2770/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2770","date":"2021-11-29T11:44:42","name":"Introduce clang thread safety annotations","version":2,"mbox":"https://patchwork.libcamera.org/series/2770/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14843/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14843/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8B44BF415\n\tfor ;\n\tMon, 29 Nov 2021 11:45:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40537605B6;\n\tMon, 29 Nov 2021 12:45:16 +0100 (CET)","from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com\n\t[IPv6:2607:f8b0:4864:20::1032])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C6A360592\n\tfor ;\n\tMon, 29 Nov 2021 12:45:13 +0100 (CET)","by mail-pj1-x1032.google.com with SMTP id\n\to6-20020a17090a0a0600b001a64b9a11aeso13934218pjo.3\n\tfor ;\n\tMon, 29 Nov 2021 03:45:13 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:f254:cda9:46e8:17b7])\n\tby smtp.gmail.com with ESMTPSA id\n\thg4sm17951966pjb.1.2021.11.29.03.45.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Nov 2021 03:45:11 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"WdMBIyoI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sp5Sw3uSiY5RflgCnmeAXEew7x/3MvLj60NFCnZsN6c=;\n\tb=WdMBIyoIVKUvVKq+ck48MAcl6/4QVFBZ+EpqA3c0gyz0tx61Ev9HUcakY0l3kIFPiZ\n\tWBnW9j9eaxJNzYxPi7prmKAwRj28GPD3jkTqqExNZnN1qhfq8dsbBFosOfDpBKOv4zIt\n\tknJVSLvIegRK8wJpYURiZy5cCi1FhZOn3XalQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sp5Sw3uSiY5RflgCnmeAXEew7x/3MvLj60NFCnZsN6c=;\n\tb=7HaecssufRu6L/eZOjN/f8fErRiJjSZKYhy9CCwg9TijOfkpOeJpcMCBtea2QaoOwU\n\tqcwLXUqTVUMvpVHiHe/K2VCaE7pbYee8mFul5N+pP4w/8MBvbKuYaRXAIXGWs2/NgHBU\n\tmwl56hYZuBSsy3UlDdpAA3JW2rYBlEpEzEbxMwi4BGJZPR+AM7QIKt5rH9p1saZQ6jQM\n\t0AB8/iEqDKUxQpljpKyvQ82Otx+qTnvkelPLsekTAFBeJHBAw2+Xj0RPCwxI7M5cA0m2\n\tzrxBd1UFIqVyKSMgkDD46rcE4+gExPNJ1XVtW+68Cmk++zgopOZMB3Cq6ISt60N/ttQ4\n\tYOfQ==","X-Gm-Message-State":"AOAM532Gp241j4T2+IVcIZhwrsQPpwtA9YXQmbcYjjm+YDvUliEyZ2u7\n\tvLLNbu8WzWPyO7E2SWQsrVCLc7ZTsjxpzA==","X-Google-Smtp-Source":"ABdhPJyrP1QpNkkgQx/GsNKndopbMOb+vK0r1dQ6MI/9XeTzlVaEp/OEVHRffpOa09zPAFko71/3sQ==","X-Received":"by 2002:a17:90a:bf8a:: with SMTP id\n\td10mr37111102pjs.67.1638186311933; \n\tMon, 29 Nov 2021 03:45:11 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Nov 2021 20:44:49 +0900","Message-Id":"<20211129114453.3186042-8-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc2.393.gf8c9666880-goog","In-Reply-To":"<20211129114453.3186042-1-hiroh@chromium.org>","References":"<20211129114453.3186042-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 07/11] android: camera_stream: Protect\n\tbuffers initialization by mutex_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The initialization on buffers_ in CameraStrean::configure() is not\nprotected by mutex_. It is no problem because configure() is not\ninvoked simultaneously while other functions are called. This\nprotects it to keep the thread safety consistency for buffers access.\n\nSigned-off-by: Hirokazu Honda \n---\n src/android/camera_stream.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 5a62b7cd..2181d094 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -125,6 +125,7 @@ int CameraStream::configure()\n \t\tif (ret < 0)\n \t\t\treturn ret;\n \n+\t\tMutexLocker lock(*mutex_);\n \t\t/* Save a pointer to the reserved frame buffers */\n \t\tfor (const auto &frameBuffer : allocator_->buffers(stream()))\n \t\t\tbuffers_.push_back(frameBuffer.get());\n","prefixes":["libcamera-devel","v2","07/11"]}