{"id":1482,"url":"https://patchwork.libcamera.org/api/patches/1482/?format=json","web_url":"https://patchwork.libcamera.org/patch/1482/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190619150636.30172-1-laurent.pinchart@ideasonboard.com>","date":"2019-06-19T15:06:36","name":"[libcamera-devel] meson: Link against libc++ with compiling with clang","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d602483228e708693c3f9b2d6700189f485fda4e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1482/mbox/","series":[{"id":367,"url":"https://patchwork.libcamera.org/api/series/367/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=367","date":"2019-06-19T15:06:36","name":"[libcamera-devel] meson: Link against libc++ with compiling with clang","version":1,"mbox":"https://patchwork.libcamera.org/series/367/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1482/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1482/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35B8061A0C\n\tfor ;\n\tWed, 19 Jun 2019 17:06:59 +0200 (CEST)","from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE2D2333\n\tfor ;\n\tWed, 19 Jun 2019 17:06:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560956818;\n\tbh=ZXqlSP0Na945IFblPU93OTtBCqDcjHEUDZHspy0e2HU=;\n\th=From:To:Subject:Date:From;\n\tb=Qrq9vjHUmPWbbVt0nbpDPh90WMcHjl7VCZRHNRvw+ZY7o4NM0sEglcFhJ+FhPRNHg\n\tXTsuG+cDwa/o9jodogkBrewvJRbYrZUcFZuK7NiQFkwnwdd52n13j2a+i8lBrBNmsN\n\tYaVMYiPkiU3TCk5tHcNA84+zp5nQpioeNc/JZeNI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 19 Jun 2019 18:06:36 +0300","Message-Id":"<20190619150636.30172-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] meson: Link against libc++ with compiling\n\twith clang","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Jun 2019 15:06:59 -0000"},"content":"libc++ is used by Chrome OS, and likely as well by other environments\nbased on clang. Using it by default if available when compiling with\nclang will help extending the compile-testing coverage. The drawback is\nthat issues specific to clang with libstdc++ will not be caught as\neasily, but based on the experience with clang so far, code compiling\ncorrectly with gcc/libstdc++ has failed with clang due to either\nclang-specific or libc++-specific behaviour, never due only to the\ncombination of clang with libstdc++.\n\nSigned-off-by: Laurent Pinchart \n---\n meson.build | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/meson.build b/meson.build\nindex 4d3e99d3e58f..64a26e896a24 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -28,8 +28,17 @@ common_arguments = [\n c_arguments = common_arguments\n cpp_arguments = common_arguments\n \n+# Use libc++ by default if available instead of libstdc++ when compiling with\n+# clang.\n+if cc.get_id() == 'clang' and cc.find_library('libc++').found()\n+ cpp_arguments += [\n+ '-stdlib=libc++',\n+ ]\n+endif\n+\n add_project_arguments(c_arguments, language : 'c')\n add_project_arguments(cpp_arguments, language : 'cpp')\n+add_project_link_arguments(cpp_arguments, language : 'cpp')\n \n libcamera_includes = include_directories('include')\n \n","prefixes":["libcamera-devel"]}