[{"id":21315,"web_url":"https://patchwork.libcamera.org/comment/21315/","msgid":"","date":"2021-11-29T13:05:32","subject":"Re: [libcamera-devel] [PATCH v3 02/17] libcamera: Move\n\tfile_descriptor.h to base/","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Mon, Nov 29, 2021 at 8:58 AM Laurent Pinchart\n wrote:\n>\n> The FileDescriptor class is a generic helper that matches the criteria\n> for the base library. Move it there.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Hirokazu Honda \n> ---\n> include/libcamera/{ => base}/file_descriptor.h | 0\n> include/libcamera/base/meson.build | 1 +\n> include/libcamera/framebuffer.h | 3 +--\n> include/libcamera/internal/ipc_pipe.h | 3 +--\n> include/libcamera/meson.build | 1 -\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> src/libcamera/{ => base}/file_descriptor.cpp | 4 ++--\n> src/libcamera/base/meson.build | 1 +\n> src/libcamera/meson.build | 1 -\n> src/libcamera/pipeline/raspberrypi/dma_heaps.h | 2 +-\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> src/libcamera/v4l2_videodevice.cpp | 3 +--\n> src/v4l2/v4l2_camera.h | 2 +-\n> test/file-descriptor.cpp | 3 +--\n> 14 files changed, 13 insertions(+), 16 deletions(-)\n> rename include/libcamera/{ => base}/file_descriptor.h (100%)\n> rename src/libcamera/{ => base}/file_descriptor.cpp (99%)\n>\n> diff --git a/include/libcamera/file_descriptor.h b/include/libcamera/base/file_descriptor.h\n> similarity index 100%\n> rename from include/libcamera/file_descriptor.h\n> rename to include/libcamera/base/file_descriptor.h\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 23dd4e2023a8..f73b00917409 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -11,6 +11,7 @@ libcamera_base_headers = files([\n> 'event_dispatcher_poll.h',\n> 'event_notifier.h',\n> 'file.h',\n> + 'file_descriptor.h',\n> 'flags.h',\n> 'log.h',\n> 'message.h',\n> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> index 4e710e332370..2fbea9c5be16 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -13,10 +13,9 @@\n> #include \n>\n> #include \n> +#include \n> #include \n>\n> -#include \n> -\n> namespace libcamera {\n>\n> class Request;\n> diff --git a/include/libcamera/internal/ipc_pipe.h b/include/libcamera/internal/ipc_pipe.h\n> index bd8824f255c2..986f8d886fa6 100644\n> --- a/include/libcamera/internal/ipc_pipe.h\n> +++ b/include/libcamera/internal/ipc_pipe.h\n> @@ -9,10 +9,9 @@\n>\n> #include \n>\n> +#include \n> #include \n>\n> -#include \n> -\n> #include \"libcamera/internal/ipc_unixsocket.h\"\n>\n> namespace libcamera {\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index a8cca2a88cad..5f42977c034b 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -6,7 +6,6 @@ libcamera_public_headers = files([\n> 'camera.h',\n> 'camera_manager.h',\n> 'controls.h',\n> - 'file_descriptor.h',\n> 'framebuffer.h',\n> 'framebuffer_allocator.h',\n> 'geometry.h',\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index fed82e223d38..c6aec09046f7 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -15,12 +15,12 @@\n>\n> #include \n>\n> +#include \n> #include \n> #include \n>\n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/base/file_descriptor.cpp\n> similarity index 99%\n> rename from src/libcamera/file_descriptor.cpp\n> rename to src/libcamera/base/file_descriptor.cpp\n> index 0409c3e1758c..f5f87c56eee8 100644\n> --- a/src/libcamera/file_descriptor.cpp\n> +++ b/src/libcamera/base/file_descriptor.cpp\n> @@ -5,7 +5,7 @@\n> * file_descriptor.cpp - File descriptor wrapper\n> */\n>\n> -#include \n> +#include \n>\n> #include \n> #include \n> @@ -16,7 +16,7 @@\n> #include \n>\n> /**\n> - * \\file file_descriptor.h\n> + * \\file base/file_descriptor.h\n> * \\brief File descriptor wrapper\n> */\n>\n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index 05fed7acf561..d5254fda9cbf 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -8,6 +8,7 @@ libcamera_base_sources = files([\n> 'event_dispatcher_poll.cpp',\n> 'event_notifier.cpp',\n> 'file.cpp',\n> + 'file_descriptor.cpp',\n> 'flags.cpp',\n> 'log.cpp',\n> 'message.cpp',\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 6727a777d804..626dfca176a4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -14,7 +14,6 @@ libcamera_sources = files([\n> 'delayed_controls.cpp',\n> 'device_enumerator.cpp',\n> 'device_enumerator_sysfs.cpp',\n> - 'file_descriptor.cpp',\n> 'formats.cpp',\n> 'framebuffer.cpp',\n> 'framebuffer_allocator.cpp',\n> diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.h b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> index 38dfc242c0b9..57beaeb2e48a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> +++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> @@ -7,7 +7,7 @@\n>\n> #pragma once\n>\n> -#include \n> +#include \n>\n> namespace libcamera {\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index ad526a8be6a2..7526edf774a2 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -12,9 +12,10 @@\n> #include \n> #include \n>\n> +#include \n> +\n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 4f04212df672..0a85bcf6b3ff 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -22,11 +22,10 @@\n> #include \n>\n> #include \n> +#include \n> #include \n> #include \n>\n> -#include \n> -\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/media_device.h\"\n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index 94263b2f5db6..0cea111561dd 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -11,10 +11,10 @@\n> #include \n> #include \n>\n> +#include \n> #include \n>\n> #include \n> -#include \n> #include \n> #include \n>\n> diff --git a/test/file-descriptor.cpp b/test/file-descriptor.cpp\n> index 85b077a25c32..76badc4c5fad 100644\n> --- a/test/file-descriptor.cpp\n> +++ b/test/file-descriptor.cpp\n> @@ -11,8 +11,7 @@\n> #include \n> #include \n>\n> -#include \n> -\n> +#include \n> #include \n>\n> #include \"test.h\"\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21BC8BDB13\n\tfor ;\n\tMon, 29 Nov 2021 13:05:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0562605A4;\n\tMon, 29 Nov 2021 14:05:44 +0100 (CET)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 380C360592\n\tfor ;\n\tMon, 29 Nov 2021 14:05:44 +0100 (CET)","by mail-ed1-x530.google.com with SMTP id t5so71839671edd.0\n\tfor ;\n\tMon, 29 Nov 2021 05:05:44 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bcYWSFTb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Ki2NeqF6u6RBdYwkFVTgtb3XGKtRdPKnQWQoaeFyqms=;\n\tb=bcYWSFTb6ZtbdiIIUpqMwZCAqOcwq0xDOfjv9qpvw/QiaVfadQGCM4JbU0mFBVtb5J\n\t1NVQ7l2Zg0GPKkDnxajlGRo0y4+HgVTqf1J3q/hkUttPKS/lu0kw4LaRyAdB5Ninv1pY\n\t7aYQNQ2VjHthqnrxhrj0WBnmBrRlQKSyWBA/g=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Ki2NeqF6u6RBdYwkFVTgtb3XGKtRdPKnQWQoaeFyqms=;\n\tb=42yPzk7VRKahBvMSXIGBDjIVNqFSMXTcHV374GTOubopQ3QPMwZsNEwr/f/lUqizt/\n\tjqy93hIBI1IgO2+762y3n1hzFNyJ+4NwUHjhUt8sR4ricZ/KPj+E7R5rP4KZr/rq/ClU\n\tRNY+bJ5jGX1Vr2q6Cp7UKX/O3gqYxUhGLq5x1rS8862nqKC7mkL6k+Z8Ikae1aqG2+NB\n\tQBxWfdkJ3XCZjaL1sSdAjB6FewfVbjtVDvyRidFvwrHd8+obPuS9GJupw53dJ2UvDcwx\n\tpfBA/W8HA3/ActmXCej6XnGf1vvEL++kqGDFKjeFtZxwLzOZB6EbJhtrIOrgmMfrfu8k\n\tsJAA==","X-Gm-Message-State":"AOAM530dbrmF3wPeqKYbd80ihVKl+hDUvdxiAYkzvRdA0daclKdiUXOL\n\ttIa9r7J6cbA+tL2vqzOulVlnbCfTbrYOlqTDTIAdufS4GQc=","X-Google-Smtp-Source":"ABdhPJxr6kJCoW81yF6weCi0LlU5EFaAldI0trGpzlQW0D7wPUHX9vw4+/gnKGuxhaSnzT7DUE3NiLTmYRI1uSXPUig=","X-Received":"by 2002:a05:6402:2552:: with SMTP id\n\tl18mr74512626edb.368.1638191143814; \n\tMon, 29 Nov 2021 05:05:43 -0800 (PST)","MIME-Version":"1.0","References":"<20211128235752.10836-1-laurent.pinchart@ideasonboard.com>\n\t<20211128235752.10836-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20211128235752.10836-3-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 29 Nov 2021 22:05:32 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 02/17] libcamera: Move\n\tfile_descriptor.h to base/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21329,"web_url":"https://patchwork.libcamera.org/comment/21329/","msgid":"<20211129142508.gqpn3u3okc3k4ebo@uno.localdomain>","date":"2021-11-29T14:25:08","subject":"Re: [libcamera-devel] [PATCH v3 02/17] libcamera: Move\n\tfile_descriptor.h to base/","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Nov 29, 2021 at 01:57:37AM +0200, Laurent Pinchart wrote:\n> The FileDescriptor class is a generic helper that matches the criteria\n> for the base library. Move it there.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/{ => base}/file_descriptor.h | 0\n> include/libcamera/base/meson.build | 1 +\n> include/libcamera/framebuffer.h | 3 +--\n> include/libcamera/internal/ipc_pipe.h | 3 +--\n> include/libcamera/meson.build | 1 -\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> src/libcamera/{ => base}/file_descriptor.cpp | 4 ++--\n> src/libcamera/base/meson.build | 1 +\n> src/libcamera/meson.build | 1 -\n> src/libcamera/pipeline/raspberrypi/dma_heaps.h | 2 +-\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 3 ++-\n> src/libcamera/v4l2_videodevice.cpp | 3 +--\n> src/v4l2/v4l2_camera.h | 2 +-\n> test/file-descriptor.cpp | 3 +--\n> 14 files changed, 13 insertions(+), 16 deletions(-)\n> rename include/libcamera/{ => base}/file_descriptor.h (100%)\n> rename src/libcamera/{ => base}/file_descriptor.cpp (99%)\n>\n> diff --git a/include/libcamera/file_descriptor.h b/include/libcamera/base/file_descriptor.h\n> similarity index 100%\n> rename from include/libcamera/file_descriptor.h\n> rename to include/libcamera/base/file_descriptor.h\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 23dd4e2023a8..f73b00917409 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -11,6 +11,7 @@ libcamera_base_headers = files([\n> 'event_dispatcher_poll.h',\n> 'event_notifier.h',\n> 'file.h',\n> + 'file_descriptor.h',\n> 'flags.h',\n> 'log.h',\n> 'message.h',\n> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> index 4e710e332370..2fbea9c5be16 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -13,10 +13,9 @@\n> #include \n>\n> #include \n> +#include \n> #include \n>\n> -#include \n> -\n> namespace libcamera {\n>\n> class Request;\n> diff --git a/include/libcamera/internal/ipc_pipe.h b/include/libcamera/internal/ipc_pipe.h\n> index bd8824f255c2..986f8d886fa6 100644\n> --- a/include/libcamera/internal/ipc_pipe.h\n> +++ b/include/libcamera/internal/ipc_pipe.h\n> @@ -9,10 +9,9 @@\n>\n> #include \n>\n> +#include \n> #include \n>\n> -#include \n> -\n> #include \"libcamera/internal/ipc_unixsocket.h\"\n>\n> namespace libcamera {\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index a8cca2a88cad..5f42977c034b 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -6,7 +6,6 @@ libcamera_public_headers = files([\n> 'camera.h',\n> 'camera_manager.h',\n> 'controls.h',\n> - 'file_descriptor.h',\n> 'framebuffer.h',\n> 'framebuffer_allocator.h',\n> 'geometry.h',\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index fed82e223d38..c6aec09046f7 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -15,12 +15,12 @@\n>\n> #include \n>\n> +#include \n> #include \n> #include \n>\n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/file_descriptor.cpp b/src/libcamera/base/file_descriptor.cpp\n> similarity index 99%\n> rename from src/libcamera/file_descriptor.cpp\n> rename to src/libcamera/base/file_descriptor.cpp\n> index 0409c3e1758c..f5f87c56eee8 100644\n> --- a/src/libcamera/file_descriptor.cpp\n> +++ b/src/libcamera/base/file_descriptor.cpp\n> @@ -5,7 +5,7 @@\n> * file_descriptor.cpp - File descriptor wrapper\n> */\n>\n> -#include \n> +#include \n>\n> #include \n> #include \n> @@ -16,7 +16,7 @@\n> #include \n>\n> /**\n> - * \\file file_descriptor.h\n> + * \\file base/file_descriptor.h\n> * \\brief File descriptor wrapper\n> */\n>\n> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build\n> index 05fed7acf561..d5254fda9cbf 100644\n> --- a/src/libcamera/base/meson.build\n> +++ b/src/libcamera/base/meson.build\n> @@ -8,6 +8,7 @@ libcamera_base_sources = files([\n> 'event_dispatcher_poll.cpp',\n> 'event_notifier.cpp',\n> 'file.cpp',\n> + 'file_descriptor.cpp',\n> 'flags.cpp',\n> 'log.cpp',\n> 'message.cpp',\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 6727a777d804..626dfca176a4 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -14,7 +14,6 @@ libcamera_sources = files([\n> 'delayed_controls.cpp',\n> 'device_enumerator.cpp',\n> 'device_enumerator_sysfs.cpp',\n> - 'file_descriptor.cpp',\n> 'formats.cpp',\n> 'framebuffer.cpp',\n> 'framebuffer_allocator.cpp',\n> diff --git a/src/libcamera/pipeline/raspberrypi/dma_heaps.h b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> index 38dfc242c0b9..57beaeb2e48a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> +++ b/src/libcamera/pipeline/raspberrypi/dma_heaps.h\n> @@ -7,7 +7,7 @@\n>\n> #pragma once\n>\n> -#include \n> +#include \n>\n> namespace libcamera {\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index ad526a8be6a2..7526edf774a2 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -12,9 +12,10 @@\n> #include \n> #include \n>\n> +#include \n> +\n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 4f04212df672..0a85bcf6b3ff 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -22,11 +22,10 @@\n> #include \n>\n> #include \n> +#include \n> #include \n> #include \n>\n> -#include \n> -\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/media_device.h\"\n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index 94263b2f5db6..0cea111561dd 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -11,10 +11,10 @@\n> #include \n> #include \n>\n> +#include \n> #include \n>\n> #include \n> -#include \n> #include \n> #include \n>\n> diff --git a/test/file-descriptor.cpp b/test/file-descriptor.cpp\n> index 85b077a25c32..76badc4c5fad 100644\n> --- a/test/file-descriptor.cpp\n> +++ b/test/file-descriptor.cpp\n> @@ -11,8 +11,7 @@\n> #include \n> #include \n>\n> -#include \n> -\n> +#include \n> #include \n>\n> #include \"test.h\"\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3541FBDB13\n\tfor ;\n\tMon, 29 Nov 2021 14:24:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E30A5605A4;\n\tMon, 29 Nov 2021 15:24:18 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1D4A60592\n\tfor ;\n\tMon, 29 Nov 2021 15:24:16 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 512D820009;\n\tMon, 29 Nov 2021 14:24:16 +0000 (UTC)"],"Date":"Mon, 29 Nov 2021 15:25:08 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20211129142508.gqpn3u3okc3k4ebo@uno.localdomain>","References":"<20211128235752.10836-1-laurent.pinchart@ideasonboard.com>\n\t<20211128235752.10836-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211128235752.10836-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 02/17] libcamera: Move\n\tfile_descriptor.h to base/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]