[{"id":21313,"web_url":"https://patchwork.libcamera.org/comment/21313/","msgid":"","date":"2021-11-29T13:01:19","subject":"Re: [libcamera-devel] [PATCH v3 01/17] libcamera: Move compiler.h\n\tto base/","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, thank you for the patch.\n\nOn Mon, Nov 29, 2021 at 8:58 AM Laurent Pinchart\n wrote:\n>\n> In preparation for usage of __nodiscard in the base API, move the\n> compiler.h header to base.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Hirokazu Honda \n> ---\n> include/libcamera/{ => base}/compiler.h | 0\n> include/libcamera/base/meson.build | 1 +\n> include/libcamera/geometry.h | 2 +-\n> include/libcamera/meson.build | 1 -\n> 4 files changed, 2 insertions(+), 2 deletions(-)\n> rename include/libcamera/{ => base}/compiler.h (100%)\n>\n> diff --git a/include/libcamera/compiler.h b/include/libcamera/base/compiler.h\n> similarity index 100%\n> rename from include/libcamera/compiler.h\n> rename to include/libcamera/base/compiler.h\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 525aba9d2919..23dd4e2023a8 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -6,6 +6,7 @@ libcamera_base_headers = files([\n> 'backtrace.h',\n> 'bound_method.h',\n> 'class.h',\n> + 'compiler.h',\n> 'event_dispatcher.h',\n> 'event_dispatcher_poll.h',\n> 'event_notifier.h',\n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 713f71c180c6..7838b6793617 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -10,7 +10,7 @@\n> #include \n> #include \n>\n> -#include \n> +#include \n>\n> namespace libcamera {\n>\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 7155ff203f6e..a8cca2a88cad 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -5,7 +5,6 @@ libcamera_include_dir = 'libcamera' / 'libcamera'\n> libcamera_public_headers = files([\n> 'camera.h',\n> 'camera_manager.h',\n> - 'compiler.h',\n> 'controls.h',\n> 'file_descriptor.h',\n> 'framebuffer.h',\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 494BEBF415\n\tfor ;\n\tMon, 29 Nov 2021 13:01:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5C2A605A4;\n\tMon, 29 Nov 2021 14:01:34 +0100 (CET)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C357E60592\n\tfor ;\n\tMon, 29 Nov 2021 14:01:33 +0100 (CET)","by mail-ed1-x534.google.com with SMTP id w1so71663978edc.6\n\tfor ;\n\tMon, 29 Nov 2021 05:01:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Lh42x4ru\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=zVsjLLiqTjfIqA+OBEdnGx+4HX/AWO4Cp9CxIdkMal0=;\n\tb=Lh42x4ru6tMvGVFt3DXucSh0CjdY5H23PsXKNZPAKSkkdLLk1nvuLjPSOCbPX4l/bG\n\tF8X9dEABymDF61zaYFp1JvsaJC3UVfX+hhsUVN8vFJVrpjx1bPjk+bXKLbCr3VtOVGQU\n\tR28Z8wLg+NUOW9L3pn5Gzaf+JDZjn76z0U4T8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=zVsjLLiqTjfIqA+OBEdnGx+4HX/AWO4Cp9CxIdkMal0=;\n\tb=wogUYlY7dI/B6triuMPa0ntZOZOw8rK621Lik+2DvJY2+dlYnKdYH3sLjiR7GU14QV\n\tUhJ7si0EIe6Q0BuM+d6tyc8nFzGVu8MhyNJ8FfDTUU9vovF3kx8q8Vp0C8Zm6305yVwl\n\tO1wpPirrl9AGmE1yFtFUj3Q6uKnVlYOZCFhV2JLdjggDJmd+WIrssEpvIq06xAvzgKTf\n\tpt5k15gNxb5AiqZK6XakOjQTinAEe8TvEc6MXCZTLURVHnBREbYbMpxzMI06crsB1AhX\n\thtdzyL/nEimPI55OWE8jO0F2RaVf+Lud8foFm0l10B7WK2dqd+GrMaoh1Xus6W0gB2x4\n\tz2CQ==","X-Gm-Message-State":"AOAM5301+YRvgsb1Jj9RKl6FWDiUQWkKgkmkiUXESlqbR2XYbsV1HcLs\n\tVHUwiBq5MWbIaiTNskHgDbqAxypS6E5xBsIvI+Zu3g==","X-Google-Smtp-Source":"ABdhPJz2Q4sxijF0DDkr2gPabMaxm0bFpU6zAsR8uV7Clw6MZm6pnjfrtj5iknhsX+JPUXJamQoe4tPK0mTMBQQUzsQ=","X-Received":"by 2002:a05:6402:1395:: with SMTP id\n\tb21mr75620572edv.299.1638190890857; \n\tMon, 29 Nov 2021 05:01:30 -0800 (PST)","MIME-Version":"1.0","References":"<20211128235752.10836-1-laurent.pinchart@ideasonboard.com>\n\t<20211128235752.10836-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20211128235752.10836-2-laurent.pinchart@ideasonboard.com>","From":"Hirokazu Honda ","Date":"Mon, 29 Nov 2021 22:01:19 +0900","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 01/17] libcamera: Move compiler.h\n\tto base/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21328,"web_url":"https://patchwork.libcamera.org/comment/21328/","msgid":"<20211129142401.35wkaqkynukvu7aj@uno.localdomain>","date":"2021-11-29T14:24:01","subject":"Re: [libcamera-devel] [PATCH v3 01/17] libcamera: Move compiler.h\n\tto base/","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Nov 29, 2021 at 01:57:36AM +0200, Laurent Pinchart wrote:\n> In preparation for usage of __nodiscard in the base API, move the\n> compiler.h header to base.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/{ => base}/compiler.h | 0\n> include/libcamera/base/meson.build | 1 +\n> include/libcamera/geometry.h | 2 +-\n> include/libcamera/meson.build | 1 -\n> 4 files changed, 2 insertions(+), 2 deletions(-)\n> rename include/libcamera/{ => base}/compiler.h (100%)\n>\n> diff --git a/include/libcamera/compiler.h b/include/libcamera/base/compiler.h\n> similarity index 100%\n> rename from include/libcamera/compiler.h\n> rename to include/libcamera/base/compiler.h\n> diff --git a/include/libcamera/base/meson.build b/include/libcamera/base/meson.build\n> index 525aba9d2919..23dd4e2023a8 100644\n> --- a/include/libcamera/base/meson.build\n> +++ b/include/libcamera/base/meson.build\n> @@ -6,6 +6,7 @@ libcamera_base_headers = files([\n> 'backtrace.h',\n> 'bound_method.h',\n> 'class.h',\n> + 'compiler.h',\n> 'event_dispatcher.h',\n> 'event_dispatcher_poll.h',\n> 'event_notifier.h',\n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 713f71c180c6..7838b6793617 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -10,7 +10,7 @@\n> #include \n> #include \n>\n> -#include \n> +#include \n>\n> namespace libcamera {\n>\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 7155ff203f6e..a8cca2a88cad 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -5,7 +5,6 @@ libcamera_include_dir = 'libcamera' / 'libcamera'\n> libcamera_public_headers = files([\n> 'camera.h',\n> 'camera_manager.h',\n> - 'compiler.h',\n> 'controls.h',\n> 'file_descriptor.h',\n> 'framebuffer.h',\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60D7CBDB13\n\tfor ;\n\tMon, 29 Nov 2021 14:23:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84426605A4;\n\tMon, 29 Nov 2021 15:23:11 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D47460592\n\tfor ;\n\tMon, 29 Nov 2021 15:23:09 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 108B1240018;\n\tMon, 29 Nov 2021 14:23:08 +0000 (UTC)"],"Date":"Mon, 29 Nov 2021 15:24:01 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20211129142401.35wkaqkynukvu7aj@uno.localdomain>","References":"<20211128235752.10836-1-laurent.pinchart@ideasonboard.com>\n\t<20211128235752.10836-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211128235752.10836-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 01/17] libcamera: Move compiler.h\n\tto base/","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]