[{"id":1945,"web_url":"https://patchwork.libcamera.org/comment/1945/","msgid":"<20190619144833.GJ21753@pendragon.ideasonboard.com>","date":"2019-06-19T14:48:33","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Add missing\n\tinclude","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacpo,\n\nThank you for the patch.\n\nOn Wed, Jun 19, 2019 at 04:49:17PM +0200, Jacopo Mondi wrote:\n> Include errno.h header to fix missing definition of -EEXIST error code:\n> src/libcamera/formats.cpp:43:11: error: use of undeclared identifier 'EEXIST'\n> \n> Fixes: 1cf709b1d2bb (\"libcamera: formats: Add ImageFormats\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index f1a62d47e678..ee4572e01332 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"formats.h\"\n> \n> +#include \n> +\n> /**\n> * \\file formats.h\n> * \\brief Types and helper methods to handle libcamera image formats","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04E9C61A15\n\tfor ;\n\tWed, 19 Jun 2019 16:48:51 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A3EB333;\n\tWed, 19 Jun 2019 16:48:50 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560955730;\n\tbh=hHwk44QSIC4PMRdGpDr30HXvA34LVKRjwu5op7xV5K0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rA+cLe5h6jdGEh29ao10M4c8xzaCm+cZ34XmNXAWveI3L5SwAqdjOGYRAQCjKGojL\n\tCiRcZ1eRh5rfS+TX1L9jWlP/4aF8jvv3N0NpXf74X9umY5HEDkODPzD5JZx/9XMfYf\n\t4pcBmYFKp1DUywmROSCXEKMcbRY767fcvP0LTXt4=","Date":"Wed, 19 Jun 2019 17:48:33 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190619144833.GJ21753@pendragon.ideasonboard.com>","References":"<20190619144917.8854-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190619144917.8854-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Add missing\n\tinclude","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Jun 2019 14:48:51 -0000"}},{"id":1949,"web_url":"https://patchwork.libcamera.org/comment/1949/","msgid":"<20190619145223.GB4416@bigcity.dyn.berto.se>","date":"2019-06-19T14:52:23","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Add missing\n\tinclude","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for finding this. It's my fault, I wonder why gcc did not warn \nabout this. In any case sorry for the mess.\n\nOn 2019-06-19 16:49:17 +0200, Jacopo Mondi wrote:\n> Include errno.h header to fix missing definition of -EEXIST error code:\n> src/libcamera/formats.cpp:43:11: error: use of undeclared identifier 'EEXIST'\n> \n> Fixes: 1cf709b1d2bb (\"libcamera: formats: Add ImageFormats\")\n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/formats.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index f1a62d47e678..ee4572e01332 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"formats.h\"\n> \n> +#include \n> +\n> /**\n> * \\file formats.h\n> * \\brief Types and helper methods to handle libcamera image formats\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EFE461A0C\n\tfor ;\n\tWed, 19 Jun 2019 16:52:25 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id 16so3532502ljv.10\n\tfor ;\n\tWed, 19 Jun 2019 07:52:25 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\tk82sm3104227lje.30.2019.06.19.07.52.24\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 07:52:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=0DGS8RaVgFXW338q1Wwx20cqtI+EWNtir+ubYZA9gko=;\n\tb=en87WHe+ov6AF3B8ErhCQfJhmNHxYzSzJXloZDqDmxc3+b7XUkOdob8/PMTVWiOn9g\n\tfg1yj4PIBbEPsqq0jMGmwquFWTtjM6xff/cwHDLZhjaVi0QCe09qV6/Nyg11QUCK0LPb\n\t1JEb10xpTQXorTfx7Msgo6GT8WTF4dLzyVT1XVfm5Jy8g4P1FNBV2YSHoSnMNYFvRzvg\n\tRYlG8KHn4KZuEsz6ybfxuoGC2Pu0HhraRLccR+1RGz6QylP1FqO8bF1ltJqSh+8a6PbF\n\tjEpIKRVahxWE0hKyogzom0GQjjSgTPlVWYONrV/A0ZvjVoinqqDzgXFQsjZicXTWb99f\n\tgNjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=0DGS8RaVgFXW338q1Wwx20cqtI+EWNtir+ubYZA9gko=;\n\tb=mG6cZDdOuSg8MkGdRz3fU0YY4YUGbvnSTXZYpNt3OrPT9CfZUSzB5QgDVDq+VhkUkW\n\tssIgmS5GkupatTe17Q9/tuAK/yfhOtxsrExxCvy8Kr9iT22yz7yVL6b38rMW/BqnP5Eq\n\tDi7mk/YVZK1+VHp9e7sqmNCuEHyNdzoUfQ/EX+NktTqgzoc9Ni7tgxLZQOOgjFztAzdh\n\tuYw/zAicD4K8+E10h8hDjQrVxqD3y6ol3XVLSaxUY3xBDI0VJSMH9CrgYRzN2KQjAuus\n\ty/p+jCJmLhPAvPqHlajDh7RJwYrqE7jux3DDbMoD+PtnYt8amTrVxEbLKJSdpzRf1nsd\n\tf9ug==","X-Gm-Message-State":"APjAAAXoihHp8/FeKO+WkkbBwrvxCZ9zElsInZQevHS47/p0tGBjQMTd\n\tSnjUqMtcgZ5s91zgc+ZH9aSwLDwbHFA=","X-Google-Smtp-Source":"APXvYqwJoEWiBhxvMQKDMN/tA2vIwESaFFVMOe/oD+LM569paTRBbo7NOH2ZmI+3c5L/fh30or7aqg==","X-Received":"by 2002:a2e:8e83:: with SMTP id z3mr48424358ljk.98.1560955944869;\n\tWed, 19 Jun 2019 07:52:24 -0700 (PDT)","Date":"Wed, 19 Jun 2019 16:52:23 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190619145223.GB4416@bigcity.dyn.berto.se>","References":"<20190619144917.8854-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190619144917.8854-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.0 (2019-05-25)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Add missing\n\tinclude","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Jun 2019 14:52:25 -0000"}}]