[{"id":21388,"web_url":"https://patchwork.libcamera.org/comment/21388/","msgid":"","date":"2021-11-30T03:52:51","subject":"Re: [libcamera-devel] [PATCH v5 1/4] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Han-lin,\n\nThank you for the patch.\n\nOn Fri, Nov 26, 2021 at 07:29:00PM +0800, Han-Lin Chen wrote:\n> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor\n> V4L2 controls. The patch extend one more field for lens V4L2 controls\n> for auto focus usage.\n> \n> Signed-off-by: Han-Lin Chen \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 16e3462e..cc0d822f 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -24,12 +24,14 @@ struct IPU3Event {\n> \tuint32 bufferId;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPU3Action {\n> \tIPU3Operations op;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPAConfigInfo {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70433BDB13\n\tfor ;\n\tTue, 30 Nov 2021 03:53:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DCD1E605B4;\n\tTue, 30 Nov 2021 04:53:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4E15604FC\n\tfor ;\n\tTue, 30 Nov 2021 04:53:16 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 25C658F0;\n\tTue, 30 Nov 2021 04:53:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KwiCDhuo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638244396;\n\tbh=pbBWlsLBqXSjEuU3v6NTV5NwLV2SwWW3GKcEFi/SqiQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KwiCDhuojitNNx/L0Hk1QfON3c9uxw7vs+d6S++88tzISbl6MeGX362oWJ+i1jAB3\n\tZUD7h9iD5RJ3Tj/c2Kn1f7mnBewbAhBL2Glunt8Ku7goH5vifli49lDo7Q4Ny5CH2S\n\tkKNE96XFWM3cq7XR7co+KGnVj2OGrN6CM+xIbwEM=","Date":"Tue, 30 Nov 2021 05:52:51 +0200","From":"Laurent Pinchart ","To":"Han-Lin Chen ","Message-ID":"","References":"<20211126112903.3276056-1-hanlinchen@chromium.org>\n\t<20211126112903.3276056-2-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211126112903.3276056-2-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v5 1/4] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]