[{"id":1946,"web_url":"https://patchwork.libcamera.org/comment/1946/","msgid":"<20190619145030.zibj7viwnhu6veoq@uno.localdomain>","date":"2019-06-19T14:50:30","subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Include missing\n\tarray header","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n this one in combination with the patch for formats.cpp I just sent\nfixes my build errors on clang and libc++\n\nReviewed-by: Jacopo Mondi \n\nIf you could review the other patch, we should then push them together\n\nThanks\n j\n\nOn Wed, Jun 19, 2019 at 05:41:58PM +0300, Laurent Pinchart wrote:\n> The file uses the std::array class but doesn't include the corresponding\n> header. This breaks compilation with clang and libc++. Fix it.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/stream.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index d60f83246e13..d8e87c62281c 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -8,6 +8,7 @@\n> #include \n>\n> #include \n> +#include \n> #include \n> #include \n> #include \n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1698261A15\n\tfor ;\n\tWed, 19 Jun 2019 16:49:17 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DC9B62000F;\n\tWed, 19 Jun 2019 14:49:15 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 19 Jun 2019 16:50:30 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190619145030.zibj7viwnhu6veoq@uno.localdomain>","References":"<20190619144158.28900-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ie2oyylqh4hjsmp5\"","Content-Disposition":"inline","In-Reply-To":"<20190619144158.28900-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Include missing\n\tarray header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Jun 2019 14:49:17 -0000"}},{"id":1947,"web_url":"https://patchwork.libcamera.org/comment/1947/","msgid":"<20190619145019.GA4416@bigcity.dyn.berto.se>","date":"2019-06-19T14:50:19","subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Include missing\n\tarray header","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for catching this. It's my fault to begin with, sorry about that.\n\nOn 2019-06-19 17:41:58 +0300, Laurent Pinchart wrote:\n> The file uses the std::array class but doesn't include the corresponding\n> header. This breaks compilation with clang and libc++. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/stream.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index d60f83246e13..d8e87c62281c 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -8,6 +8,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> #include \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DD0961A15\n\tfor ;\n\tWed, 19 Jun 2019 16:50:21 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id y17so12387504lfe.0\n\tfor ;\n\tWed, 19 Jun 2019 07:50:21 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\t25sm3085786ljv.40.2019.06.19.07.50.19\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 07:50:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=LcccpAkk6p0Imzx2ScrJktQCs7UvdiikSfBbVC2OFqE=;\n\tb=xV4r2zJQPI1gBELwjCDyFqoABXmI9dKWTmJXC5xb/Y8N4v6pVHBBS2FLtGYnoil19h\n\tnRx+jngMtpt8hCXs5tJjpw9Dx6MktdXPbcrp8Xp56O0svuqRBdYqNDlByq9KyzcyqFSO\n\t2nECXujvIiQ5Cz0r9MwFtjVFNR6D5VnBTh/gENYeJtIbvZeGymwKeCDDyuex0wu2ToZk\n\tGTI1F2Pkqnw3pgTMNpRG5qfeD7cCDp7rHpHDmcirETjX7EFjYyF56X8WhJBlURW5UomO\n\t0F1f8AlksEFxRPk6D+xLc5cvn+YKKn+oX2rl/dQDAO+e0uRXbf3OJ3ImwdEXzEU/opcu\n\t8MpA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=LcccpAkk6p0Imzx2ScrJktQCs7UvdiikSfBbVC2OFqE=;\n\tb=excJraMd8gOLvUF79EeRmcHOzaJ2ZFY17kttlfCMJ9WnYlfB0jBeBosY25GDi4lOJd\n\twxWQp1nTc+77PEI7eo2I7uA2z5V9bfXftuFrcy2U6MW7eyZ5ICHg8z4/w4hZbnyxVuv6\n\tOAUyD3puI4t8errTuZRbXfc8UBsAMXf5dR4mRYExlGsusqCW+JDh8r5F2CyZZGlpWuI+\n\tMqeS+PKqYXna+78YmPCJl3Sh2dvOW2yXkFK3EWN4y7IOKClYdT9+TqLTjdbqoCxgqDPY\n\tFLRhL8+bLzRXII5MzZzjbugkB6f9/te6iR/a7oVV0ZHVU/ShPVusiSdafP/ElmiQt4Me\n\t+qgw==","X-Gm-Message-State":"APjAAAVaMfV2z0QR/AQfjUiYK2+aoaAUaoBbLOTyeam8GYg1V8NX7OFM\n\tunmGUVX+TszFRYLN/Juzo4sokA==","X-Google-Smtp-Source":"APXvYqyo6orAvICJdQ/zTCNajZ9NpRno9i4ozWmL2zZHQWKHD618tnzPCLuMFF1R6I7qvIk9+5xu7Q==","X-Received":"by 2002:a19:4a49:: with SMTP id\n\tx70mr24209262lfa.151.1560955820112; \n\tWed, 19 Jun 2019 07:50:20 -0700 (PDT)","Date":"Wed, 19 Jun 2019 16:50:19 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190619145019.GA4416@bigcity.dyn.berto.se>","References":"<20190619144158.28900-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190619144158.28900-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.0 (2019-05-25)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Include missing\n\tarray header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Jun 2019 14:50:21 -0000"}},{"id":1948,"web_url":"https://patchwork.libcamera.org/comment/1948/","msgid":"<20190619145017.GK21753@pendragon.ideasonboard.com>","date":"2019-06-19T14:50:17","subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Include missing\n\tarray header","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Jun 19, 2019 at 05:41:58PM +0300, Laurent Pinchart wrote:\n> The file uses the std::array class but doesn't include the corresponding\n> header. This breaks compilation with clang and libc++. Fix it.\n> \n\nFixes: 63c578ed9993 (\"libcamera: stream: Add StreamFormats\")\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/stream.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index d60f83246e13..d8e87c62281c 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -8,6 +8,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D44D361A15\n\tfor ;\n\tWed, 19 Jun 2019 16:50:34 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FF67333\n\tfor ;\n\tWed, 19 Jun 2019 16:50:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560955834;\n\tbh=2rckeB2KwBvqVQwrNu1g8+b+U+IiBZSC3wJKR7qe5QQ=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=jmwfnsNm0m7NCIPY6d4Ap8M0Iz7koi1vKlbV/7Doe2DWcxZSgenEaZYES3eyF3wlj\n\tsRsFlNUDLl0IGDzMlrIZfl9Gim4PNYZmk9pk6XNbiSC+XqoDgSN1OFjV/5qkC2WxNv\n\tSrf5gWesnplxIlal5cMfwjQTeVJMo7u7Zi40G0Vo=","Date":"Wed, 19 Jun 2019 17:50:17 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190619145017.GK21753@pendragon.ideasonboard.com>","References":"<20190619144158.28900-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190619144158.28900-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Include missing\n\tarray header","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 19 Jun 2019 14:50:35 -0000"}}]