{"id":1479,"url":"https://patchwork.libcamera.org/api/patches/1479/?format=json","web_url":"https://patchwork.libcamera.org/patch/1479/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190619110858.20980-7-jacopo@jmondi.org>","date":"2019-06-19T11:08:58","name":"[libcamera-devel,v4,6/6,HACK] ipu3: Set and get a few sensor controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"aca05947ccc8f403ea67f7d7094aa4c9d550e7d7","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1479/mbox/","series":[{"id":364,"url":"https://patchwork.libcamera.org/api/series/364/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=364","date":"2019-06-19T11:08:52","name":"Add support for V4L2 Controls","version":4,"mbox":"https://patchwork.libcamera.org/series/364/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1479/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1479/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A598861A1F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Jun 2019 13:07:52 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4B7A8FF802;\n\tWed, 19 Jun 2019 11:07:52 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 19 Jun 2019 13:08:58 +0200","Message-Id":"<20190619110858.20980-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190619110858.20980-1-jacopo@jmondi.org>","References":"<20190619110858.20980-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 6/6] [HACK] ipu3: Set and get a few\n\tsensor controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 19 Jun 2019 11:07:53 -0000"},"content":"Not to merge patch to demonstrate how to set controls on the image\nsensor device.\n\nNot-Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 49 ++++++++++++++++++++++++++++\n 1 file changed, 49 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 8c26d2c8c60c..8401ced17282 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -693,6 +693,55 @@ int PipelineHandlerIPU3::start(Camera *camera)\n \tImgUDevice *imgu = data->imgu_;\n \tint ret;\n \n+\t/* --- Get control values --- */\n+\tV4L2Controls controls;\n+\tcontrols.add(V4L2_CID_EXPOSURE);\n+\tcontrols.add(V4L2_CID_ANALOGUE_GAIN);\n+\tret = cio2->sensor_->getControls(&controls);\n+\tif (ret) {\n+\t\tLOG(Error) << \"Failed to get control values\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (const V4L2Control &ctrl : controls) {\n+\t\tunsigned int id = ctrl.id();\n+\t\tV4L2ControlInfo *info = cio2->sensor_->getControlInfo(id);\n+\t\tif (!info)\n+\t\t\tcontinue;\n+\n+\t\tint val = controls.get(id);\n+\t\tLOG(Error) << \"Control : \" << id << \" - name : \" << info->name()\n+\t\t\t   << \" - value: \" << val;\n+\t}\n+\n+\t/* --- Set control values --- */\n+\tcontrols.set(V4L2_CID_EXPOSURE, 2046);\n+\tcontrols.set(V4L2_CID_ANALOGUE_GAIN, 1024);\n+\n+\tret = cio2->sensor_->setControls(&controls);\n+\tif (ret) {\n+\t\tLOG(IPU3, Error) << \"Failed to set controls\";\n+\t\treturn ret;\n+\t}\n+\n+\t/* --- Get control values back again and verify they have changed --- */\n+\tret = cio2->sensor_->getControls(&controls);\n+\tif (ret) {\n+\t\tLOG(Error) << \"Failed to get control values\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (const V4L2Control &ctrl : controls) {\n+\t\tunsigned int id = ctrl.id();\n+\t\tV4L2ControlInfo *info = cio2->sensor_->getControlInfo(id);\n+\t\tif (!info)\n+\t\t\tcontinue;\n+\n+\t\tint val = controls.get(id);\n+\t\tLOG(Error) << \"Control : \" << id << \" - name : \" << info->name()\n+\t\t\t   << \" - value: \" << val;\n+\t}\n+\n \t/*\n \t * Start the ImgU video devices, buffers will be queued to the\n \t * ImgU output and viewfinder when requests will be queued.\n","prefixes":["libcamera-devel","v4","6/6","HACK"]}