[{"id":21251,"web_url":"https://patchwork.libcamera.org/comment/21251/","msgid":"","date":"2021-11-25T13:45:56","subject":"Re: [libcamera-devel] [PATCH v2 1/2] android: camera_device:\n\tProvide toString() helper for stream_type","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Nov 25, 2021 at 06:42:23PM +0530, Umang Jain wrote:\n> Provide a directionToString() helper to return a human-friendly name\n> for camera3_stream_t->stream_type. Replace the int value being printed\n> in configureStreams() INFO log with directionToString().\n> \n> Signed-off-by: Umang Jain \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 17 ++++++++++++++++-\n> 1 file changed, 16 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f2e0bdbd..ad4bf07c 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -175,6 +175,21 @@ const char *rotationToString(int rotation)\n> \treturn \"INVALID\";\n> }\n> \n> +const char *directionToString(int stream_type)\n> +{\n> +\tswitch (stream_type) {\n> +\tcase CAMERA3_STREAM_OUTPUT:\n> +\t\treturn \"Output\";\n> +\tcase CAMERA3_STREAM_INPUT:\n> +\t\treturn \"Input\";\n> +\tcase CAMERA3_STREAM_BIDIRECTIONAL:\n> +\t\treturn \"Bidirectional\";\n> +\tdefault:\n> +\t\tLOG(HAL, Warning) << \"Unknown stream type: \" << stream_type;\n> +\t\treturn \"Unknown\";\n> +\t}\n> +}\n> +\n> #if defined(OS_CHROMEOS)\n> /*\n> * Check whether the crop_rotate_scale_degrees values for all streams in\n> @@ -548,7 +563,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tPixelFormat format = capabilities_.toPixelFormat(stream->format);\n> \n> \t\tLOG(HAL, Info) << \"Stream #\" << i\n> -\t\t\t << \", direction: \" << stream->stream_type\n> +\t\t\t << \", direction: \" << directionToString(stream->stream_type)\n> \t\t\t << \", width: \" << stream->width\n> \t\t\t << \", height: \" << stream->height\n> \t\t\t << \", format: \" << utils::hex(stream->format)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B262BDB13\n\tfor ;\n\tThu, 25 Nov 2021 13:46:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B82E560371;\n\tThu, 25 Nov 2021 14:46:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6129D60233\n\tfor ;\n\tThu, 25 Nov 2021 14:46:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F264590E;\n\tThu, 25 Nov 2021 14:46:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WZYx6qhu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637847979;\n\tbh=RyIdA90Tw83iJr2AuYPG9uq8/2Y1sQ5F8teFcNTOsgA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WZYx6qhuUBLuZzD/YhCdIF7Lw3oKu8VtS1p0EQ9o3V5/fdHK6UWdsxhvhEkmCtFU8\n\tLBk4sahkxAAgd/6GnBvpuV9cuPQF44ar6QeT/G6FdG696vP7065/KI9P0EV1wWYbpK\n\ta3AwxEdMIJ55MbRFQOOOwcaVwm8Eyb3xrZWNJPE8=","Date":"Thu, 25 Nov 2021 15:45:56 +0200","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"","References":"<20211125131224.927640-1-umang.jain@ideasonboard.com>\n\t<20211125131224.927640-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211125131224.927640-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] android: camera_device:\n\tProvide toString() helper for stream_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]