[{"id":21238,"web_url":"https://patchwork.libcamera.org/comment/21238/","msgid":"<163784129248.3059017.5877048522973241340@Monstersaurus>","date":"2021-11-25T11:54:52","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: ipu3: Shorten exposure and\n\tgain lines","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-25 10:21:41)\n> When the effective sensor values are stored during the EventStatReady\n> event, the lines are long. Fix it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b0c75541..7a010019 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -547,8 +547,10 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n> const ipu3_uapi_stats_3a *stats =\n> reinterpret_cast(mem.data());\n> \n> - context_.frameContext.sensor.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n> - context_.frameContext.sensor.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n> + context_.frameContext.sensor.exposure =\n> + event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n> + context_.frameContext.sensor.gain =\n> + camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n\nThis might also look /read better if we extract the control value first\n?\n\n\t\tint32_t exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n\t\tint32_t gain = event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get();\n\n\t\tcontext_.frameContext.sensor.exposure = exposure;\n\t\tcontext_.frameContext.sensor.gain = camHelper_->gain(gain);\n\nThe compiler will optimise away the extra local variable anyway I\nexpect, so it should generate identical code...\n\nBut either way:\n\nReviewed-by: Kieran Bingham \n\n> \n> parseStatistics(event.frame, event.frameTimestamp, stats);\n> break;\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04CFCBDB13\n\tfor ;\n\tThu, 25 Nov 2021 11:54:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A831D60233;\n\tThu, 25 Nov 2021 12:54:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC65060231\n\tfor ;\n\tThu, 25 Nov 2021 12:54:54 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AAD690E;\n\tThu, 25 Nov 2021 12:54:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Br9CZODe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637841294;\n\tbh=tSqh6Es6vjH4az5cpMq+sSXWAMVhhbxa5lx7wfG/KU4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Br9CZODeLsaLYwfHYftqBe+6xHVARjT5IO28UoWmVQasYpj1FpnuVdH48c5gtSZgq\n\t/fDg14i2Fwd22VqvBjdURM5LM9cgZCf9BxD2zvQI/JKYwP8ideGFbHGcWDs/KQ1tKu\n\tMdeV4dYAhbBf/aSFKs460Av55bLeLZyHoen9iwY0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211125102143.52556-3-jeanmichel.hautbois@ideasonboard.com>","References":"<20211125102143.52556-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211125102143.52556-3-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 11:54:52 +0000","Message-ID":"<163784129248.3059017.5877048522973241340@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: ipu3: Shorten exposure and\n\tgain lines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21242,"web_url":"https://patchwork.libcamera.org/comment/21242/","msgid":"","date":"2021-11-25T12:05:51","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: ipu3: Shorten exposure and\n\tgain lines","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Nov 25, 2021 at 11:54:52AM +0000, Kieran Bingham wrote:\n> Quoting Jean-Michel Hautbois (2021-11-25 10:21:41)\n> > When the effective sensor values are stored during the EventStatReady\n> > event, the lines are long. Fix it.\n> > \n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > src/ipa/ipu3/ipu3.cpp | 6 ++++--\n> > 1 file changed, 4 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index b0c75541..7a010019 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -547,8 +547,10 @@ void IPAIPU3::processEvent(const IPU3Event &event)\n> > const ipu3_uapi_stats_3a *stats =\n> > reinterpret_cast(mem.data());\n> > \n> > - context_.frameContext.sensor.exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n> > - context_.frameContext.sensor.gain = camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n> > + context_.frameContext.sensor.exposure =\n> > + event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n> > + context_.frameContext.sensor.gain =\n> > + camHelper_->gain(event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n> \n> This might also look /read better if we extract the control value first\n> ?\n> \n> \t\tint32_t exposure = event.sensorControls.get(V4L2_CID_EXPOSURE).get();\n> \t\tint32_t gain = event.sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get();\n> \n> \t\tcontext_.frameContext.sensor.exposure = exposure;\n> \t\tcontext_.frameContext.sensor.gain = camHelper_->gain(gain);\n> \n> The compiler will optimise away the extra local variable anyway I\n> expect, so it should generate identical code...\n> \n> But either way:\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > \n> > parseStatistics(event.frame, event.frameTimestamp, stats);\n> > break;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A964BDB13\n\tfor ;\n\tThu, 25 Nov 2021 12:06:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B23D16036F;\n\tThu, 25 Nov 2021 13:06:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 876DE60231\n\tfor ;\n\tThu, 25 Nov 2021 13:06:14 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11CD293;\n\tThu, 25 Nov 2021 13:06:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wJJ5rBgt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637841974;\n\tbh=vGOgqyIKbYvlXkUvGffoBEZohKQsUsAZZZ8GN+ynvh4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wJJ5rBgtRJbNf5PtrwE+xRZvRNTuTPCZjOB3Fp/RjVf2mSFCvhcuVYfr6tw0xU5Qk\n\tXXl8372Mt5rpVvHeHn+OXIUKq8pGRci9paBRoAfaIQXuiyof6rQjC4YHBu16PQoagk\n\tWd9RImWtRXPUQdW5lYh5yj8qiVnhXOK+xUOI2yq4=","Date":"Thu, 25 Nov 2021 14:05:51 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211125102143.52556-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211125102143.52556-3-jeanmichel.hautbois@ideasonboard.com>\n\t<163784129248.3059017.5877048522973241340@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<163784129248.3059017.5877048522973241340@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: ipu3: Shorten exposure and\n\tgain lines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]