[{"id":21216,"web_url":"https://patchwork.libcamera.org/comment/21216/","msgid":"<20211125081028.tghfkhpddjkyv2f3@uno.localdomain>","date":"2021-11-25T08:10:28","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Umang\n\nOn Thu, Nov 25, 2021 at 01:35:18PM +0530, Umang Jain wrote:\n> Provide a directionToString() helper to return a human-friendly name\n> for camera3_stream_t->stream_type. Replace the int value being printed\n> in configureStreams() INFO log with directionToString().\n>\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n> ---\n>  src/android/camera_device.cpp | 16 +++++++++++++++-\n>  1 file changed, 15 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f2e0bdbd..804a71fd 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -175,6 +175,20 @@ const char *rotationToString(int rotation)\n>  \treturn \"INVALID\";\n>  }\n>\n> +const char *directionToString(int stream_type)\n> +{\n> +\tswitch (stream_type) {\n> +\tcase CAMERA3_STREAM_OUTPUT:\n> +\t\treturn \"Output\";\n> +\tcase CAMERA3_STREAM_INPUT:\n> +\t\treturn \"Input\";\n> +\tcase CAMERA3_STREAM_BIDIRECTIONAL:\n> +\t\treturn \"Bidirectional\";\n> +\t}\n> +\n> +\treturn \"Unknown\";\n\nI'm not sure how this 'default' case is better handled, but I guess\nit's fine for now\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n   j\n\n> +}\n> +\n>  #if defined(OS_CHROMEOS)\n>  /*\n>   * Check whether the crop_rotate_scale_degrees values for all streams in\n> @@ -548,7 +562,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>  \t\tPixelFormat format = capabilities_.toPixelFormat(stream->format);\n>\n>  \t\tLOG(HAL, Info) << \"Stream #\" << i\n> -\t\t\t       << \", direction: \" << stream->stream_type\n> +\t\t\t       << \", direction: \" << directionToString(stream->stream_type)\n>  \t\t\t       << \", width: \" << stream->width\n>  \t\t\t       << \", height: \" << stream->height\n>  \t\t\t       << \", format: \" << utils::hex(stream->format)\n> --\n> 2.31.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3168BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 08:09:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0075C60233;\n\tThu, 25 Nov 2021 09:09:38 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CAC160228\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 09:09:37 +0100 (CET)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 8FD9540004;\n\tThu, 25 Nov 2021 08:09:36 +0000 (UTC)"],"Date":"Thu, 25 Nov 2021 09:10:28 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<20211125081028.tghfkhpddjkyv2f3@uno.localdomain>","References":"<20211125080518.779815-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211125080518.779815-1-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":21217,"web_url":"https://patchwork.libcamera.org/comment/21217/","msgid":"<CAO5uPHOO6dUjzYp=Mu-4wkSirOckoJdEh2SdOBQ59ERX7pGSOA@mail.gmail.com>","date":"2021-11-25T09:01:47","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Umang,\n\nOn Thu, Nov 25, 2021 at 5:09 PM Jacopo Mondi <jacopo@jmondi.org> wrote:\n>\n> Hi Umang\n>\n> On Thu, Nov 25, 2021 at 01:35:18PM +0530, Umang Jain wrote:\n> > Provide a directionToString() helper to return a human-friendly name\n> > for camera3_stream_t->stream_type. Replace the int value being printed\n> > in configureStreams() INFO log with directionToString().\n> >\n> > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n> > ---\n> >  src/android/camera_device.cpp | 16 +++++++++++++++-\n> >  1 file changed, 15 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index f2e0bdbd..804a71fd 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -175,6 +175,20 @@ const char *rotationToString(int rotation)\n> >       return \"INVALID\";\n> >  }\n> >\n> > +const char *directionToString(int stream_type)\n> > +{\n> > +     switch (stream_type) {\n> > +     case CAMERA3_STREAM_OUTPUT:\n> > +             return \"Output\";\n> > +     case CAMERA3_STREAM_INPUT:\n> > +             return \"Input\";\n> > +     case CAMERA3_STREAM_BIDIRECTIONAL:\n> > +             return \"Bidirectional\";\n> > +     }\n> > +\n> > +     return \"Unknown\";\n>\n> I'm not sure how this 'default' case is better handled, but I guess\n> it's fine for now\n\nPerhaps,\n\ndefault:\n   LOG(HAL, WARNING) << \"Unknown stream type: \" << stream_type;\n   return \"Unknown\";\n\n\nReviewed-by: Hirokazu Honda <hiroh@chromium.org>\n-Hiro\n>\n> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n>\n> Thanks\n>    j\n>\n> > +}\n> > +\n> >  #if defined(OS_CHROMEOS)\n> >  /*\n> >   * Check whether the crop_rotate_scale_degrees values for all streams in\n> > @@ -548,7 +562,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> >               PixelFormat format = capabilities_.toPixelFormat(stream->format);\n> >\n> >               LOG(HAL, Info) << \"Stream #\" << i\n> > -                            << \", direction: \" << stream->stream_type\n> > +                            << \", direction: \" << directionToString(stream->stream_type)\n> >                              << \", width: \" << stream->width\n> >                              << \", height: \" << stream->height\n> >                              << \", format: \" << utils::hex(stream->format)\n> > --\n> > 2.31.0\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33D76BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 09:02:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F8AE60233;\n\tThu, 25 Nov 2021 10:01:59 +0100 (CET)","from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com\n\t[IPv6:2a00:1450:4864:20::52f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C1F360228\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 10:01:58 +0100 (CET)","by mail-ed1-x52f.google.com with SMTP id w1so22550347edc.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 01:01:58 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"lwcEgU8v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=lzREt/VrG6Uk5GpAan5UjjJnUwYbVXaSt/tXd+uAl4E=;\n\tb=lwcEgU8vFvoFYn+evaNi/sydDxqaDAwmufEZkW4ZRxuBqDwbW+Ijw+RbeNW9gvnXec\n\tpNlsshhJaSwHKp7Q+FrnOTr+aCBsjT9KMp0XTDrDzvm6HLTOgUyRRUth0LCoE9AEqN0m\n\tFG0t7sVXoMZhhoD2uEmyNzcv9O/6lLhU0b7LY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=lzREt/VrG6Uk5GpAan5UjjJnUwYbVXaSt/tXd+uAl4E=;\n\tb=HRwGbzMoM538Ae1ILjoyxb0UU2aOAcm9ifFGQFg4UK+CoaRd5f5SSPfICfio/vHbxh\n\tfuHu7OxRh9qCE57cyVQSOR2UVxZLrlc8y6MPRLRjuWcZ2vWVxWFetZSSN14JSyZ6K/tp\n\t4vcPxwbtuIDDsh4HRsrG7mNHRiemwK9Vy3l8EjQhhIZyoMmnclcLhCpoChPbZbdwZfTX\n\t9RzAAUCoxev7h3fCORufrE/ICGm60WfDiCXTASBVG12GqeUEMyXAZ7Tiqnk7Vk84doru\n\tW44WUIMq6gjDr6rr3YMvDHMtOS9iyQ7etyGb3ETQHpkLrOdC/8u9loZcfWVNwiycsK9H\n\thF3A==","X-Gm-Message-State":"AOAM533jclzR+dGCF8XPb5F4ZTsBW/0ZcH65nPlRdTfRY4Iqrz5+nwFq\n\t3qOvlFrpoKUYdvfNfJwng8DC6+POm6fobU4+c4GWCQ==","X-Google-Smtp-Source":"ABdhPJwYrzN6C5x20v4h+6A7jls8RbFd5Di7XQjhNTn3ghXNmfzk1KF1DjG4YbCNMx6kEorCBC3MUERjGwZRREDfWhk=","X-Received":"by 2002:a17:906:1456:: with SMTP id\n\tq22mr29473336ejc.291.1637830917802; \n\tThu, 25 Nov 2021 01:01:57 -0800 (PST)","MIME-Version":"1.0","References":"<20211125080518.779815-1-umang.jain@ideasonboard.com>\n\t<20211125081028.tghfkhpddjkyv2f3@uno.localdomain>","In-Reply-To":"<20211125081028.tghfkhpddjkyv2f3@uno.localdomain>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Thu, 25 Nov 2021 18:01:47 +0900","Message-ID":"<CAO5uPHOO6dUjzYp=Mu-4wkSirOckoJdEh2SdOBQ59ERX7pGSOA@mail.gmail.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":21218,"web_url":"https://patchwork.libcamera.org/comment/21218/","msgid":"<163783324173.3059017.18095382920259857656@Monstersaurus>","date":"2021-11-25T09:40:41","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2021-11-25 08:05:18)\n> Provide a directionToString() helper to return a human-friendly name\n> for camera3_stream_t->stream_type. Replace the int value being printed\n> in configureStreams() INFO log with directionToString().\n> \n\nGreat, Human readable is so much better.\n\n\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n> ---\n>  src/android/camera_device.cpp | 16 +++++++++++++++-\n>  1 file changed, 15 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f2e0bdbd..804a71fd 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -175,6 +175,20 @@ const char *rotationToString(int rotation)\n>         return \"INVALID\";\n>  }\n>  \n> +const char *directionToString(int stream_type)\n> +{\n> +       switch (stream_type) {\n> +       case CAMERA3_STREAM_OUTPUT:\n> +               return \"Output\";\n> +       case CAMERA3_STREAM_INPUT:\n> +               return \"Input\";\n> +       case CAMERA3_STREAM_BIDIRECTIONAL:\n> +               return \"Bidirectional\";\n> +       }\n> +\n> +       return \"Unknown\";\n> +}\n> +\n>  #if defined(OS_CHROMEOS)\n>  /*\n>   * Check whether the crop_rotate_scale_degrees values for all streams in\n> @@ -548,7 +562,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>                 PixelFormat format = capabilities_.toPixelFormat(stream->format);\n>  \n>                 LOG(HAL, Info) << \"Stream #\" << i\n> -                              << \", direction: \" << stream->stream_type\n> +                              << \", direction: \" << directionToString(stream->stream_type)\n>                                << \", width: \" << stream->width\n>                                << \", height: \" << stream->height\n>                                << \", format: \" << utils::hex(stream->format)\n\nIs this one possible too? (Format?)\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> -- \n> 2.31.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F75FBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 09:40:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7FA56022D;\n\tThu, 25 Nov 2021 10:40:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C778C60228\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 10:40:44 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6161A881;\n\tThu, 25 Nov 2021 10:40:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YTC1rmXq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637833244;\n\tbh=P501m+gghLvIKL809kVL3M2XtxbpKrN1ENEwSKDBuX0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=YTC1rmXqpLIN2GkzpeHxJrQkJ8K1jkan8WwHrr6UNZMr3BOqG59z2tr5H7W28OCeq\n\tgMBAh5WsNzp0o2gSXJBaoneC4fKkzXGv3+nAXGFve4SB+EmuETC/K/PIZPNy6HdhYR\n\tlyIrmZ2CSCc9x/iOl4yrIFTQtb5NYQIQSBLEBsy4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211125080518.779815-1-umang.jain@ideasonboard.com>","References":"<20211125080518.779815-1-umang.jain@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Umang Jain <umang.jain@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 09:40:41 +0000","Message-ID":"<163783324173.3059017.18095382920259857656@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":21231,"web_url":"https://patchwork.libcamera.org/comment/21231/","msgid":"<7d3f0d44-b61f-b71f-1043-22a0d0e15eb5@ideasonboard.com>","date":"2021-11-25T11:19:20","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 11/25/21 3:10 PM, Kieran Bingham wrote:\n> Quoting Umang Jain (2021-11-25 08:05:18)\n>> Provide a directionToString() helper to return a human-friendly name\n>> for camera3_stream_t->stream_type. Replace the int value being printed\n>> in configureStreams() INFO log with directionToString().\n>>\n> Great, Human readable is so much better.\n>\n>\n>> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n>> ---\n>>   src/android/camera_device.cpp | 16 +++++++++++++++-\n>>   1 file changed, 15 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index f2e0bdbd..804a71fd 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -175,6 +175,20 @@ const char *rotationToString(int rotation)\n>>          return \"INVALID\";\n>>   }\n>>   \n>> +const char *directionToString(int stream_type)\n>> +{\n>> +       switch (stream_type) {\n>> +       case CAMERA3_STREAM_OUTPUT:\n>> +               return \"Output\";\n>> +       case CAMERA3_STREAM_INPUT:\n>> +               return \"Input\";\n>> +       case CAMERA3_STREAM_BIDIRECTIONAL:\n>> +               return \"Bidirectional\";\n>> +       }\n>> +\n>> +       return \"Unknown\";\n>> +}\n>> +\n>>   #if defined(OS_CHROMEOS)\n>>   /*\n>>    * Check whether the crop_rotate_scale_degrees values for all streams in\n>> @@ -548,7 +562,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>>                  PixelFormat format = capabilities_.toPixelFormat(stream->format);\n>>   \n>>                  LOG(HAL, Info) << \"Stream #\" << i\n>> -                              << \", direction: \" << stream->stream_type\n>> +                              << \", direction: \" << directionToString(stream->stream_type)\n>>                                 << \", width: \" << stream->width\n>>                                 << \", height: \" << stream->height\n>>                                 << \", format: \" << utils::hex(stream->format)\n> Is this one possible too? (Format?)\n\n\nYes, good candidate as well. I can spot more cases for this\n\n         DEBUG HAL camera_capabilities.cpp:1788 Output Stream: \n0x00000022 (320x240)[33333333]@30\n         DEBUG HAL camera_capabilities.cpp:1788 Output Stream: \n0x00000022 (640x480)[33333333]@30\n         DEBUG HAL camera_capabilities.cpp:1788 Output Stream: \n0x00000022 (1280x720)[33333333]@30\n         DEBUG HAL camera_capabilities.cpp:1788 Output Stream: \n0x00000022 (1920x1080)[33333333]@30\n         DEBUG HAL camera_capabilities.cpp:1788 Output Stream: \n0x00000022 (4160x3104)[33338000]@30\n         DEBUG HAL camera_capabilities.cpp:1788 Output Stream: \n0x00000023 (320x240)[33333333]@30\n\nSo better to address them all in a separate patch. A formatsMap_ already \nlives in camera_capabilities as far as I can see, we can make use of in \nsome form\n\n>\n>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n>> -- \n>> 2.31.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1EA5BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 25 Nov 2021 11:19:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE5CF6036F;\n\tThu, 25 Nov 2021 12:19:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9DA860231\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Nov 2021 12:19:26 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.170])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 988B690E;\n\tThu, 25 Nov 2021 12:19:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s0KeAZ+y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637839166;\n\tbh=uKS8H5MvQAb4WTwt+hnuITXbRrZ/I1d4T8bhfjWHz9E=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=s0KeAZ+yMUOwZDAcy6VYCzWnV2uDGjHXERmPPdWnrtNdeuefsNVPnnK5hHlx63AP3\n\tWZXt1JwzeZ0VHn/jkV3FNNI+bNgHZl91fbLkaM4vc9OAo5bn+ny2xl4ENkcRZTX5M0\n\tRy3CqW3dNSokHI3Brqm1hbspB400dGGUWGn5nGBY=","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211125080518.779815-1-umang.jain@ideasonboard.com>\n\t<163783324173.3059017.18095382920259857656@Monstersaurus>","From":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<7d3f0d44-b61f-b71f-1043-22a0d0e15eb5@ideasonboard.com>","Date":"Thu, 25 Nov 2021 16:49:20 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<163783324173.3059017.18095382920259857656@Monstersaurus>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Provide\n\ttoString() helper for stream_type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]