[{"id":21168,"web_url":"https://patchwork.libcamera.org/comment/21168/","msgid":"","date":"2021-11-24T02:52:28","subject":"Re: [libcamera-devel] [PATCH 03/15] libcamera: internal: Convert to\n\tpragma once","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Nov 23, 2021 at 10:40:03PM +0000, Kieran Bingham wrote:\n> Remove the verbose #ifndef/#define/#endif pattern for maintaining\n> header idempotency, and replace it with a simple #pragma once.\n> \n> This simplifies the headers, and prevents redundant changes when\n> header files get moved.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/internal/bayer_format.h | 6 ++----\n> include/libcamera/internal/byte_stream_buffer.h | 6 ++----\n> include/libcamera/internal/camera.h | 6 ++----\n> include/libcamera/internal/camera_controls.h | 6 ++----\n> include/libcamera/internal/camera_sensor.h | 6 ++----\n> include/libcamera/internal/camera_sensor_properties.h | 6 ++----\n> include/libcamera/internal/control_serializer.h | 6 ++----\n> include/libcamera/internal/control_validator.h | 6 ++----\n> include/libcamera/internal/delayed_controls.h | 6 ++----\n> include/libcamera/internal/device_enumerator.h | 6 ++----\n> include/libcamera/internal/device_enumerator_sysfs.h | 6 ++----\n> include/libcamera/internal/device_enumerator_udev.h | 6 ++----\n> include/libcamera/internal/formats.h | 5 +----\n> include/libcamera/internal/framebuffer.h | 6 ++----\n> include/libcamera/internal/ipa_data_serializer.h | 6 ++----\n> include/libcamera/internal/ipa_manager.h | 6 ++----\n> include/libcamera/internal/ipa_module.h | 6 ++----\n> include/libcamera/internal/ipa_proxy.h | 6 ++----\n> include/libcamera/internal/ipc_pipe.h | 6 ++----\n> include/libcamera/internal/ipc_pipe_unixsocket.h | 6 ++----\n> include/libcamera/internal/ipc_unixsocket.h | 5 +----\n> include/libcamera/internal/mapped_framebuffer.h | 6 ++----\n> include/libcamera/internal/media_device.h | 6 ++----\n> include/libcamera/internal/media_object.h | 6 ++----\n> include/libcamera/internal/pipeline_handler.h | 6 ++----\n> include/libcamera/internal/process.h | 6 ++----\n> include/libcamera/internal/pub_key.h | 6 ++----\n> include/libcamera/internal/source_paths.h | 6 ++----\n> include/libcamera/internal/sysfs.h | 6 ++----\n> include/libcamera/internal/tracepoints.h.in | 6 ++----\n> include/libcamera/internal/v4l2_device.h | 6 ++----\n> include/libcamera/internal/v4l2_pixelformat.h | 6 ++----\n> include/libcamera/internal/v4l2_subdevice.h | 6 ++----\n> include/libcamera/internal/v4l2_videodevice.h | 6 ++----\n> 34 files changed, 66 insertions(+), 136 deletions(-)\n\n[snip]\n\n> diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in\n> index d0fc136598b6..b093bc6b5eda 100644\n> --- a/include/libcamera/internal/tracepoints.h.in\n> +++ b/include/libcamera/internal/tracepoints.h.in\n> @@ -6,8 +6,8 @@\n> *\n> * This file is auto-generated. Do not edit.\n> */\n> -#ifndef __LIBCAMERA_INTERNAL_TRACEPOINTS_H__\n> -#define __LIBCAMERA_INTERNAL_TRACEPOINTS_H__\n> +\n> +#pragma once\n\nThis header is special and needs to include itself through macro magic,\nso we can't use #pragma once here.\n\nWith this file dropped from the patch,\n\nReviewed-by: Laurent Pinchart \n\n> #if HAVE_TRACING\n> #define LIBCAMERA_TRACEPOINT(...) tracepoint(libcamera, __VA_ARGS__)\n> @@ -36,8 +36,6 @@ inline void unused([[maybe_unused]] Args&& ...args)\n> \n> #endif /* HAVE_TRACING */\n> \n> -#endif /* __LIBCAMERA_INTERNAL_TRACEPOINTS_H__ */\n> -\n> \n> #if HAVE_TRACING\n\n[snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DBD2BF415\n\tfor ;\n\tWed, 24 Nov 2021 02:52:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90FE36022F;\n\tWed, 24 Nov 2021 03:52:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52AC160121\n\tfor ;\n\tWed, 24 Nov 2021 03:52:52 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B78B6D78;\n\tWed, 24 Nov 2021 03:52:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Naqw+Dm/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637722372;\n\tbh=dPllYX1ydEtH0Br7p/s0T+KQu+RKafx2KA7EiEQmI2U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Naqw+Dm/C91UQqTZ7OLkKapt5kTfz1OB/Nm8Ign7ILPs+wFV0pu2votT1z7G3ESda\n\tmwPAmYbwGi1sygG8hyazb0ukYhj8bAGpxW/FaStGwn6dpzq5ruL8e2968cJ3PiSPem\n\tAxuaKdf4C9jHpF10/2bm0xAWyyz1y1ZExoVebaqU=","Date":"Wed, 24 Nov 2021 04:52:28 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>\n\t<20211123224015.3619282-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211123224015.3619282-4-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/15] libcamera: internal: Convert to\n\tpragma once","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21194,"web_url":"https://patchwork.libcamera.org/comment/21194/","msgid":"<163775530935.3059017.3352072172671809706@Monstersaurus>","date":"2021-11-24T12:01:49","subject":"Re: [libcamera-devel] [PATCH 03/15] libcamera: internal: Convert to\n\tpragma once","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-11-24 02:52:28)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Nov 23, 2021 at 10:40:03PM +0000, Kieran Bingham wrote:\n> > Remove the verbose #ifndef/#define/#endif pattern for maintaining\n> > header idempotency, and replace it with a simple #pragma once.\n> > \n> > This simplifies the headers, and prevents redundant changes when\n> > header files get moved.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > include/libcamera/internal/bayer_format.h | 6 ++----\n> > include/libcamera/internal/byte_stream_buffer.h | 6 ++----\n> > include/libcamera/internal/camera.h | 6 ++----\n> > include/libcamera/internal/camera_controls.h | 6 ++----\n> > include/libcamera/internal/camera_sensor.h | 6 ++----\n> > include/libcamera/internal/camera_sensor_properties.h | 6 ++----\n> > include/libcamera/internal/control_serializer.h | 6 ++----\n> > include/libcamera/internal/control_validator.h | 6 ++----\n> > include/libcamera/internal/delayed_controls.h | 6 ++----\n> > include/libcamera/internal/device_enumerator.h | 6 ++----\n> > include/libcamera/internal/device_enumerator_sysfs.h | 6 ++----\n> > include/libcamera/internal/device_enumerator_udev.h | 6 ++----\n> > include/libcamera/internal/formats.h | 5 +----\n> > include/libcamera/internal/framebuffer.h | 6 ++----\n> > include/libcamera/internal/ipa_data_serializer.h | 6 ++----\n> > include/libcamera/internal/ipa_manager.h | 6 ++----\n> > include/libcamera/internal/ipa_module.h | 6 ++----\n> > include/libcamera/internal/ipa_proxy.h | 6 ++----\n> > include/libcamera/internal/ipc_pipe.h | 6 ++----\n> > include/libcamera/internal/ipc_pipe_unixsocket.h | 6 ++----\n> > include/libcamera/internal/ipc_unixsocket.h | 5 +----\n> > include/libcamera/internal/mapped_framebuffer.h | 6 ++----\n> > include/libcamera/internal/media_device.h | 6 ++----\n> > include/libcamera/internal/media_object.h | 6 ++----\n> > include/libcamera/internal/pipeline_handler.h | 6 ++----\n> > include/libcamera/internal/process.h | 6 ++----\n> > include/libcamera/internal/pub_key.h | 6 ++----\n> > include/libcamera/internal/source_paths.h | 6 ++----\n> > include/libcamera/internal/sysfs.h | 6 ++----\n> > include/libcamera/internal/tracepoints.h.in | 6 ++----\n> > include/libcamera/internal/v4l2_device.h | 6 ++----\n> > include/libcamera/internal/v4l2_pixelformat.h | 6 ++----\n> > include/libcamera/internal/v4l2_subdevice.h | 6 ++----\n> > include/libcamera/internal/v4l2_videodevice.h | 6 ++----\n> > 34 files changed, 66 insertions(+), 136 deletions(-)\n> \n> [snip]\n> \n> > diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in\n> > index d0fc136598b6..b093bc6b5eda 100644\n> > --- a/include/libcamera/internal/tracepoints.h.in\n> > +++ b/include/libcamera/internal/tracepoints.h.in\n> > @@ -6,8 +6,8 @@\n> > *\n> > * This file is auto-generated. Do not edit.\n> > */\n> > -#ifndef __LIBCAMERA_INTERNAL_TRACEPOINTS_H__\n> > -#define __LIBCAMERA_INTERNAL_TRACEPOINTS_H__\n> > +\n> > +#pragma once\n> \n> This header is special and needs to include itself through macro magic,\n> so we can't use #pragma once here.\n\nIndeed. This even looked suspicious when I was going through it and I\nintended this file to be in a single commit of its own, but then it got\nincorrectly batched in to internal...\n\nHo hum.\n\nWill drop this change, the ifndef is still suitable for this one.\n\n> \n> With this file dropped from the patch,\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks.\n\n\nOr - how would you feel about adding the following in a separate patch:\n\n/*\n * This file includes itself to support tracepoint construction.\n * pragma once can not be used here.\n */\n\n> \n> > #if HAVE_TRACING\n> > #define LIBCAMERA_TRACEPOINT(...) tracepoint(libcamera, __VA_ARGS__)\n> > @@ -36,8 +36,6 @@ inline void unused([[maybe_unused]] Args&& ...args)\n> > \n> > #endif /* HAVE_TRACING */\n> > \n> > -#endif /* __LIBCAMERA_INTERNAL_TRACEPOINTS_H__ */\n> > -\n> > \n> > #if HAVE_TRACING\n> \n> [snip]\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAB2BBF415\n\tfor ;\n\tWed, 24 Nov 2021 12:01:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AC5960371;\n\tWed, 24 Nov 2021 13:01:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 843E560128\n\tfor ;\n\tWed, 24 Nov 2021 13:01:52 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D584D78;\n\tWed, 24 Nov 2021 13:01:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nJVcVhPX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637755312;\n\tbh=KdBCcCE3l+zlzvNCZotrIgjCHHQ3HtMZIf6Iz/P0+C8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=nJVcVhPXrZnAuo6yQLdNXHwmImrQR0GOziNUHoqiejkiXUm3clrNvIIKoqIXl7fPj\n\tIAjquWYV6KUuF71gMX8LnagqtCEMTZ2S70RFB1vNQ/I+H+YzxWGvL7EmQX8zl2BD2f\n\t9nkSGHgJnbxly9S+d6T1OzzoP2Izl7v6QgbnCv3A=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>\n\t<20211123224015.3619282-4-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Laurent Pinchart ","Date":"Wed, 24 Nov 2021 12:01:49 +0000","Message-ID":"<163775530935.3059017.3352072172671809706@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 03/15] libcamera: internal: Convert to\n\tpragma once","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21196,"web_url":"https://patchwork.libcamera.org/comment/21196/","msgid":"","date":"2021-11-24T12:08:04","subject":"Re: [libcamera-devel] [PATCH 03/15] libcamera: internal: Convert to\n\tpragma once","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Nov 24, 2021 at 12:01:49PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2021-11-24 02:52:28)\n> > On Tue, Nov 23, 2021 at 10:40:03PM +0000, Kieran Bingham wrote:\n> > > Remove the verbose #ifndef/#define/#endif pattern for maintaining\n> > > header idempotency, and replace it with a simple #pragma once.\n> > > \n> > > This simplifies the headers, and prevents redundant changes when\n> > > header files get moved.\n> > > \n> > > Signed-off-by: Kieran Bingham \n> > > ---\n> > > include/libcamera/internal/bayer_format.h | 6 ++----\n> > > include/libcamera/internal/byte_stream_buffer.h | 6 ++----\n> > > include/libcamera/internal/camera.h | 6 ++----\n> > > include/libcamera/internal/camera_controls.h | 6 ++----\n> > > include/libcamera/internal/camera_sensor.h | 6 ++----\n> > > include/libcamera/internal/camera_sensor_properties.h | 6 ++----\n> > > include/libcamera/internal/control_serializer.h | 6 ++----\n> > > include/libcamera/internal/control_validator.h | 6 ++----\n> > > include/libcamera/internal/delayed_controls.h | 6 ++----\n> > > include/libcamera/internal/device_enumerator.h | 6 ++----\n> > > include/libcamera/internal/device_enumerator_sysfs.h | 6 ++----\n> > > include/libcamera/internal/device_enumerator_udev.h | 6 ++----\n> > > include/libcamera/internal/formats.h | 5 +----\n> > > include/libcamera/internal/framebuffer.h | 6 ++----\n> > > include/libcamera/internal/ipa_data_serializer.h | 6 ++----\n> > > include/libcamera/internal/ipa_manager.h | 6 ++----\n> > > include/libcamera/internal/ipa_module.h | 6 ++----\n> > > include/libcamera/internal/ipa_proxy.h | 6 ++----\n> > > include/libcamera/internal/ipc_pipe.h | 6 ++----\n> > > include/libcamera/internal/ipc_pipe_unixsocket.h | 6 ++----\n> > > include/libcamera/internal/ipc_unixsocket.h | 5 +----\n> > > include/libcamera/internal/mapped_framebuffer.h | 6 ++----\n> > > include/libcamera/internal/media_device.h | 6 ++----\n> > > include/libcamera/internal/media_object.h | 6 ++----\n> > > include/libcamera/internal/pipeline_handler.h | 6 ++----\n> > > include/libcamera/internal/process.h | 6 ++----\n> > > include/libcamera/internal/pub_key.h | 6 ++----\n> > > include/libcamera/internal/source_paths.h | 6 ++----\n> > > include/libcamera/internal/sysfs.h | 6 ++----\n> > > include/libcamera/internal/tracepoints.h.in | 6 ++----\n> > > include/libcamera/internal/v4l2_device.h | 6 ++----\n> > > include/libcamera/internal/v4l2_pixelformat.h | 6 ++----\n> > > include/libcamera/internal/v4l2_subdevice.h | 6 ++----\n> > > include/libcamera/internal/v4l2_videodevice.h | 6 ++----\n> > > 34 files changed, 66 insertions(+), 136 deletions(-)\n> > \n> > [snip]\n> > \n> > > diff --git a/include/libcamera/internal/tracepoints.h.in b/include/libcamera/internal/tracepoints.h.in\n> > > index d0fc136598b6..b093bc6b5eda 100644\n> > > --- a/include/libcamera/internal/tracepoints.h.in\n> > > +++ b/include/libcamera/internal/tracepoints.h.in\n> > > @@ -6,8 +6,8 @@\n> > > *\n> > > * This file is auto-generated. Do not edit.\n> > > */\n> > > -#ifndef __LIBCAMERA_INTERNAL_TRACEPOINTS_H__\n> > > -#define __LIBCAMERA_INTERNAL_TRACEPOINTS_H__\n> > > +\n> > > +#pragma once\n> > \n> > This header is special and needs to include itself through macro magic,\n> > so we can't use #pragma once here.\n> \n> Indeed. This even looked suspicious when I was going through it and I\n> intended this file to be in a single commit of its own, but then it got\n> incorrectly batched in to internal...\n> \n> Ho hum.\n> \n> Will drop this change, the ifndef is still suitable for this one.\n> \n> > \n> > With this file dropped from the patch,\n> > \n> > Reviewed-by: Laurent Pinchart \n> \n> Thanks.\n> \n> \n> Or - how would you feel about adding the following in a separate patch:\n> \n> /*\n> * This file includes itself to support tracepoint construction.\n> * pragma once can not be used here.\n> */\n\nI even considered proposing it, so\n\nReviewed-by: Laurent Pinchart \n\n> > > #if HAVE_TRACING\n> > > #define LIBCAMERA_TRACEPOINT(...) tracepoint(libcamera, __VA_ARGS__)\n> > > @@ -36,8 +36,6 @@ inline void unused([[maybe_unused]] Args&& ...args)\n> > > \n> > > #endif /* HAVE_TRACING */\n> > > \n> > > -#endif /* __LIBCAMERA_INTERNAL_TRACEPOINTS_H__ */\n> > > -\n> > > \n> > > #if HAVE_TRACING\n> > \n> > [snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E94A7BDB13\n\tfor ;\n\tWed, 24 Nov 2021 12:08:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9184060371;\n\tWed, 24 Nov 2021 13:08:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0074F60128\n\tfor ;\n\tWed, 24 Nov 2021 13:08:26 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 969561224;\n\tWed, 24 Nov 2021 13:08:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mS+QpZHN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637755706;\n\tbh=Bs+vNIJzI0JWWlP322crH878N7PEKk1ox3mEjsVuS9k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mS+QpZHNWwtdxy5VCucMuPvd4Z6wvw9rjDErrwqd8ECRL7yXKQSXnmUL3ylgWKv5e\n\tzs7q6J53jkPDiyGnbECfAqNleShQltcb/T1rpzSEIRv3ohjtaq8UGI/ubk1YyI7v09\n\tPwds1lnVvNZTG+9hTCiIDEu1octWG+4diYG7BiyY=","Date":"Wed, 24 Nov 2021 14:08:04 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211123224015.3619282-1-kieran.bingham@ideasonboard.com>\n\t<20211123224015.3619282-4-kieran.bingham@ideasonboard.com>\n\t\n\t<163775530935.3059017.3352072172671809706@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<163775530935.3059017.3352072172671809706@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 03/15] libcamera: internal: Convert to\n\tpragma once","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]