{"id":14717,"url":"https://patchwork.libcamera.org/api/patches/14717/?format=json","web_url":"https://patchwork.libcamera.org/patch/14717/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211123150423.125524-5-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-23T15:04:16","name":"[libcamera-devel,v3,04/11] ipa: rkisp1: Instantiate CameraSensorHelper","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"929ed545c00999bcf1c93642bf01d9d081a217d3","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14717/mbox/","series":[{"id":2746,"url":"https://patchwork.libcamera.org/api/series/2746/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2746","date":"2021-11-23T15:04:12","name":"Introduce AGC for RkISP1","version":3,"mbox":"https://patchwork.libcamera.org/series/2746/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14717/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14717/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 166CAC324F\n\tfor ;\n\tTue, 23 Nov 2021 15:04:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58561603F9;\n\tTue, 23 Nov 2021 16:04:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 776486033C\n\tfor ;\n\tTue, 23 Nov 2021 16:04:28 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A3C9F95;\n\tTue, 23 Nov 2021 16:04:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dsy/92pC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637679868;\n\tbh=7EKJLxN6FyygVP3ODjD71RglMl4Afhijn0ZyokJr6KI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dsy/92pCFhYyRwvViT69+2MHndT/iIFm4WZKgtTbdhqWrgSXxBdqKSzpbHmVf4n29\n\twCu13v1bGBBTnlqmKgePfdwP7vBK8GMPa1v7UstS3dr0Qu6TWjHw0dB5j0u+NsRv+k\n\t27MgQ6DFZnVGfWbyLgt8CuAEA0Hp6yp2SzbFlWOM=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Nov 2021 16:04:16 +0100","Message-Id":"<20211123150423.125524-5-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 04/11] ipa: rkisp1: Instantiate\n\tCameraSensorHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the AGC will run, it will use analogue gains as double values. We\nwill need those values to be converted to apply the control. Introduce\nCameraSensorHelper and call it at init().\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/rkisp1/rkisp1.cpp | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 910ad952..73a7f582 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -25,6 +25,8 @@\n \n #include \n \n+#include \"libipa/camera_sensor_helper.h\"\n+\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPARkISP1)\n@@ -73,10 +75,12 @@ private:\n \tunsigned int hwHistBinNMax_;\n \tunsigned int hwGammaOutMaxSamples_;\n \tunsigned int hwHistogramWeightGridsSize_;\n+\n+\t/* Interface to the Camera Helper */\n+\tstd::unique_ptr camHelper_;\n };\n \n-int IPARkISP1::init([[maybe_unused]] const IPASettings &settings,\n-\t\t unsigned int hwRevision)\n+int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision)\n {\n \t/* \\todo Add support for other revisions */\n \tswitch (hwRevision) {\n@@ -100,6 +104,15 @@ int IPARkISP1::init([[maybe_unused]] const IPASettings &settings,\n \t}\n \n \tLOG(IPARkISP1, Debug) << \"Hardware revision is \" << hwRevision;\n+\n+\tcamHelper_ = CameraSensorHelperFactory::create(settings.sensorModel);\n+\tif (!camHelper_) {\n+\t\tLOG(IPARkISP1, Error)\n+\t\t\t<< \"Failed to create camera sensor helper for \"\n+\t\t\t<< settings.sensorModel;\n+\t\treturn -ENODEV;\n+\t}\n+\n \treturn 0;\n }\n \n","prefixes":["libcamera-devel","v3","04/11"]}