[{"id":21146,"web_url":"https://patchwork.libcamera.org/comment/21146/","msgid":"<163768093373.3059017.7270085614277271101@Monstersaurus>","date":"2021-11-23T15:22:13","subject":"Re: [libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the\n\tsensor limits","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-23 15:04:15)\n> The driver is responsible of setting the proper limits for its controls.\n\ns/of/for/\n\n> For instance, imx219 has an analogue gain of 1.0 when the gain code is\n> set to 0. The minimum analogue is forced to be at least 1, which for\n\nThe minimum ... exposure? (Is analogue really correct here?)\n\nAlso\n\nThe minimum [exposure] is currently forced to be\n ^^^^^^^^^\n\nThat just helps readability.\n\nWith that,\n\n\nReviewed-by: Kieran Bingham \n\n> imx219 sets it to 1.00329. Rework this for both IPU3 and RkISP1.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/ipu3/ipu3.cpp | 4 ++--\n> src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index a8d54a5d..b0c75541 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -444,11 +444,11 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> return -EINVAL;\n> }\n> \n> - minExposure_ = std::max(itExp->second.min().get(), 1);\n> + minExposure_ = itExp->second.min().get();\n> maxExposure_ = itExp->second.max().get();\n> exposure_ = minExposure_;\n> \n> - minGain_ = std::max(itGain->second.min().get(), 1);\n> + minGain_ = itGain->second.min().get();\n> maxGain_ = itGain->second.max().get();\n> gain_ = minGain_;\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 7ecbf8ae..910ad952 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -139,11 +139,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> \n> autoExposure_ = true;\n> \n> - minExposure_ = std::max(itExp->second.min().get(), 1);\n> + minExposure_ = itExp->second.min().get();\n> maxExposure_ = itExp->second.max().get();\n> exposure_ = minExposure_;\n> \n> - minGain_ = std::max(itGain->second.min().get(), 1);\n> + minGain_ = itGain->second.min().get();\n> maxGain_ = itGain->second.max().get();\n> gain_ = minGain_;\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DCF3FBF415\n\tfor ;\n\tTue, 23 Nov 2021 15:22:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99BCE60230;\n\tTue, 23 Nov 2021 16:22:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A140360121\n\tfor ;\n\tTue, 23 Nov 2021 16:22:15 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61F31993;\n\tTue, 23 Nov 2021 16:22:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OPW4l1OW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637680935;\n\tbh=/UnXE07BE9S+YH4b8prI1UIIWawGq90LJriJkUVsEns=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=OPW4l1OW9Bo7KfH3UTE8pkKrsLV/p5NMn65tifZG/tXZDlvSRXOreQy77zdOU8+aB\n\tBQwtB0xY03kwRgUIA6QNnyPbsjGyc3xAgB4+z9ZRDpsXdIkLSzS9uBpz7JtXchtbI3\n\tCzqJg9Ymrxvp4KDpOI5eotMpvWEvCc+h5wb5HysM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211123150423.125524-4-jeanmichel.hautbois@ideasonboard.com>","References":"<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123150423.125524-4-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 23 Nov 2021 15:22:13 +0000","Message-ID":"<163768093373.3059017.7270085614277271101@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the\n\tsensor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21147,"web_url":"https://patchwork.libcamera.org/comment/21147/","msgid":"","date":"2021-11-23T15:23:42","subject":"Re: [libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the\n\tsensor limits","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"On 23/11/2021 16:22, Kieran Bingham wrote:\n> Quoting Jean-Michel Hautbois (2021-11-23 15:04:15)\n>> The driver is responsible of setting the proper limits for its controls.\n> \n> s/of/for/\n> \n>> For instance, imx219 has an analogue gain of 1.0 when the gain code is\n>> set to 0. The minimum analogue is forced to be at least 1, which for\n> \n> The minimum ... exposure? (Is analogue really correct here?)\n\nIt is the analogue gain for this imx219 example.\n\n> \n> Also\n> \n> The minimum [exposure] is currently forced to be\n> ^^^^^^^^^\n> \n> That just helps readability.\n> \n> With that,\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n>> imx219 sets it to 1.00329. Rework this for both IPU3 and RkISP1.\n>>\n>> Signed-off-by: Jean-Michel Hautbois \n>> Reviewed-by: Laurent Pinchart \n>> ---\n>> src/ipa/ipu3/ipu3.cpp | 4 ++--\n>> src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n>> 2 files changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index a8d54a5d..b0c75541 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -444,11 +444,11 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n>> return -EINVAL;\n>> }\n>> \n>> - minExposure_ = std::max(itExp->second.min().get(), 1);\n>> + minExposure_ = itExp->second.min().get();\n>> maxExposure_ = itExp->second.max().get();\n>> exposure_ = minExposure_;\n>> \n>> - minGain_ = std::max(itGain->second.min().get(), 1);\n>> + minGain_ = itGain->second.min().get();\n>> maxGain_ = itGain->second.max().get();\n>> gain_ = minGain_;\n>> \n>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n>> index 7ecbf8ae..910ad952 100644\n>> --- a/src/ipa/rkisp1/rkisp1.cpp\n>> +++ b/src/ipa/rkisp1/rkisp1.cpp\n>> @@ -139,11 +139,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n>> \n>> autoExposure_ = true;\n>> \n>> - minExposure_ = std::max(itExp->second.min().get(), 1);\n>> + minExposure_ = itExp->second.min().get();\n>> maxExposure_ = itExp->second.max().get();\n>> exposure_ = minExposure_;\n>> \n>> - minGain_ = std::max(itGain->second.min().get(), 1);\n>> + minGain_ = itGain->second.min().get();\n>> maxGain_ = itGain->second.max().get();\n>> gain_ = minGain_;\n>> \n>> -- \n>> 2.32.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C182BF415\n\tfor ;\n\tTue, 23 Nov 2021 15:23:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49C5F60228;\n\tTue, 23 Nov 2021 16:23:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5415460121\n\tfor ;\n\tTue, 23 Nov 2021 16:23:45 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3c3b:9149:b:8aa9] (unknown\n\t[IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A9E4993;\n\tTue, 23 Nov 2021 16:23:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XLDdo5uj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637681025;\n\tbh=D+Ik+hW9FRLwleDPWR9x5TTDK49HXQaVpyN1gPjziKY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=XLDdo5uj0TAbAzRapJohubewXjCvErJ+l/UtNiDNez2TRAvbSyzOdjxZT0EzYHTs+\n\trjU+ripZk6sRdRvOyX73SZK1Dug5YDM/6ZRJLsZGZgR5cP5kxA2TVLACDPoJjW1iwn\n\tlnNmKWF45qt2KSWKwY3rbj8wbXHpcTSuBnWCNulQ=","Message-ID":"","Date":"Tue, 23 Nov 2021 16:23:42 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.3.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123150423.125524-4-jeanmichel.hautbois@ideasonboard.com>\n\t<163768093373.3059017.7270085614277271101@Monstersaurus>","From":"Jean-Michel Hautbois ","In-Reply-To":"<163768093373.3059017.7270085614277271101@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the\n\tsensor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21153,"web_url":"https://patchwork.libcamera.org/comment/21153/","msgid":"<163768396667.3059017.14427317085306301785@Monstersaurus>","date":"2021-11-23T16:12:46","subject":"Re: [libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the\n\tsensor limits","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-23 15:23:42)\n> \n> \n> On 23/11/2021 16:22, Kieran Bingham wrote:\n> > Quoting Jean-Michel Hautbois (2021-11-23 15:04:15)\n> >> The driver is responsible of setting the proper limits for its controls.\n> > \n> > s/of/for/\n> > \n> >> For instance, imx219 has an analogue gain of 1.0 when the gain code is\n> >> set to 0. The minimum analogue is forced to be at least 1, which for\n> > \n> > The minimum ... exposure? (Is analogue really correct here?)\n> \n> It is the analogue gain for this imx219 example.\n\nOk, so something like:\n\n\"\"\"\nThe driver is responsible for setting the proper limits for its\ncontrols.\n\nThe IMX219 has an analogue gain of 1.0 when the gain code is set to 0,\ntherefore we can not clamp to a minimum gain code of 1.\n\nRework this for both IPU3 and RkISP1, for both Exposure and Gain\ncontrols.\n\"\"\"\n\n> > Also\n> > \n> > The minimum [exposure] is currently forced to be\n> > ^^^^^^^^^\n> > \n> > That just helps readability.\n> > \n> > With that,\n> > \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> >> imx219 sets it to 1.00329. Rework this for both IPU3 and RkISP1.\n> >>\n> >> Signed-off-by: Jean-Michel Hautbois \n> >> Reviewed-by: Laurent Pinchart \n> >> ---\n> >> src/ipa/ipu3/ipu3.cpp | 4 ++--\n> >> src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n> >> 2 files changed, 4 insertions(+), 4 deletions(-)\n> >>\n> >> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> >> index a8d54a5d..b0c75541 100644\n> >> --- a/src/ipa/ipu3/ipu3.cpp\n> >> +++ b/src/ipa/ipu3/ipu3.cpp\n> >> @@ -444,11 +444,11 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> >> return -EINVAL;\n> >> }\n> >> \n> >> - minExposure_ = std::max(itExp->second.min().get(), 1);\n> >> + minExposure_ = itExp->second.min().get();\n> >> maxExposure_ = itExp->second.max().get();\n> >> exposure_ = minExposure_;\n> >> \n> >> - minGain_ = std::max(itGain->second.min().get(), 1);\n> >> + minGain_ = itGain->second.min().get();\n> >> maxGain_ = itGain->second.max().get();\n> >> gain_ = minGain_;\n> >> \n> >> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> >> index 7ecbf8ae..910ad952 100644\n> >> --- a/src/ipa/rkisp1/rkisp1.cpp\n> >> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> >> @@ -139,11 +139,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> >> \n> >> autoExposure_ = true;\n> >> \n> >> - minExposure_ = std::max(itExp->second.min().get(), 1);\n> >> + minExposure_ = itExp->second.min().get();\n> >> maxExposure_ = itExp->second.max().get();\n> >> exposure_ = minExposure_;\n> >> \n> >> - minGain_ = std::max(itGain->second.min().get(), 1);\n> >> + minGain_ = itGain->second.min().get();\n> >> maxGain_ = itGain->second.max().get();\n> >> gain_ = minGain_;\n> >> \n> >> -- \n> >> 2.32.0\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C319BDB13\n\tfor ;\n\tTue, 23 Nov 2021 16:12:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5747B60228;\n\tTue, 23 Nov 2021 17:12:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EEFA660121\n\tfor ;\n\tTue, 23 Nov 2021 17:12:48 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FF2FA1B;\n\tTue, 23 Nov 2021 17:12:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nTrwo9P5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637683968;\n\tbh=KD2MLc4hxoEDgUE5AULW/lW+PCgAieK/pInZJY2ePZg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=nTrwo9P5z0V84JkjHKsQe8b1Mk5DR+dcdSpLdrm8RbZqJMS6ICPH7LLqGkhacUefb\n\tPnn7vHxS4QAECYe1bG1C0YpkTbGq+lTz64qpXZ4EyILq+REj8ZIiHjfSkxD87VWCs/\n\tdyKfqE7X1gTaev/yWPAjYDiAeTmYAJtBQzziIbms=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211123150423.125524-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123150423.125524-4-jeanmichel.hautbois@ideasonboard.com>\n\t<163768093373.3059017.7270085614277271101@Monstersaurus>\n\t","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 23 Nov 2021 16:12:46 +0000","Message-ID":"<163768396667.3059017.14427317085306301785@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 03/11] ipa: Do not modify the\n\tsensor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]