[{"id":21172,"web_url":"https://patchwork.libcamera.org/comment/21172/","msgid":"","date":"2021-11-24T05:06:24","subject":"Re: [libcamera-devel] [PATCH v4 1/4] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Han-lin,\n\nThank you for the patch.\n\nOn Tue, Nov 23, 2021 at 08:37:48PM +0800, Han-Lin Chen wrote:\n> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor\n> V4L2 controls. The patch extend one more field for lens V4L2 controls\n> for auto focus usage.\n> \n> Signed-off-by: Han-Lin Chen \n> Reviewed-by: Kieran Bingham \n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 16e3462e..cc0d822f 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -24,12 +24,14 @@ struct IPU3Event {\n> \tuint32 bufferId;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n\nI'd like to investigate if we should create internal controls for the\nsensor and lens, that could be combined in a single control list, and\ntranslated to V4L2 controls in the appropriate classes. For now this\nshould be good enough.\n\nReviewed-by: Laurent Pinchart \n\n> };\n> \n> struct IPU3Action {\n> \tIPU3Operations op;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPAConfigInfo {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9825BF415\n\tfor ;\n\tWed, 24 Nov 2021 05:06:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A9E36022F;\n\tWed, 24 Nov 2021 06:06:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9D3F60121\n\tfor ;\n\tWed, 24 Nov 2021 06:06:48 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12C2BD78;\n\tWed, 24 Nov 2021 06:06:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PfOH/mdq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637730408;\n\tbh=g0I5/wxRpeeKxbDSUs0XaWRiXcfL5UwvDxXpNiR9Ezk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PfOH/mdqvwT95j8Sn9x2cxFQDVlWBJwnGjXtVipP7JPrNUB3iiM3eQ7w+VaBZMkjl\n\t7f4BSTgOH6LEmq7IBj8oixQCOwTRh+cFHfnvat1J/hOXq6zKH5j0WAKF9kze/X4ste\n\tOe/HsTZlspCDvVxlZuWULOlOPzQX7/GseGBFMlj4=","Date":"Wed, 24 Nov 2021 07:06:24 +0200","From":"Laurent Pinchart ","To":"Han-Lin Chen ","Message-ID":"","References":"<20211123123751.3194696-1-hanlinchen@chromium.org>\n\t<20211123123751.3194696-2-hanlinchen@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211123123751.3194696-2-hanlinchen@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 1/4] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21179,"web_url":"https://patchwork.libcamera.org/comment/21179/","msgid":"<0248b1e0-26b7-91d1-50cd-5cc310bbe83e@ideasonboard.com>","date":"2021-11-24T06:07:13","subject":"Re: [libcamera-devel] [PATCH v4 1/4] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello Han-Lin\n\nOn 11/23/21 6:07 PM, Han-Lin Chen wrote:\n> IPU3Event and IPU3Action use two fields for both libcamera controls and sensor\n> V4L2 controls. The patch extend one more field for lens V4L2 controls\n> for auto focus usage.\n>\n> Signed-off-by: Han-Lin Chen \n> Reviewed-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 16e3462e..cc0d822f 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -24,12 +24,14 @@ struct IPU3Event {\n> \tuint32 bufferId;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPU3Action {\n> \tIPU3Operations op;\n> \tlibcamera.ControlList controls;\n> \tlibcamera.ControlList sensorControls;\n> +\tlibcamera.ControlList lensControls;\n> };\n> \n> struct IPAConfigInfo {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6FB07BF415\n\tfor ;\n\tWed, 24 Nov 2021 06:07:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD22A6022F;\n\tWed, 24 Nov 2021 07:07:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A735360121\n\tfor ;\n\tWed, 24 Nov 2021 07:07:19 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72E09993;\n\tWed, 24 Nov 2021 07:07:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lj8pjWLR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637734039;\n\tbh=5M047Y3aw0rHG3oHkZEFT6+qD9/9Doi1h7CfLcxcFDM=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=lj8pjWLRhj3SFc+5qWi310H9N86zh29IDlAHiEU418bdqVNwZg0n/9LYEt9w+dryi\n\tzU+opwFBV/PRsXqSG8O2Xqv0gEePsPLyzt9SXv6YbctgmmRDeB/GsnhBoxD75GbgdR\n\tLJRjcRjVKR4MhR7f4UotXQ7o5fFsysRTaySbo824=","To":"Han-Lin Chen ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211123123751.3194696-1-hanlinchen@chromium.org>\n\t<20211123123751.3194696-2-hanlinchen@chromium.org>","From":"Umang Jain ","Message-ID":"<0248b1e0-26b7-91d1-50cd-5cc310bbe83e@ideasonboard.com>","Date":"Wed, 24 Nov 2021 11:37:13 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211123123751.3194696-2-hanlinchen@chromium.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 1/4] ipa: ipu3: Extend ipu3 ipa\n\tinterface for lens controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]