[{"id":21230,"web_url":"https://patchwork.libcamera.org/comment/21230/","msgid":"<163783900284.3059017.1823528575304899618@Monstersaurus>","date":"2021-11-25T11:16:42","subject":"Re: [libcamera-devel] [PATCH 7/7] android: Add CONTROL_MODE_OFF in\n\ttemplate and static metadata","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-11-23 10:40:42)\n> Add CONTROL_MODE_OFF to the available control modes in static metadata,\n> if both AE off and AWB off are available. Also set CONTROL_MODE_OFF in\n> the manual template.\n> \n\nSeems reasonable.\n\n> Signed-off-by: Paul Elder \n> ---\n> src/android/camera_capabilities.cpp | 18 +++++++++++++++++-\n> 1 file changed, 17 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index f7397d27..5d90047b 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -999,7 +999,17 @@ int CameraCapabilities::initializeStaticMetadata()\n> staticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> awbLockAvailable);\n> \n> - char availableControlModes = ANDROID_CONTROL_MODE_AUTO;\n> + /*\n> + * \\todo Get this from some combination of the available AE and AWB\n> + * modes\n\nDoes that mean there are other expected combinations to handle? But I\nguess that's reliant upon the AE/AWB series.\n\nSo\n\nReviewed-by: Kieran Bingham \n\n\n> + */\n> + std::vector availableControlModes = { ANDROID_CONTROL_MODE_AUTO };\n> + if (staticMetadata_->entryContains(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n> + ANDROID_CONTROL_AE_MODE_OFF) &&\n> + staticMetadata_->entryContains(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> + ANDROID_CONTROL_AWB_MODE_OFF)) {\n> + availableControlModes.push_back(ANDROID_CONTROL_MODE_OFF);\n> + }\n> staticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_MODES,\n> availableControlModes);\n> \n> @@ -1467,6 +1477,12 @@ std::unique_ptr CameraCapabilities::requestTemplateManual() cons\n> if (!manualTemplate)\n> return nullptr;\n> \n> + if (staticMetadata_->entryContains(ANDROID_CONTROL_AVAILABLE_MODES,\n> + ANDROID_CONTROL_MODE_OFF)) {\n> + uint8_t mode = ANDROID_CONTROL_MODE_OFF;\n> + manualTemplate->appendEntry(ANDROID_CONTROL_MODE, mode);\n> + }\n> +\n> return manualTemplate;\n> }\n> \n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E44DBF415\n\tfor ;\n\tThu, 25 Nov 2021 11:16:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A19A76036F;\n\tThu, 25 Nov 2021 12:16:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EE0860231\n\tfor ;\n\tThu, 25 Nov 2021 12:16:46 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A77AB90E;\n\tThu, 25 Nov 2021 12:16:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eA0rXuml\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637839005;\n\tbh=QKC+u39G7P5blsczIDcagkp3kfIlQPhrnTkyw0vUK4g=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=eA0rXumlVMP83SpuhFg0IKhMRKG5PigsI2z48kjVxAOc3PEyhocOgM+HQbjFVO59L\n\tyvHu2vYA4J7LZI4+5vLOynqUdE5ce2Az6EP5qJWEXN3fvQrTUYDdbgsev1SQzg65dm\n\tApw5i9zfqy09LNr1/dWb/GaUKElB9CJ61zrY8A5w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211123104042.3100902-8-paul.elder@ideasonboard.com>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-8-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 11:16:42 +0000","Message-ID":"<163783900284.3059017.1823528575304899618@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 7/7] android: Add CONTROL_MODE_OFF in\n\ttemplate and static metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21836,"web_url":"https://patchwork.libcamera.org/comment/21836/","msgid":"<20211220231400.GG2742@pyrite.rasen.tech>","date":"2021-12-20T23:14:00","subject":"Re: [libcamera-devel] [PATCH 7/7] android: Add CONTROL_MODE_OFF in\n\ttemplate and static metadata","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Nov 25, 2021 at 11:16:42AM +0000, Kieran Bingham wrote:\n> Quoting Paul Elder (2021-11-23 10:40:42)\n> > Add CONTROL_MODE_OFF to the available control modes in static metadata,\n> > if both AE off and AWB off are available. Also set CONTROL_MODE_OFF in\n> > the manual template.\n> > \n> \n> Seems reasonable.\n> \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/android/camera_capabilities.cpp | 18 +++++++++++++++++-\n> > 1 file changed, 17 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index f7397d27..5d90047b 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -999,7 +999,17 @@ int CameraCapabilities::initializeStaticMetadata()\n> > staticMetadata_->addEntry(ANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> > awbLockAvailable);\n> > \n> > - char availableControlModes = ANDROID_CONTROL_MODE_AUTO;\n> > + /*\n> > + * \\todo Get this from some combination of the available AE and AWB\n> > + * modes\n> \n> Does that mean there are other expected combinations to handle? But I\n> guess that's reliant upon the AE/AWB series.\n\n\"some combination\" I mean like what we have here is that we assume that\nauto is always supported, and off is the optional one, and we only\nreport CONTROL_MODE off if both are off-able. What do we do if they only\nsupport off? Or if only only supports auto and one only supports off?\nThat's what the todo covers.\n\n> \n> So\n> \n> Reviewed-by: Kieran Bingham \n\n\nThanks,\n\nPaul\n\n> \n> \n> > + */\n> > + std::vector availableControlModes = { ANDROID_CONTROL_MODE_AUTO };\n> > + if (staticMetadata_->entryContains(ANDROID_CONTROL_AE_AVAILABLE_MODES,\n> > + ANDROID_CONTROL_AE_MODE_OFF) &&\n> > + staticMetadata_->entryContains(ANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> > + ANDROID_CONTROL_AWB_MODE_OFF)) {\n> > + availableControlModes.push_back(ANDROID_CONTROL_MODE_OFF);\n> > + }\n> > staticMetadata_->addEntry(ANDROID_CONTROL_AVAILABLE_MODES,\n> > availableControlModes);\n> > \n> > @@ -1467,6 +1477,12 @@ std::unique_ptr CameraCapabilities::requestTemplateManual() cons\n> > if (!manualTemplate)\n> > return nullptr;\n> > \n> > + if (staticMetadata_->entryContains(ANDROID_CONTROL_AVAILABLE_MODES,\n> > + ANDROID_CONTROL_MODE_OFF)) {\n> > + uint8_t mode = ANDROID_CONTROL_MODE_OFF;\n> > + manualTemplate->appendEntry(ANDROID_CONTROL_MODE, mode);\n> > + }\n> > +\n> > return manualTemplate;\n> > }\n> > \n> > -- \n> > 2.27.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F1EFBF415\n\tfor ;\n\tMon, 20 Dec 2021 23:14:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 788B6608E9;\n\tTue, 21 Dec 2021 00:14:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA98560592\n\tfor ;\n\tTue, 21 Dec 2021 00:14:06 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAFEF881;\n\tTue, 21 Dec 2021 00:14:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zm8S/LgW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640042046;\n\tbh=Vm9YF7Tyly6xW8b2nZznwAoj/HSypLzh7tND9rxc5q4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zm8S/LgWj89D6WfXGNtDwDhSvDXy157XJkwsrUphxMTp434xeqSJC2ClM2pFf5GO5\n\tyNRU7XP/cdkVjXQjGgrN9muILc2rnjytBDXv+1SQqYuoQAbtC/9sOFIU60QFmlqXZN\n\tUBwQ1y6ZiMobsnPb+hdo2g2so6ro32o0dG8FIHeM=","Date":"Mon, 20 Dec 2021 17:14:00 -0600","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20211220231400.GG2742@pyrite.rasen.tech>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-8-paul.elder@ideasonboard.com>\n\t<163783900284.3059017.1823528575304899618@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<163783900284.3059017.1823528575304899618@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 7/7] android: Add CONTROL_MODE_OFF in\n\ttemplate and static metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]