[{"id":21229,"web_url":"https://patchwork.libcamera.org/comment/21229/","msgid":"<163783864505.3059017.4066119577437632145@Monstersaurus>","date":"2021-11-25T11:10:45","subject":"Re: [libcamera-devel] [PATCH 6/7] android: Increase result metadata\n\tsize","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-11-23 10:40:41)\n> Increase the initial size of the result metadata, as we will be adding\n> more entries in the near future.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f2e0bdbd..3b588bdb 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1296,7 +1296,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> * Total bytes for JPEG metadata: 82\n> */\n> std::unique_ptr resultMetadata =\n> - std::make_unique(44, 166);\n> + std::make_unique(88, 166);\n\nIs this the current values suggested by the resize?\n\nOr just a straightforwards doubling.?\n\nEither way, It helps efficiency. And can still be fine tuned later.\n\n\nReviewed-by: Kieran Bingham \n\n> if (!resultMetadata->isValid()) {\n> LOG(HAL, Error) << \"Failed to allocate result metadata\";\n> return nullptr;\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6E6EBDB13\n\tfor ;\n\tThu, 25 Nov 2021 11:10:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A394F6036F;\n\tThu, 25 Nov 2021 12:10:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A47660231\n\tfor ;\n\tThu, 25 Nov 2021 12:10:47 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06C2F90E;\n\tThu, 25 Nov 2021 12:10:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ufTE3LqJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637838647;\n\tbh=j6T6/6Dt8u9r5DQ+y7bFAUfFds9UeTjKTzZJrRt/GkQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=ufTE3LqJtWa3QfVhpBzpq9/RSiyxtPbNrFylmQDfdrOPZ4/V6vFm+dCf0PpUfCR34\n\tO47IgR0GXZAfCxKI6Kld0kmIsuMN/vuRFZngsU78wgeg8YEAiqjlusumde1Ek/2oYZ\n\tcy6IhFvQEYDJqCib/2CWPNEMsERchWjmeHt9G7T4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211123104042.3100902-7-paul.elder@ideasonboard.com>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-7-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 11:10:45 +0000","Message-ID":"<163783864505.3059017.4066119577437632145@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 6/7] android: Increase result metadata\n\tsize","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21835,"web_url":"https://patchwork.libcamera.org/comment/21835/","msgid":"<20211220231055.GF2742@pyrite.rasen.tech>","date":"2021-12-20T23:10:55","subject":"Re: [libcamera-devel] [PATCH 6/7] android: Increase result metadata\n\tsize","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Nov 25, 2021 at 11:10:45AM +0000, Kieran Bingham wrote:\n> Quoting Paul Elder (2021-11-23 10:40:41)\n> > Increase the initial size of the result metadata, as we will be adding\n> > more entries in the near future.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/android/camera_device.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index f2e0bdbd..3b588bdb 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -1296,7 +1296,7 @@ CameraDevice::getResultMetadata(const Camera3RequestDescriptor &descriptor) cons\n> > * Total bytes for JPEG metadata: 82\n> > */\n> > std::unique_ptr resultMetadata =\n> > - std::make_unique(44, 166);\n> > + std::make_unique(88, 166);\n> \n> Is this the current values suggested by the resize?\n> \n> Or just a straightforwards doubling.?\n\nIt was arbitrary :p\n\nI was getting a message about the number of entries being increased\nevery time. The size wasn't, so I left that the same.\n\n> \n> Either way, It helps efficiency. And can still be fine tuned later.\n> \n> \n> Reviewed-by: Kieran Bingham \n\n\nThanks,\n\nPaul\n\n> \n> > if (!resultMetadata->isValid()) {\n> > LOG(HAL, Error) << \"Failed to allocate result metadata\";\n> > return nullptr;\n> > -- \n> > 2.27.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02118BF415\n\tfor ;\n\tMon, 20 Dec 2021 23:11:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ABCB608E7;\n\tTue, 21 Dec 2021 00:11:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4055C60592\n\tfor ;\n\tTue, 21 Dec 2021 00:11:01 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60EBA881;\n\tTue, 21 Dec 2021 00:11:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S0q3sT+E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640041861;\n\tbh=jiGFGViMqTku3kRwV32FyFRFVwF42rQQK5v6wMF8nyw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=S0q3sT+ElIfwNF5TDJ2JFNfVSJIdsft6XXCmuWKcWWU0zPnMuvhCxHp/NzdVSzF6x\n\tHo5mVtex1eCQcztKLseUYAkO+dVzWRb9qJJlFjZdgDXpQv2y8vIvJN6M+nlL0Dz66b\n\t4u9kS0kocI6SlSWKfi6XwEzo5NwMmP85d1RFqQv4=","Date":"Mon, 20 Dec 2021 17:10:55 -0600","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20211220231055.GF2742@pyrite.rasen.tech>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-7-paul.elder@ideasonboard.com>\n\t<163783864505.3059017.4066119577437632145@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<163783864505.3059017.4066119577437632145@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 6/7] android: Increase result metadata\n\tsize","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]