[{"id":21227,"web_url":"https://patchwork.libcamera.org/comment/21227/","msgid":"<163783842970.3059017.101719481143264084@Monstersaurus>","date":"2021-11-25T11:07:09","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_capabilities: Fix\n\tthe type of the capability vector","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-11-23 10:40:39)\n> The type of elements of the capability vector that is set in the static\n> metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> Fix this.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/android/camera_capabilities.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 8484c682..875d38da 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -1379,7 +1379,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> \n> /* Check capabilities */\n> capabilities_ = computeCapabilities();\n> - std::vector\n> + /* This *must* uint8_t. */\n\n*must* be uint8_t ... ?\n\nReviewed-by: Kieran Bingham \n\nAssuming camera_metadata_enum_android_request_available_capabilities is\nout of our control, so we can't make it a uint8_t itself...\n\n\n> + std::vector\n> capsVec(capabilities_.begin(), capabilities_.end());\n> staticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n> \n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E32A4BF415\n\tfor ;\n\tThu, 25 Nov 2021 11:07:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8623760376;\n\tThu, 25 Nov 2021 12:07:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32AED60231\n\tfor ;\n\tThu, 25 Nov 2021 12:07:12 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4F0690E;\n\tThu, 25 Nov 2021 12:07:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M7O+9q1O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637838431;\n\tbh=1z77KTv2PiT86A7tLC4cVsvWw4Wy9E5k3Y9yzwZjmys=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=M7O+9q1OjTdycqgijS3pG3Dk58WunSKj5ffglsQMwkhYaSOkzxWzbwhziCMOTapEn\n\tQQG9ejTRcL8RrmMY7dCpun04Bn7iq2O9dOApugALco7ifImh6xI4z+kbKXNf0nLlzV\n\tm18NBPHtTOMYj5cZq7qYn2JrQwDrA3Njxw+aH1aA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211123104042.3100902-5-paul.elder@ideasonboard.com>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-5-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 11:07:09 +0000","Message-ID":"<163783842970.3059017.101719481143264084@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_capabilities: Fix\n\tthe type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21833,"web_url":"https://patchwork.libcamera.org/comment/21833/","msgid":"<20211220225438.GD2742@pyrite.rasen.tech>","date":"2021-12-20T22:54:38","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_capabilities: Fix\n\tthe type of the capability vector","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Thu, Nov 25, 2021 at 11:07:09AM +0000, Kieran Bingham wrote:\n> Quoting Paul Elder (2021-11-23 10:40:39)\n> > The type of elements of the capability vector that is set in the static\n> > metadata must be uint8_t. The enum will not suffice, as it is int32_t.\n> > Fix this.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/android/camera_capabilities.cpp | 3 ++-\n> > 1 file changed, 2 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> > index 8484c682..875d38da 100644\n> > --- a/src/android/camera_capabilities.cpp\n> > +++ b/src/android/camera_capabilities.cpp\n> > @@ -1379,7 +1379,8 @@ int CameraCapabilities::initializeStaticMetadata()\n> > \n> > /* Check capabilities */\n> > capabilities_ = computeCapabilities();\n> > - std::vector\n> > + /* This *must* uint8_t. */\n> \n> *must* be uint8_t ... ?\n\n*must* be uint8_t.\n\nIf you use the enum type it'll be int32_t internally, which makes\nandroid not read the capabilities correctly due to, presumably,\nalignment.\n\n> \n> Reviewed-by: Kieran Bingham \n> \n> Assuming camera_metadata_enum_android_request_available_capabilities is\n> out of our control, so we can't make it a uint8_t itself...\n\nYeah.\n\n\nThanks,\n\nPaul\n\n> \n> \n> > + std::vector\n> > capsVec(capabilities_.begin(), capabilities_.end());\n> > staticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n> > \n> > -- \n> > 2.27.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DF73BF415\n\tfor ;\n\tMon, 20 Dec 2021 22:54:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2C01608E7;\n\tMon, 20 Dec 2021 23:54:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F85460223\n\tfor ;\n\tMon, 20 Dec 2021 23:54:45 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E290B9C;\n\tMon, 20 Dec 2021 23:54:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lkOfZvZX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1640040885;\n\tbh=v1qx1ynNndiE6AzKAN+TZUoKAd1GME/StHTc9ovIjnY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lkOfZvZXOfISHyYVpsu5MlJ5bRR6MEGqdcKCR/3FOPi2tMLt6hjvFK1ZBud59UdkU\n\twhcpAEh/Hq2sdLIMHX5mNAl1S7ob+45e/uLZON/SpI+fA7FKRLwiIM/Wstzu1pwehG\n\tekYhXZy3/EhzCb1Jy203lfqvYcnayOVTJICQjfCk=","Date":"Mon, 20 Dec 2021 16:54:38 -0600","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20211220225438.GD2742@pyrite.rasen.tech>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-5-paul.elder@ideasonboard.com>\n\t<163783842970.3059017.101719481143264084@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<163783842970.3059017.101719481143264084@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_capabilities: Fix\n\tthe type of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]