{"id":14700,"url":"https://patchwork.libcamera.org/api/patches/14700/?format=json","web_url":"https://patchwork.libcamera.org/patch/14700/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211123104042.3100902-5-paul.elder@ideasonboard.com>","date":"2021-11-23T10:40:39","name":"[libcamera-devel,4/7] android: camera_capabilities: Fix the type of the capability vector","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"572bc67a0b733147c2045a0f94aedcf225314a1e","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14700/mbox/","series":[{"id":2742,"url":"https://patchwork.libcamera.org/api/series/2742/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2742","date":"2021-11-23T10:40:35","name":"android: Miscellaneous fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/2742/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14700/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14700/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DCC4C324F\n\tfor ;\n\tTue, 23 Nov 2021 10:41:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 251E26038B;\n\tTue, 23 Nov 2021 11:41:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0029E6033C\n\tfor ;\n\tTue, 23 Nov 2021 11:41:05 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93BF4A1B;\n\tTue, 23 Nov 2021 11:41:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SUOAdKUU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637664065;\n\tbh=ZUkNXUnz2bmlUyd22jZRxTz/qfGZO9eVWitwIwL/U4o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SUOAdKUUr9SbsVDx5lAYziQ6r1hMGTOi81WrdGuY2n4K2sJ0Z97Lb5w332WEFR4cY\n\tzQx80HyxS87NWAZluvFZ/WUxthRiZI5cxjSady8IvOtVUIRHBaioeJqpYqqvTGoOS2\n\tG5kO3QfuGZlVLFyvxY6Xh3PRAjUQWYuMBpJBGppc=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Nov 2021 19:40:39 +0900","Message-Id":"<20211123104042.3100902-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/7] android: camera_capabilities: Fix the\n\ttype of the capability vector","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The type of elements of the capability vector that is set in the static\nmetadata must be uint8_t. The enum will not suffice, as it is int32_t.\nFix this.\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_capabilities.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 8484c682..875d38da 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1379,7 +1379,8 @@ int CameraCapabilities::initializeStaticMetadata()\n \n \t/* Check capabilities */\n \tcapabilities_ = computeCapabilities();\n-\tstd::vector\n+\t/* This *must* uint8_t. */\n+\tstd::vector\n \t\tcapsVec(capabilities_.begin(), capabilities_.end());\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CAPABILITIES, capsVec);\n \n","prefixes":["libcamera-devel","4/7"]}