[{"id":21224,"web_url":"https://patchwork.libcamera.org/comment/21224/","msgid":"<163783816354.3059017.5091419654678442116@Monstersaurus>","date":"2021-11-25T11:02:43","subject":"Re: [libcamera-devel] [PATCH 2/7] android: camera_capabilities: Set\n\tread sensor settings capability","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-11-23 10:40:37)\n> A libcamera camera that supports the manual sensor capability also\n> satisfies all the requirements for the read sensor settings capability.\n> Set it.\n\nOk ;-)\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Paul Elder \n> ---\n> src/android/camera_capabilities.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 8c138df4..8484c682 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -339,8 +339,11 @@ CameraCapabilities::computeCapabilities()\n> \n> capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE);\n> \n> - if (validateManualSensorCapability())\n> + if (validateManualSensorCapability()) {\n> capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n> + /* The libcamera requirements cover this */\n> + capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_READ_SENSOR_SETTINGS);\n> + }\n> \n> if (validateManualPostProcessingCapability())\n> capabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7509BDB13\n\tfor ;\n\tThu, 25 Nov 2021 11:02:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FF776036F;\n\tThu, 25 Nov 2021 12:02:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F09560231\n\tfor ;\n\tThu, 25 Nov 2021 12:02:46 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 075542C5;\n\tThu, 25 Nov 2021 12:02:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dJwnJ5yu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637838166;\n\tbh=ROCf7sTuCPXXCmE0h+3hD+6I7amfNnjDjMdevg9XisM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=dJwnJ5yuvCy6J2dU9bwaUm/OF5MTtX8RxTWD0T3vaLLNzx8cOoyQLitJvD5qM+DhE\n\tQz9VRStKD16ZCLGyf6eudtNcyLotjRYzG6pwskfY4B8bDH3cjoO3z8jYfGbNrME0Sf\n\tRi1j6Na8sVpK8EH/+p4vpFVjePbK6TBTOUoIk/IU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211123104042.3100902-3-paul.elder@ideasonboard.com>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>\n\t<20211123104042.3100902-3-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 25 Nov 2021 11:02:43 +0000","Message-ID":"<163783816354.3059017.5091419654678442116@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/7] android: camera_capabilities: Set\n\tread sensor settings capability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]