{"id":14698,"url":"https://patchwork.libcamera.org/api/patches/14698/?format=json","web_url":"https://patchwork.libcamera.org/patch/14698/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211123104042.3100902-3-paul.elder@ideasonboard.com>","date":"2021-11-23T10:40:37","name":"[libcamera-devel,2/7] android: camera_capabilities: Set read sensor settings capability","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3ba74045d569f0b9c79d31899a054483282f2633","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/14698/mbox/","series":[{"id":2742,"url":"https://patchwork.libcamera.org/api/series/2742/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2742","date":"2021-11-23T10:40:35","name":"android: Miscellaneous fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/2742/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14698/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14698/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A7BBBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Nov 2021 10:41:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11DB6603B5;\n\tTue, 23 Nov 2021 11:41:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D91B6036F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Nov 2021 11:41:02 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D9B6A1B;\n\tTue, 23 Nov 2021 11:41:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hgYwBa/U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637664062;\n\tbh=CJD5x6M4weR20THOR6nxP34C+ecoxO2KD5FLtWtNmRA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hgYwBa/UtggcpY8e9Q5ex46deEGuattITj65YBjvCOUADaWWF7FauEb4jv3a5qTpy\n\twbAhkVE8lhlFhQ7H1aFoU/VW0MZV7NEEzEvIN0r8P1Y0rz5mBSUuQ8AdkptnS5OFBq\n\t+eo0UiMojTLxoIsO77WlsGWM4QYdPTlIunyzDNDU=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Nov 2021 19:40:37 +0900","Message-Id":"<20211123104042.3100902-3-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>","References":"<20211123104042.3100902-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/7] android: camera_capabilities: Set\n\tread sensor settings capability","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"A libcamera camera that supports the manual sensor capability also\nsatisfies all the requirements for the read sensor settings capability.\nSet it.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/android/camera_capabilities.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex 8c138df4..8484c682 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -339,8 +339,11 @@ CameraCapabilities::computeCapabilities()\n \n \tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE);\n \n-\tif (validateManualSensorCapability())\n+\tif (validateManualSensorCapability()) {\n \t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_SENSOR);\n+\t\t/* The libcamera requirements cover this */\n+\t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_READ_SENSOR_SETTINGS);\n+\t}\n \n \tif (validateManualPostProcessingCapability())\n \t\tcapabilities.insert(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_MANUAL_POST_PROCESSING);\n","prefixes":["libcamera-devel","2/7"]}