[{"id":21120,"web_url":"https://patchwork.libcamera.org/comment/21120/","msgid":"","date":"2021-11-23T11:11:22","subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Tue, Nov 23, 2021 at 10:14:47AM +0100, Jean-Michel Hautbois wrote:\n> Now that Algorithm is defined in libipa, we miss documentation for the\n> functions implemented in IPU3::Awb. Fix it.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/algorithms/awb.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> index c7bcb20e..85205333 100644\n> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> @@ -193,6 +193,9 @@ Awb::Awb()\n> \n> Awb::~Awb() = default;\n> \n> +/**\n> + * \\brief Configure the AWB given a configInfo\n\nMissing \\param. Maybe\n\n * \\copydoc libcamera::ipa::Algorithm::configure\n\nwould be better ? Same below.\n\n> + */\n> int Awb::configure(IPAContext &context,\n> \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n> {\n> @@ -373,6 +376,9 @@ void Awb::calculateWBGains(const ipu3_uapi_stats_3a *stats)\n> \t}\n> }\n> \n> +/**\n> + * \\brief Process IPU3 statistics, and run algorithm operations\n> + */\n> void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n> {\n> \tcalculateWBGains(stats);\n> @@ -394,6 +400,9 @@ constexpr uint16_t Awb::threshold(float value)\n> \treturn value * 8191;\n> }\n> \n> +/**\n> + * \\brief Fill the \\a params buffer with IPU3 processing parameters for a frame\n> + */\n> void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n> {\n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B3FBBDB13\n\tfor ;\n\tTue, 23 Nov 2021 11:11:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B434D6022F;\n\tTue, 23 Nov 2021 12:11:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9090260228\n\tfor ;\n\tTue, 23 Nov 2021 12:11:44 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0315AA1B;\n\tTue, 23 Nov 2021 12:11:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"upLhzzYs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637665904;\n\tbh=eqnDrwepAK5Cr4UfRvGRcGWJAwoh6yHI6LWcTya0Iec=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=upLhzzYstqrseJNhns/5hP4V1th8kIEEZKCx7aUq54v+1sarfHzD5lPAvPfrxFBHU\n\tQzlviO8vJ+46aWwfXPy+mtVUqh3VfK7KqhzHorBQ9fI7gDGW9VnXJE/1QZ/eSsHRXB\n\txTLAROBGAlgE081EMLz8zu0okQyHTVmvMCKdEp04=","Date":"Tue, 23 Nov 2021 13:11:22 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123091451.67404-8-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211123091451.67404-8-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21130,"web_url":"https://patchwork.libcamera.org/comment/21130/","msgid":"<9fa3ef09-ff3c-fbb2-85a0-a94fe9c127f5@ideasonboard.com>","date":"2021-11-23T13:38:25","subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/11/2021 12:11, Laurent Pinchart wrote:\n> Hi Jean-Michel,\n> \n> Thank you for the patch.\n> \n> On Tue, Nov 23, 2021 at 10:14:47AM +0100, Jean-Michel Hautbois wrote:\n>> Now that Algorithm is defined in libipa, we miss documentation for the\n>> functions implemented in IPU3::Awb. Fix it.\n>>\n>> Signed-off-by: Jean-Michel Hautbois \n>> ---\n>> src/ipa/ipu3/algorithms/awb.cpp | 9 +++++++++\n>> 1 file changed, 9 insertions(+)\n>>\n>> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n>> index c7bcb20e..85205333 100644\n>> --- a/src/ipa/ipu3/algorithms/awb.cpp\n>> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n>> @@ -193,6 +193,9 @@ Awb::Awb()\n>> \n>> Awb::~Awb() = default;\n>> \n>> +/**\n>> + * \\brief Configure the AWB given a configInfo\n> \n> Missing \\param. Maybe\n> \n> * \\copydoc libcamera::ipa::Algorithm::configure\n> \n> would be better ? Same below.\n\nNice. Should I keep this patch or squash it with the one introducing the \ntemplate class ?\n\n> \n>> + */\n>> int Awb::configure(IPAContext &context,\n>> \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n>> {\n>> @@ -373,6 +376,9 @@ void Awb::calculateWBGains(const ipu3_uapi_stats_3a *stats)\n>> \t}\n>> }\n>> \n>> +/**\n>> + * \\brief Process IPU3 statistics, and run algorithm operations\n>> + */\n>> void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n>> {\n>> \tcalculateWBGains(stats);\n>> @@ -394,6 +400,9 @@ constexpr uint16_t Awb::threshold(float value)\n>> \treturn value * 8191;\n>> }\n>> \n>> +/**\n>> + * \\brief Fill the \\a params buffer with IPU3 processing parameters for a frame\n>> + */\n>> void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n>> {\n>> \t/*\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 967DEBDB13\n\tfor ;\n\tTue, 23 Nov 2021 13:38:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D364160230;\n\tTue, 23 Nov 2021 14:38:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2D560121\n\tfor ;\n\tTue, 23 Nov 2021 14:38:28 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3c3b:9149:b:8aa9] (unknown\n\t[IPv6:2a01:e0a:169:7140:3c3b:9149:b:8aa9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A00FA1B;\n\tTue, 23 Nov 2021 14:38:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wLC6ma8f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637674707;\n\tbh=w3xrsM3WZMDhpA5Lqfxf2dcDLiNxmao0unGdxzXsqDE=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=wLC6ma8fuz35sSQOJo3GjH174cXunLty79RrG3QNyXOlJGXJQ3ZTFfBwKa+7xn+e/\n\tajIcr7Q2Q4sNTZcXVMt3EgPCVpahF1/huG6JvMUg4M+VFr7o3Unysc+dg3Rv1qX4AN\n\tBeDvaVlTYsnNMgH6VZpgLVlUeKXHvhiELZC0DeLg=","Message-ID":"<9fa3ef09-ff3c-fbb2-85a0-a94fe9c127f5@ideasonboard.com>","Date":"Tue, 23 Nov 2021 14:38:25 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.3.1","Content-Language":"en-US","To":"Laurent Pinchart ","References":"<20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123091451.67404-8-jeanmichel.hautbois@ideasonboard.com>\n\t","From":"Jean-Michel Hautbois ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21134,"web_url":"https://patchwork.libcamera.org/comment/21134/","msgid":"","date":"2021-11-23T14:06:09","subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Tue, Nov 23, 2021 at 02:38:25PM +0100, Jean-Michel Hautbois wrote:\n> On 23/11/2021 12:11, Laurent Pinchart wrote:\n> > On Tue, Nov 23, 2021 at 10:14:47AM +0100, Jean-Michel Hautbois wrote:\n> >> Now that Algorithm is defined in libipa, we miss documentation for the\n> >> functions implemented in IPU3::Awb. Fix it.\n> >>\n> >> Signed-off-by: Jean-Michel Hautbois \n> >> ---\n> >> src/ipa/ipu3/algorithms/awb.cpp | 9 +++++++++\n> >> 1 file changed, 9 insertions(+)\n> >>\n> >> diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp\n> >> index c7bcb20e..85205333 100644\n> >> --- a/src/ipa/ipu3/algorithms/awb.cpp\n> >> +++ b/src/ipa/ipu3/algorithms/awb.cpp\n> >> @@ -193,6 +193,9 @@ Awb::Awb()\n> >> \n> >> Awb::~Awb() = default;\n> >> \n> >> +/**\n> >> + * \\brief Configure the AWB given a configInfo\n> > \n> > Missing \\param. Maybe\n> > \n> > * \\copydoc libcamera::ipa::Algorithm::configure\n> > \n> > would be better ? Same below.\n> \n> Nice. Should I keep this patch or squash it with the one introducing the \n> template class ?\n\nI'd squash it, otherwise you'll introduce a build warning during\nbisection.\n\n> >> + */\n> >> int Awb::configure(IPAContext &context,\n> >> \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n> >> {\n> >> @@ -373,6 +376,9 @@ void Awb::calculateWBGains(const ipu3_uapi_stats_3a *stats)\n> >> \t}\n> >> }\n> >> \n> >> +/**\n> >> + * \\brief Process IPU3 statistics, and run algorithm operations\n> >> + */\n> >> void Awb::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n> >> {\n> >> \tcalculateWBGains(stats);\n> >> @@ -394,6 +400,9 @@ constexpr uint16_t Awb::threshold(float value)\n> >> \treturn value * 8191;\n> >> }\n> >> \n> >> +/**\n> >> + * \\brief Fill the \\a params buffer with IPU3 processing parameters for a frame\n> >> + */\n> >> void Awb::prepare(IPAContext &context, ipu3_uapi_params *params)\n> >> {\n> >> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FA14BF415\n\tfor ;\n\tTue, 23 Nov 2021 14:06:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3F0E6036F;\n\tTue, 23 Nov 2021 15:06:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 579CF60121\n\tfor ;\n\tTue, 23 Nov 2021 15:06:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CDB1B92A;\n\tTue, 23 Nov 2021 15:06:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XJeY6p3Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637676392;\n\tbh=Yi3rDnWWvUdhhW2KBLm3TiZPEY0JObVu52CDhhIQUMQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XJeY6p3Y9YL8LxgiRIe/dBW685qRjHmCv5srsLzrJmgmC1wU5f0ZULVirD+I1UJ03\n\tD5DbUAPx42ibmfPnaNysh3Wa5ItW8Dyai+S+CvPpydMgwU7waHvFx/re6A7wCnBGbi\n\tIg8Azf53amJFL7psPCliNC4KUuPrOyRJM6wsrCd4=","Date":"Tue, 23 Nov 2021 16:06:09 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123091451.67404-8-jeanmichel.hautbois@ideasonboard.com>\n\t\n\t<9fa3ef09-ff3c-fbb2-85a0-a94fe9c127f5@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<9fa3ef09-ff3c-fbb2-85a0-a94fe9c127f5@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 07/11] ipa: ipu3: Document AWB\n\tAlgorithm overriden functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]