[{"id":21117,"web_url":"https://patchwork.libcamera.org/comment/21117/","msgid":"","date":"2021-11-23T10:52:54","subject":"Re: [libcamera-devel] [PATCH v2 03/11] ipa: Do not modify the\n\tsensor limits","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Tue, Nov 23, 2021 at 10:14:43AM +0100, Jean-Michel Hautbois wrote:\n> The driver is responsible of setting the proper limits for its controls.\n> For instance, imx219 has an analogue gain of 1.0 when the gain code is\n> set to 0. The minimum analogue is forced to be at least 1, which for\n> imx219 sets it to 1.00329. Rework this for both IPU3 and RkISP1.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 4 ++--\n> src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n> 2 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index a8d54a5d..b0c75541 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -444,11 +444,11 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> \t\treturn -EINVAL;\n> \t}\n> \n> -\tminExposure_ = std::max(itExp->second.min().get(), 1);\n> +\tminExposure_ = itExp->second.min().get();\n> \tmaxExposure_ = itExp->second.max().get();\n> \texposure_ = minExposure_;\n> \n> -\tminGain_ = std::max(itGain->second.min().get(), 1);\n> +\tminGain_ = itGain->second.min().get();\n> \tmaxGain_ = itGain->second.max().get();\n> \tgain_ = minGain_;\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 7ecbf8ae..910ad952 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -139,11 +139,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> \n> \tautoExposure_ = true;\n> \n> -\tminExposure_ = std::max(itExp->second.min().get(), 1);\n> +\tminExposure_ = itExp->second.min().get();\n> \tmaxExposure_ = itExp->second.max().get();\n> \texposure_ = minExposure_;\n> \n> -\tminGain_ = std::max(itGain->second.min().get(), 1);\n> +\tminGain_ = itGain->second.min().get();\n> \tmaxGain_ = itGain->second.max().get();\n> \tgain_ = minGain_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEAFBBF415\n\tfor ;\n\tTue, 23 Nov 2021 10:53:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F302C60394;\n\tTue, 23 Nov 2021 11:53:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4942260376\n\tfor ;\n\tTue, 23 Nov 2021 11:53:17 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0038A1B;\n\tTue, 23 Nov 2021 11:53:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"srelX100\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637664797;\n\tbh=qEAem62oTGyxC36XAX6nikTOMODqH5R0Fy1QXZ8+6A8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=srelX100a+9hU2MHOUbNrqy6dGRdaeda9zxrtjqdE3yQB0cTExMpJr1UiL0ZRZYzw\n\tuAAl2uHoYHjVrWtOPd1gusvExGMstOYnqFjz19MRUl0Wv1NgNsUMZjNN7hGn7FfewL\n\toKsVzn+NgNgVe7heZIvqlSYmcBZ/GB8x7ZW+nnnI=","Date":"Tue, 23 Nov 2021 12:52:54 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20211123091451.67404-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211123091451.67404-4-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211123091451.67404-4-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 03/11] ipa: Do not modify the\n\tsensor limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]