{"id":14682,"url":"https://patchwork.libcamera.org/api/patches/14682/?format=json","web_url":"https://patchwork.libcamera.org/patch/14682/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211122123427.808484-2-naush@raspberrypi.com>","date":"2021-11-22T12:34:26","name":"[libcamera-devel,v2,1/2] pipeline: raspberrypi: Split out device enumeration and camera registration","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"837f98f878e6a3be36eafb6ba4a14f9cd17e2b38","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14682/mbox/","series":[{"id":2740,"url":"https://patchwork.libcamera.org/api/series/2740/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2740","date":"2021-11-22T12:34:25","name":"Raspberry Pi: Multi-camera changes","version":2,"mbox":"https://patchwork.libcamera.org/series/2740/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14682/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14682/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12E89BF415\n\tfor ;\n\tMon, 22 Nov 2021 12:34:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8357D6038A;\n\tMon, 22 Nov 2021 13:34:35 +0100 (CET)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6222E60230\n\tfor ;\n\tMon, 22 Nov 2021 13:34:33 +0100 (CET)","by mail-wr1-x42e.google.com with SMTP id u18so32434854wrg.5\n\tfor ;\n\tMon, 22 Nov 2021 04:34:33 -0800 (PST)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:eb05:dcc9:77a0:2542])\n\tby smtp.gmail.com with ESMTPSA id\n\th7sm8482231wrt.64.2021.11.22.04.34.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 22 Nov 2021 04:34:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"brUUvbf+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ZfpMXzbl3q5XsQMWg0BIa1Ijw3X2uxtGb5zZvcNBtDk=;\n\tb=brUUvbf+Az/3yypkXBp+I0s+gqsT/ciklj/TF4IrRIyFSaeE4MXCSRTLtih44p8d2o\n\tgXUp7UqfIsECBLabLXDSB/5RU/U/KwFzXipIVBq5PvOTi/ZiSxKt2UtHpS/fIkuziPIB\n\typWG0+3LJzGXk/IHal+6a61LvVCCDa3fTzqUFXRpzEAanhKb/kmPuqWvbYLn2bijknIc\n\tSd3TwW/qwIQR4LZXbB5nvSy0LVa66121dJbMju18XS0uidJhd+QLnh6tu+qs9DLmkZwp\n\tvDZ7b8m78QsQZDvnUH7l5h03Lxbxn2tEnfCbOyJH+lieSQhZ1dPvEH5oy92S7rHUlOq7\n\tGeKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ZfpMXzbl3q5XsQMWg0BIa1Ijw3X2uxtGb5zZvcNBtDk=;\n\tb=7hG08NhrdrrH31DMvoq/PIqWDhYTfZ6JRmhbVEAEa/z3faSgUvfT/lLid5k4LKdpD2\n\tTEAWe+XjHH3MUraqDFOW27sc2zEv5tyNHO3yZ+UTblkdsJsnOaulZJACRl09QpYcbyr3\n\tauAiFBiQ8Qt+SnW4FuVWgzQqOWtEENOBl2zKBT1o8kjhjfw9zYpJvn+q0/ZdJ429VCI5\n\tJtZGueG8dfm5Y0MvrPT3tvAXyVpObjsFr3keEToXdOUddsW0S4kE/V9ssSzmcNmotgRf\n\tULqg8JyIJYU3l9ZoWdMBUovz8+7H7M7lnAL2vMWNj05XA36z6kOSKitW6+Qd99zN+ISW\n\tNOvQ==","X-Gm-Message-State":"AOAM532nJBL+6qu3tScE8j/RTlC3HDQ1PXZuZFOI8a7D/brUkE+OGV5D\n\tc1B87ALRUhItGb3r1dBkbrT1VJcjoOUcwNzS","X-Google-Smtp-Source":"ABdhPJwBqXp6hzA6Q7paT5cMA4kW1vIT3eVZdd0JnjI5zCcjGb0PAalWzWIY9+VTOQ7WrjCGPqaU0g==","X-Received":"by 2002:a5d:628f:: with SMTP id\n\tk15mr38232826wru.363.1637584472925; \n\tMon, 22 Nov 2021 04:34:32 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 22 Nov 2021 12:34:26 +0000","Message-Id":"<20211122123427.808484-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20211122123427.808484-1-naush@raspberrypi.com>","References":"<20211122123427.808484-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 1/2] pipeline: raspberrypi: Split out\n\tdevice enumeration and camera registration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Split out PipelineHandlerRPi::match() so that media device enumeration and\nacquisition is separated from camera registration. The former logic remains\nin PipelineHandlerRPi::match(), whereas the latter logic is moved into a new\nPipelineHandlerRPi::registerCameras() member function.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 4f6c699a4379..9aa7e9eef5e7 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -311,6 +311,7 @@ private:\n \t\treturn static_cast(camera->_d());\n \t}\n \n+\tbool registerCameras();\n \tint queueAllBuffers(Camera *camera);\n \tint prepareBuffers(Camera *camera);\n \tvoid freeBuffers(Camera *camera);\n@@ -1010,6 +1011,11 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \tif (!isp_)\n \t\treturn false;\n \n+\treturn registerCameras();\n+}\n+\n+bool PipelineHandlerRPi::registerCameras()\n+{\n \tstd::unique_ptr data = std::make_unique(this);\n \tif (!data->dmaHeap_.isValid())\n \t\treturn false;\n","prefixes":["libcamera-devel","v2","1/2"]}