[{"id":21078,"web_url":"https://patchwork.libcamera.org/comment/21078/","msgid":"","date":"2021-11-21T18:40:18","subject":"Re: [libcamera-devel] [PATCH v2 12/12] libcamera: Add tracing to\n\tmeson summary","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Nov 20, 2021 at 12:13:13PM +0100, Jacopo Mondi wrote:\n> The meson option summary currently does not report if the support\n> for tracing is enabled or not. Add it.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> meson.build | 1 +\n> src/libcamera/meson.build | 3 +++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 7892a9e38c1c..15793e1834ce 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -179,6 +179,7 @@ summary({\n> 'qcam application': qcam_enabled,\n> 'lc-compliance application': lc_compliance_enabled,\n> 'Unit tests': test_enabled,\n> + 'Tracing support': tracing_enabled,\n\nI'd move this after \"Enabled IPA modules\" to group it with the features\nof the libcamera core.\n\nReviewed-by: Laurent Pinchart \n\n> },\n> section : 'Configuration',\n> bool_yn : true)\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 6fb0d5f49b63..6a3f5160fdcd 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -71,8 +71,11 @@ if libgnutls.found()\n> endif\n> \n> if liblttng.found()\n> + tracing_enabled = true\n> config_h.set('HAVE_TRACING', 1)\n> libcamera_sources += files(['tracepoints.cpp'])\n> +else\n> + tracing_enabled = false\n> endif\n> \n> if libudev.found()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97CBABF415\n\tfor ;\n\tSun, 21 Nov 2021 18:40:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E786160378;\n\tSun, 21 Nov 2021 19:40:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95A8560233\n\tfor ;\n\tSun, 21 Nov 2021 19:40:41 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09E879DD;\n\tSun, 21 Nov 2021 19:40:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s0gefnfG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637520041;\n\tbh=6d/fWHMCnZbIzwVHSN1dffu8L5qDzqe4spyWmLNeHb4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=s0gefnfGtuFj4L1dNO5pbbQ8cBzjNPXOE2dWgvhBwmkf/GbFlEg/6OHVymIG95QoN\n\tbYHVw+aMTK+OS3fH4KvhUVmm3S4szBNRq+hRTw6K8gyU9kSvqLZ6ffNHMgGiKixHRr\n\tp4BwwuA1jnTTMCUBTg8Zh7v2PgRVjUvxhqMm6zVo=","Date":"Sun, 21 Nov 2021 20:40:18 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20211120111313.106621-1-jacopo@jmondi.org>\n\t<20211120111313.106621-13-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211120111313.106621-13-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 12/12] libcamera: Add tracing to\n\tmeson summary","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21358,"web_url":"https://patchwork.libcamera.org/comment/21358/","msgid":"<163820533974.3059017.18228598805156808324@Monstersaurus>","date":"2021-11-29T17:02:19","subject":"Re: [libcamera-devel] [PATCH v2 12/12] libcamera: Add tracing to\n\tmeson summary","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-11-21 18:40:18)\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Sat, Nov 20, 2021 at 12:13:13PM +0100, Jacopo Mondi wrote:\n> > The meson option summary currently does not report if the support\n> > for tracing is enabled or not. Add it.\n> > \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > meson.build | 1 +\n> > src/libcamera/meson.build | 3 +++\n> > 2 files changed, 4 insertions(+)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index 7892a9e38c1c..15793e1834ce 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -179,6 +179,7 @@ summary({\n> > 'qcam application': qcam_enabled,\n> > 'lc-compliance application': lc_compliance_enabled,\n> > 'Unit tests': test_enabled,\n> > + 'Tracing support': tracing_enabled,\n> \n> I'd move this after \"Enabled IPA modules\" to group it with the features\n> of the libcamera core.\n> \n> Reviewed-by: Laurent Pinchart \n\nOh - yes please, I love things being added to the summary!\n\n Summarise all the things!\n\nReviewed-by: Kieran Bingham \n\n> \n> > },\n> > section : 'Configuration',\n> > bool_yn : true)\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index 6fb0d5f49b63..6a3f5160fdcd 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -71,8 +71,11 @@ if libgnutls.found()\n> > endif\n> > \n> > if liblttng.found()\n> > + tracing_enabled = true\n> > config_h.set('HAVE_TRACING', 1)\n> > libcamera_sources += files(['tracepoints.cpp'])\n> > +else\n> > + tracing_enabled = false\n> > endif\n> > \n> > if libudev.found()\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80B5FBF415\n\tfor ;\n\tMon, 29 Nov 2021 17:02:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73C18605A4;\n\tMon, 29 Nov 2021 18:02:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 132FD60592\n\tfor ;\n\tMon, 29 Nov 2021 18:02:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 965D72A5;\n\tMon, 29 Nov 2021 18:02:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qjeA4Nf2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638205341;\n\tbh=IrWgx3Jbt0yNgXkWBs9yxRqVl8ZHotNdT2IZYYgP3eY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qjeA4Nf2ZHsRZ29glFwd3smMoZcXa4C5AsWvGw/3P7MBuCyoR9fMom08zeGNogLXp\n\t7/Uwnj1oh0xhsiREhzAwEw9yBAxM0dhZdCPw7qPoWDRtP0kLUfbG4SnDYhvbemBIOQ\n\tLbq+tM6wutLlOlbpKPySI+qWqQN+MczfiT1hlJuU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211120111313.106621-1-jacopo@jmondi.org>\n\t<20211120111313.106621-13-jacopo@jmondi.org>\n\t","From":"Kieran Bingham ","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","Date":"Mon, 29 Nov 2021 17:02:19 +0000","Message-ID":"<163820533974.3059017.18228598805156808324@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 12/12] libcamera: Add tracing to\n\tmeson summary","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]