[{"id":21077,"web_url":"https://patchwork.libcamera.org/comment/21077/","msgid":"","date":"2021-11-21T18:37:37","subject":"Re: [libcamera-devel] [PATCH v2 11/12] test: camera: Fix trivial\n\tspelling mistaken","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sat, Nov 20, 2021 at 12:13:12PM +0100, Jacopo Mondi wrote:\n> The error message should be:\n> \"Failed to associate buffer with request\"\n> \n> Fix that.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\nPlease fast-track this.\n\n> ---\n> test/camera/capture.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 41ae00d7a4c0..f3824f95cbd3 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -109,7 +109,7 @@ protected:\n> \t\t\t}\n> \n> \t\t\tif (request->addBuffer(stream, buffer.get())) {\n> -\t\t\t\tcout << \"Failed to associating buffer with request\" << endl;\n> +\t\t\t\tcout << \"Failed to associate buffer with request\" << endl;\n> \t\t\t\treturn TestFail;\n> \t\t\t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B8B6BDB13\n\tfor ;\n\tSun, 21 Nov 2021 18:38:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31B4960371;\n\tSun, 21 Nov 2021 19:38:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 596C760233\n\tfor ;\n\tSun, 21 Nov 2021 19:38:00 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E27E69DD;\n\tSun, 21 Nov 2021 19:37:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q6vhk39m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637519880;\n\tbh=cgq7i45ESoXy+XKPQuRF+mYOCfaJJXuEfCB2BYbpFpM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q6vhk39mJPGM9gOswZpzKlYxjrm2FNXhy44YWNVu9NOWekRZWiy5Eld5yVmBMnvFn\n\tXNrfBpCdYZ133zxcNHgtslpDIJ0NwS2zSF3rAuhkGuN8F1r4sml2xcdgIH3IPAFH9m\n\ttkFumdd5iIpiUbPo/bl6+bppxkY7DTVygbaoMkqc=","Date":"Sun, 21 Nov 2021 20:37:37 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20211120111313.106621-1-jacopo@jmondi.org>\n\t<20211120111313.106621-12-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211120111313.106621-12-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 11/12] test: camera: Fix trivial\n\tspelling mistaken","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21359,"web_url":"https://patchwork.libcamera.org/comment/21359/","msgid":"<163820541772.3059017.5710188912430290108@Monstersaurus>","date":"2021-11-29T17:03:37","subject":"Re: [libcamera-devel] [PATCH v2 11/12] test: camera: Fix trivial\n\tspelling mistaken","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2021-11-21 18:37:37)\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Sat, Nov 20, 2021 at 12:13:12PM +0100, Jacopo Mondi wrote:\n> > The error message should be:\n> > \"Failed to associate buffer with request\"\n> > \n> > Fix that.\n> > \n> > Signed-off-by: Jacopo Mondi \n> \n> Reviewed-by: Laurent Pinchart \n> \n> Please fast-track this.\n\nTo fast-tracken this, pleasen removen the n from mistaken.\n(in $SUBJECT)\n\nAnd thenen:\n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > test/camera/capture.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> > index 41ae00d7a4c0..f3824f95cbd3 100644\n> > --- a/test/camera/capture.cpp\n> > +++ b/test/camera/capture.cpp\n> > @@ -109,7 +109,7 @@ protected:\n> > }\n> > \n> > if (request->addBuffer(stream, buffer.get())) {\n> > - cout << \"Failed to associating buffer with request\" << endl;\n> > + cout << \"Failed to associate buffer with request\" << endl;\n> > return TestFail;\n> > }\n> > \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCDCFBF415\n\tfor ;\n\tMon, 29 Nov 2021 17:03:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 738EA605A6;\n\tMon, 29 Nov 2021 18:03:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D0E160592\n\tfor ;\n\tMon, 29 Nov 2021 18:03:40 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E26F61265;\n\tMon, 29 Nov 2021 18:03:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sSGpPZUs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638205420;\n\tbh=cL/fJV7Fy4b8hpr/lfyAOrMc7gJGrKZ3PQpSMFS50wY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=sSGpPZUsK5Eg+6qt6kshbqDr7Ndpc9YzF0rnD6jrp5V24s4AZujAJICbsk6cgK3iB\n\tnVBEWj/O3xv3hJHrIZMr5EPvouJkxb4n2Qy9m4phGqwboLlYDOZpu5qH7DXva06nM6\n\tPQNYsag3rBxFIhLlg4YXcL32opcf7Er8C5YIdXNo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20211120111313.106621-1-jacopo@jmondi.org>\n\t<20211120111313.106621-12-jacopo@jmondi.org>\n\t","From":"Kieran Bingham ","To":"Jacopo Mondi ,\n\tLaurent Pinchart ","Date":"Mon, 29 Nov 2021 17:03:37 +0000","Message-ID":"<163820541772.3059017.5710188912430290108@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 11/12] test: camera: Fix trivial\n\tspelling mistaken","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]