{"id":14654,"url":"https://patchwork.libcamera.org/api/patches/14654/?format=json","web_url":"https://patchwork.libcamera.org/patch/14654/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211119111654.68445-6-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-19T11:16:51","name":"[libcamera-devel,v1,5/8] ipa: rkisp1: Report and use sensor controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"69b57ea59fdd565af65e04657aa132fa0172886e","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14654/mbox/","series":[{"id":2735,"url":"https://patchwork.libcamera.org/api/series/2735/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2735","date":"2021-11-19T11:16:46","name":"Introduce AGC for RkISP1","version":1,"mbox":"https://patchwork.libcamera.org/series/2735/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14654/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14654/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39F74BF415\n\tfor ;\n\tFri, 19 Nov 2021 11:17:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEC9C6038C;\n\tFri, 19 Nov 2021 12:17:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C79160378\n\tfor ;\n\tFri, 19 Nov 2021 12:17:00 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:db30:8e54:a96:9838])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2EB71974;\n\tFri, 19 Nov 2021 12:16:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"owIVwMwp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637320620;\n\tbh=1POXK+u/mwoOEr4kIx++HUgXWgdL4MWzdGGudHRC1IM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=owIVwMwpaB4DuWr/FlzrFfPq7BNNgAXVbQ2OY+Krt9auA+Vg0lK7s6tPgKwkDkHjG\n\tGvaAHaLOOEClfIR6/as7dWjWsxuX+6qsm0FbgNqXzoOEb/FBxBtOsat2EeooaNAwEb\n\tsSBJiUdhQalgBcK3ooJBqiVCpgP6c/eNcQwt+YQQ=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 12:16:51 +0100","Message-Id":"<20211119111654.68445-6-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211119111654.68445-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211119111654.68445-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 5/8] ipa: rkisp1: Report and use sensor\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The pipeline handler populates a new sensorControls ControlList, to\nhave the effective exposure and gain values for the current frame. This\nis done when a statistics buffer is received.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n include/libcamera/ipa/rkisp1.mojom | 2 ++\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 ++-\n 3 files changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex a6991d4f..c3a6d8e1 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -21,11 +21,13 @@ struct RkISP1Event {\n \tuint32 frame;\n \tuint32 bufferId;\n \tlibcamera.ControlList controls;\n+\tlibcamera.ControlList sensorControls;\n };\n \n struct RkISP1Action {\n \tRkISP1Operations op;\n \tlibcamera.ControlList controls;\n+\tlibcamera.ControlList sensorControls;\n };\n \n interface IPARkISP1Interface {\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex ddddd52d..d2f4380a 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -313,7 +313,7 @@ void IPARkISP1::setControls(unsigned int frame)\n \tControlList ctrls(ctrls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast(exposure_));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n-\top.controls = ctrls;\n+\top.sensorControls = ctrls;\n \n \tqueueFrameAction.emit(frame, op);\n }\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex db8856d3..6e9f1dad 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -333,7 +333,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame,\n {\n \tswitch (action.op) {\n \tcase ipa::rkisp1::ActionV4L2Set: {\n-\t\tconst ControlList &controls = action.controls;\n+\t\tconst ControlList &controls = action.sensorControls;\n \t\tdelayedCtrls_->push(controls);\n \t\tbreak;\n \t}\n@@ -1125,6 +1125,7 @@ void PipelineHandlerRkISP1::statReady(FrameBuffer *buffer)\n \tev.op = ipa::rkisp1::EventSignalStatBuffer;\n \tev.frame = info->frame;\n \tev.bufferId = info->statBuffer->cookie();\n+\tev.sensorControls = data->delayedCtrls_->get(buffer->metadata().sequence);\n \tdata->ipa_->processEvent(ev);\n }\n \n","prefixes":["libcamera-devel","v1","5/8"]}