[{"id":21038,"web_url":"https://patchwork.libcamera.org/comment/21038/","msgid":"","date":"2021-11-19T12:50:02","subject":"Re: [libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Remove\n\tunused member variables","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Nov 19, 2021 at 11:09:55AM +0000, Naushir Patuck wrote:\n> Remove unused member variables from class PipelineHandlerRPi.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +----\n> 1 file changed, 1 insertion(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 8ed2ebcaafe7..d47306bdfec9 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -317,9 +317,6 @@ private:\n> \tint prepareBuffers(Camera *camera);\n> \tvoid freeBuffers(Camera *camera);\n> \tvoid mapBuffers(Camera *camera, const RPi::BufferMap &buffers, unsigned int mask);\n> -\n> -\tMediaDevice *unicam_;\n> -\tMediaDevice *isp_;\n\nI'd squash this with patch 2/3, as that's where you remove usage of\nthose two member variables.\n\n> };\n> \n> RPiCameraConfiguration::RPiCameraConfiguration(const RPiCameraData *data)\n> @@ -510,7 +507,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> }\n> \n> PipelineHandlerRPi::PipelineHandlerRPi(CameraManager *manager)\n> -\t: PipelineHandler(manager), unicam_(nullptr), isp_(nullptr)\n> +\t: PipelineHandler(manager)\n> {\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88A9ABF415\n\tfor ;\n\tFri, 19 Nov 2021 12:50:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA43860371;\n\tFri, 19 Nov 2021 13:50:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB634600B5\n\tfor ;\n\tFri, 19 Nov 2021 13:50:25 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AEF51959;\n\tFri, 19 Nov 2021 13:50:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lA2aTjEU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637326225;\n\tbh=AXWj+UHBx6iiVooM5kgAkL1sOf5bZmupL6uOdfF1VgU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lA2aTjEUnDLj2kBExZuLqSg60dA2iT6nztzKjeGrJA1YRr9okn/l4rNkqKabTLU0w\n\tqpm1Cfi9SkrRdanP1wdVadxz1KfB06cyEBla+rogJZlqEab4RsfZvbiJmsv+m94DHV\n\tH9jO7Yozpz1KjUQIA3laHVSqLlFucezWuNXU8/T0=","Date":"Fri, 19 Nov 2021 14:50:02 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20211119110955.3137585-1-naush@raspberrypi.com>\n\t<20211119110955.3137585-3-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211119110955.3137585-3-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Remove\n\tunused member variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21063,"web_url":"https://patchwork.libcamera.org/comment/21063/","msgid":"","date":"2021-11-19T16:46:22","subject":"Re: [libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Remove\n\tunused member variables","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for your feedback.\n\nOn Fri, 19 Nov 2021 at 12:50, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Fri, Nov 19, 2021 at 11:09:55AM +0000, Naushir Patuck wrote:\n> > Remove unused member variables from class PipelineHandlerRPi.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +----\n> > 1 file changed, 1 insertion(+), 4 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index 8ed2ebcaafe7..d47306bdfec9 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -317,9 +317,6 @@ private:\n> > int prepareBuffers(Camera *camera);\n> > void freeBuffers(Camera *camera);\n> > void mapBuffers(Camera *camera, const RPi::BufferMap &buffers,\n> unsigned int mask);\n> > -\n> > - MediaDevice *unicam_;\n> > - MediaDevice *isp_;\n>\n> I'd squash this with patch 2/3, as that's where you remove usage of\n> those two member variables.\n>\n\nAck, I'll fix this in the next version.\n\nNaush\n\n\n\n> > };\n> >\n> > RPiCameraConfiguration::RPiCameraConfiguration(const RPiCameraData\n> *data)\n> > @@ -510,7 +507,7 @@ CameraConfiguration::Status\n> RPiCameraConfiguration::validate()\n> > }\n> >\n> > PipelineHandlerRPi::PipelineHandlerRPi(CameraManager *manager)\n> > - : PipelineHandler(manager), unicam_(nullptr), isp_(nullptr)\n> > + : PipelineHandler(manager)\n> > {\n> > }\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FB1EBDB13\n\tfor ;\n\tFri, 19 Nov 2021 16:46:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1566760371;\n\tFri, 19 Nov 2021 17:46:40 +0100 (CET)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05E8E600B5\n\tfor ;\n\tFri, 19 Nov 2021 17:46:39 +0100 (CET)","by mail-lf1-x12b.google.com with SMTP id z34so46101666lfu.8\n\tfor ;\n\tFri, 19 Nov 2021 08:46:38 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"iPt421a3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=YEtI3V01HvEDMbV0SoR2ADy/uNXu7qN9uAYUkRvqGBs=;\n\tb=iPt421a3QyLoZH2nGZdY+2oRCLNth0Esr6drue1F839vKTs4zly2PLDr+sF+4ekjS6\n\tSaHfVmNan9cO20+ip+zIX0XzSBW6RpqPFOLN89fIxJSCjt4y7HCRtwRSk3i6DmYc/qzc\n\tPpILetH7cZKN5pbg+5qTkzA8UuQgIYCu+FZlGgMNtMIzxBsdKBD5z8SVRt+S454sliby\n\tn/JpbycPV44FYOcwF8yCAfHW6UDmLcBFRB75dDHaHvVK6V+H+9KFUZwI2OYAwPMKG1E2\n\tWA4NZvceHCpncKV6RC4gCc4BFtUajsiXeU9jTPWtRzrUbDaoMNUT1KPzek6gnq7l2Quy\n\t4GsQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=YEtI3V01HvEDMbV0SoR2ADy/uNXu7qN9uAYUkRvqGBs=;\n\tb=pNUjArcM0M7bi/FNnos+l6RZFra2xl3+docayJPC7f80ePa1Arr3UeNOwZVZTgIIt6\n\tQC4vt4qmwViPdFO8Pf/sF+i660ayZhR7TZIRmrGWW3T4+eWg60iqzun9H8oGg18E7q6B\n\tdfMM7x7KHU4vLkloHaOEfUkkznbUn+ZGFOtwtbNCek48gi2RHh49jg1yBBHdqfK0WZD9\n\t1aDbwD8ci9TrKnOKNomJg6XHTE/KY3dkEOousw5Pv7VnfSDg7wF1ClDPMdijJtEHQYJb\n\ttTUv4CrjYAcmgeO7dISdpqoWgV12SLyB3cD6n1EYCdKalFRlUHs+MNNhgNntJGGwcr5Z\n\tsnNw==","X-Gm-Message-State":"AOAM533Yq0X1CwQ6XsGlIyoESrtS1GdDXnlwtZUM5DPTkauRFMT4vwPu\n\tgRB/LaIxEmoueNk/Q9wP35xDCtBu92IZPwgP4hgZ/8F+TqaYfw==","X-Google-Smtp-Source":"ABdhPJwl7cTPbl3VtNyzEp950xM7oboHPNQAKdaF/qFOTxaecnv2tb5PoLpnBSp0FJDxZKyK5DTLX2d3hLAzVvhsg9o=","X-Received":"by 2002:a05:6512:3763:: with SMTP id\n\tz3mr33355011lft.315.1637340398358; \n\tFri, 19 Nov 2021 08:46:38 -0800 (PST)","MIME-Version":"1.0","References":"<20211119110955.3137585-1-naush@raspberrypi.com>\n\t<20211119110955.3137585-3-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Fri, 19 Nov 2021 16:46:22 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000d22ac605d127043b\"","Subject":"Re: [libcamera-devel] [PATCH 3/3] pipeline: raspberrypi: Remove\n\tunused member variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]