[{"id":21039,"web_url":"https://patchwork.libcamera.org/comment/21039/","msgid":"","date":"2021-11-19T12:51:06","subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Split out\n\tdevice enumeration and camera registration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Nov 19, 2021 at 11:09:53AM +0000, Naushir Patuck wrote:\n> Split out PipelineHandlerRPi::match() so that media device enumeration and\n> acquisition is separated from camera registration. The former logic remains\n> in PipelineHandlerRPi::match(), whereas the latter logic is moved into a new\n> PipelineHandlerRPi::registerCameras() member function.\n> \n> Signed-off-by: Naushir Patuck \n\nLooks simple enough. Assuming that it helps the rest of the series,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 4f6c699a4379..9aa7e9eef5e7 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -311,6 +311,7 @@ private:\n> \t\treturn static_cast(camera->_d());\n> \t}\n> \n> +\tbool registerCameras();\n> \tint queueAllBuffers(Camera *camera);\n> \tint prepareBuffers(Camera *camera);\n> \tvoid freeBuffers(Camera *camera);\n> @@ -1010,6 +1011,11 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n> \tif (!isp_)\n> \t\treturn false;\n> \n> +\treturn registerCameras();\n> +}\n> +\n> +bool PipelineHandlerRPi::registerCameras()\n> +{\n> \tstd::unique_ptr data = std::make_unique(this);\n> \tif (!data->dmaHeap_.isValid())\n> \t\treturn false;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 058F3BF415\n\tfor ;\n\tFri, 19 Nov 2021 12:51:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A82C260376;\n\tFri, 19 Nov 2021 13:51:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50584600B5\n\tfor ;\n\tFri, 19 Nov 2021 13:51:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8CAF340;\n\tFri, 19 Nov 2021 13:51:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CQbteVFB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637326289;\n\tbh=+M3dgODQmo1qXIF/N/8qFggNwJLq2Cy8BBn4CyAF36M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CQbteVFBa92TshjDypURrCJNyBWH/QIl558yzRFBsyJ8ubX37m9t3VcZttMElnTNK\n\tZ5E2DxKTtRuX/3dM/Cmrj7f/DuuGqevKfLyxO0wQMFmkpGbsw5docB6QoUpaI5FhAl\n\twOdGqDIcudNwGCnqiBn8leGMlrY8igrmQtB6ykqg=","Date":"Fri, 19 Nov 2021 14:51:06 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20211119110955.3137585-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20211119110955.3137585-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] pipeline: raspberrypi: Split out\n\tdevice enumeration and camera registration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]