{"id":14645,"url":"https://patchwork.libcamera.org/api/patches/14645/?format=json","web_url":"https://patchwork.libcamera.org/patch/14645/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211119102559.56522-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-19T10:25:59","name":"[libcamera-devel,2/2] libipa: Correct IMX219 in CameraSensorHelper","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"be0b6b6764d00d6f9ac469be8571fdb623cc58c3","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14645/mbox/","series":[{"id":2733,"url":"https://patchwork.libcamera.org/api/series/2733/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2733","date":"2021-11-19T10:25:57","name":"libipa: Fix doc and imx219","version":1,"mbox":"https://patchwork.libcamera.org/series/2733/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14645/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14645/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81277C324F\n\tfor ;\n\tFri, 19 Nov 2021 10:26:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEB1160378;\n\tFri, 19 Nov 2021 11:26:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5BC796036F\n\tfor ;\n\tFri, 19 Nov 2021 11:26:10 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:db30:8e54:a96:9838])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18F411AE6;\n\tFri, 19 Nov 2021 11:26:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NiEQn8Nu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637317570;\n\tbh=V0WsY6iM3tw7RlE1W95bNVv/cl9cGY0dd60oxVDed/o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NiEQn8NuCpF9zzmqBCBk3wjiveqPVK2JzKzP3a1ur5rRjlVZwYFpEG7+6hHw1oHdP\n\tbAL3uSFmOBLnfwvS3MpIkW10dFuWhTIMwPVrCMctAS4LBwk33k0w+5f7DasHgBIomK\n\tI8xGgXVR4m3nw8ARTl7QHzMwecFxiO687JYfp7/4=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 11:25:59 +0100","Message-Id":"<20211119102559.56522-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211119102559.56522-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211119102559.56522-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] libipa: Correct IMX219 in\n\tCameraSensorHelper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The equation is badly reported in the CameraSensorHelper, as m1 and c0\nare inverted. Correct it to have a proper gain calculation.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 67cf6913..5e22f9c3 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -292,7 +292,7 @@ class CameraSensorHelperImx219 : public CameraSensorHelper\n public:\n \tCameraSensorHelperImx219()\n \t{\n-\t\tanalogueGainConstants_ = { AnalogueGainLinear, 0, -1, 256, 256 };\n+\t\tanalogueGainConstants_ = { AnalogueGainLinear, 0, 256, -1, 256 };\n \t}\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n","prefixes":["libcamera-devel","2/2"]}