[{"id":21020,"web_url":"https://patchwork.libcamera.org/comment/21020/","msgid":"<163731953223.1089182.15382951431183442553@Monstersaurus>","date":"2021-11-19T10:58:52","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Fix IPAContext\n\tdocumentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-19 10:22:19)\n> The shutter speed limits and analogue gains limits are in the agc\n> structure in IPASessionConfiguration. They are badly mentionned as\n\n/mentionned/mentioned/\n\n> beeing part of the grid structure, fix it.\n\n/beeing/being/\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipa_context.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 99caf9ad..86794ac1 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -76,13 +76,13 @@ namespace libcamera::ipa::ipu3 {\n> * \\var IPASessionConfiguration::agc.minShutterSpeed\n> * \\brief Minimum shutter speed supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid.maxShutterSpeed\n> + * \\var IPASessionConfiguration::agc.maxShutterSpeed\n> * \\brief Maximum shutter speed supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid.minAnalogueGain\n> + * \\var IPASessionConfiguration::agc.minAnalogueGain\n> * \\brief Minimum analogue gain supported with the configured sensor\n> *\n> - * \\var IPASessionConfiguration::grid.maxAnalogueGain\n> + * \\var IPASessionConfiguration::agc.maxAnalogueGain\n> * \\brief Maximum analogue gain supported with the configured sensor\n> */\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2765EBDB13\n\tfor ;\n\tFri, 19 Nov 2021 10:58:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46CDC60371;\n\tFri, 19 Nov 2021 11:58:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E08336022F\n\tfor ;\n\tFri, 19 Nov 2021 11:58:54 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 706311974;\n\tFri, 19 Nov 2021 11:58:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lz4kzu3x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637319534;\n\tbh=VsRLGqaMfKHV8WgbAFT7dTxvlW29fSpLzmhfebTtCTk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=lz4kzu3xoEZI2WSqFvMeTmrq8CByDkM0SE79fJSI4j37C0zAk3m67Hzj53ACd0jZO\n\t+5HO6pOzFyYGFx88XzsW8Bfbhq2B+Q7Hu2PwkaQZ6+lBZ8+sUZgAf7+G4O2lwTRqAM\n\trLUOwgHjxHHbbsGlW4hKNC1Vp3prTrcLpeN8CqHc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211119102219.55319-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211119102219.55319-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 10:58:52 +0000","Message-ID":"<163731953223.1089182.15382951431183442553@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Fix IPAContext\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":21035,"web_url":"https://patchwork.libcamera.org/comment/21035/","msgid":"","date":"2021-11-19T12:29:09","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Fix IPAContext\n\tdocumentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Nov 19, 2021 at 10:58:52AM +0000, Kieran Bingham wrote:\n> Quoting Jean-Michel Hautbois (2021-11-19 10:22:19)\n> > The shutter speed limits and analogue gains limits are in the agc\n> > structure in IPASessionConfiguration. They are badly mentionned as\n> \n> /mentionned/mentioned/\n> \n> > beeing part of the grid structure, fix it.\n> \n> /beeing/being/\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > \n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > src/ipa/ipu3/ipa_context.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> > index 99caf9ad..86794ac1 100644\n> > --- a/src/ipa/ipu3/ipa_context.cpp\n> > +++ b/src/ipa/ipu3/ipa_context.cpp\n> > @@ -76,13 +76,13 @@ namespace libcamera::ipa::ipu3 {\n> > * \\var IPASessionConfiguration::agc.minShutterSpeed\n> > * \\brief Minimum shutter speed supported with the configured sensor\n> > *\n> > - * \\var IPASessionConfiguration::grid.maxShutterSpeed\n> > + * \\var IPASessionConfiguration::agc.maxShutterSpeed\n> > * \\brief Maximum shutter speed supported with the configured sensor\n> > *\n> > - * \\var IPASessionConfiguration::grid.minAnalogueGain\n> > + * \\var IPASessionConfiguration::agc.minAnalogueGain\n> > * \\brief Minimum analogue gain supported with the configured sensor\n> > *\n> > - * \\var IPASessionConfiguration::grid.maxAnalogueGain\n> > + * \\var IPASessionConfiguration::agc.maxAnalogueGain\n> > * \\brief Maximum analogue gain supported with the configured sensor\n> > */\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFCD3BDB13\n\tfor ;\n\tFri, 19 Nov 2021 12:29:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 146C960376;\n\tFri, 19 Nov 2021 13:29:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EA0F60233\n\tfor ;\n\tFri, 19 Nov 2021 13:29:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88CB51959;\n\tFri, 19 Nov 2021 13:29:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GefRo8yZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637324971;\n\tbh=4ev4uiEi6+ke7b7fUUnjxYtItAVacm2waxNVG9kCcCc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GefRo8yZ+PhTMWOJcyOWop34Ot2/zR18/hoYHIAgcZhu71WQWFdV1GM3j5g/Y1wQ2\n\teuQTKlA08EoLA4MIAbwjx9v+ic56I1TrV3YS2wRA0U+p7BVrx1hevC3EhFS0mwDO+A\n\tGFcx8dvqvLCGyzPQW/AGuD2vqWjlgF3aH9Iu2B/M=","Date":"Fri, 19 Nov 2021 14:29:09 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20211119102219.55319-1-jeanmichel.hautbois@ideasonboard.com>\n\t<163731953223.1089182.15382951431183442553@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<163731953223.1089182.15382951431183442553@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Fix IPAContext\n\tdocumentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]