[{"id":20997,"web_url":"https://patchwork.libcamera.org/comment/20997/","msgid":"<163722976667.420308.14595290782036936369@Monstersaurus>","date":"2021-11-18T10:02:46","subject":"Re: [libcamera-devel] [PATCH] android: capabilities: Add exposure\n\ttime keys only if available","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder (2021-11-18 09:52:40)\n> The exposure time range static metadata key and the exposure time\n> request and result keys are not required for non-FULL hardware levels.\n> Since we already have checks for them in the capability detector, only\n> add them if the libcamera camera supports it.\n> \n> Signed-off-by: Paul Elder \n\nLGTM,\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_capabilities.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 6e46f163..105d5b4f 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -812,7 +812,6 @@ int CameraCapabilities::initializeStaticMetadata()\n> ANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> ANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> ANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> - ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n> ANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> ANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> @@ -890,7 +889,6 @@ int CameraCapabilities::initializeStaticMetadata()\n> ANDROID_NOISE_REDUCTION_MODE,\n> ANDROID_REQUEST_PIPELINE_DEPTH,\n> ANDROID_SCALER_CROP_REGION,\n> - ANDROID_SENSOR_EXPOSURE_TIME,\n> ANDROID_SENSOR_FRAME_DURATION,\n> ANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> ANDROID_SENSOR_TEST_PATTERN_MODE,\n> @@ -1106,6 +1104,10 @@ int CameraCapabilities::initializeStaticMetadata()\n> \n> staticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> exposureTimeRange, 2);\n> +\n> + availableCharacteristicsKeys_.insert(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE);\n> + availableRequestKeys_.insert(ANDROID_SENSOR_EXPOSURE_TIME);\n> + availableResultKeys_.insert(ANDROID_SENSOR_EXPOSURE_TIME);\n> }\n> \n> staticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, orientation_);\n> -- \n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55C92BF415\n\tfor ;\n\tThu, 18 Nov 2021 10:02:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76A106033C;\n\tThu, 18 Nov 2021 11:02:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1614460230\n\tfor ;\n\tThu, 18 Nov 2021 11:02:49 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B26EE3E5;\n\tThu, 18 Nov 2021 11:02:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qo6BoUJG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637229768;\n\tbh=9u9R6degTHA6ACfSAk5nN6c8QMpDyTaMOqnouFrHCWo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=qo6BoUJGQTQRb7CGOIa+/KKMf+F9LDVUK4TfkVUc/rCiWMPK7f3Mcim/sDq54yDMt\n\tNoycI6vMH8zgcxsEsZn9YY1GVvs5/P25F6Ua8GwC+o3vEZIEeqO3K19QNRQzvlBsst\n\t711NzIJYaUPe9LDa2J8HQbuDVuM0imfCs4Zc/MSc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211118095240.358827-1-paul.elder@ideasonboard.com>","References":"<20211118095240.358827-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 18 Nov 2021 10:02:46 +0000","Message-ID":"<163722976667.420308.14595290782036936369@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] android: capabilities: Add exposure\n\ttime keys only if available","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20998,"web_url":"https://patchwork.libcamera.org/comment/20998/","msgid":"<3ace0496-a7b0-a375-b96d-3b9648bc9053@ideasonboard.com>","date":"2021-11-18T11:00:56","subject":"Re: [libcamera-devel] [PATCH] android: capabilities: Add exposure\n\ttime keys only if available","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn 11/18/21 3:22 PM, Paul Elder wrote:\n> The exposure time range static metadata key and the exposure time\n> request and result keys are not required for non-FULL hardware levels.\n> Since we already have checks for them in the capability detector, only\n> add them if the libcamera camera supports it.\n>\n> Signed-off-by: Paul Elder \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/android/camera_capabilities.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\n> index 6e46f163..105d5b4f 100644\n> --- a/src/android/camera_capabilities.cpp\n> +++ b/src/android/camera_capabilities.cpp\n> @@ -812,7 +812,6 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> \t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> \t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> -\t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> \t\tANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n> \t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> \t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> @@ -890,7 +889,6 @@ int CameraCapabilities::initializeStaticMetadata()\n> \t\tANDROID_NOISE_REDUCTION_MODE,\n> \t\tANDROID_REQUEST_PIPELINE_DEPTH,\n> \t\tANDROID_SCALER_CROP_REGION,\n> -\t\tANDROID_SENSOR_EXPOSURE_TIME,\n> \t\tANDROID_SENSOR_FRAME_DURATION,\n> \t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> \t\tANDROID_SENSOR_TEST_PATTERN_MODE,\n> @@ -1106,6 +1104,10 @@ int CameraCapabilities::initializeStaticMetadata()\n> \n> \t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> \t\t\t\t\t exposureTimeRange, 2);\n> +\n> +\t\tavailableCharacteristicsKeys_.insert(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE);\n> +\t\tavailableRequestKeys_.insert(ANDROID_SENSOR_EXPOSURE_TIME);\n> +\t\tavailableResultKeys_.insert(ANDROID_SENSOR_EXPOSURE_TIME);\n> \t}\n> \n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, orientation_);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6310BDB1C\n\tfor ;\n\tThu, 18 Nov 2021 11:01:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78EC360371;\n\tThu, 18 Nov 2021 12:01:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E0E860231\n\tfor ;\n\tThu, 18 Nov 2021 12:01:03 +0100 (CET)","from [IPv6:2405:205:c96a:2ef8:a2ca:ed56:6a53:9e38] (unknown\n\t[IPv6:2405:205:c96a:2ef8:a2ca:ed56:6a53:9e38])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D43A3E5;\n\tThu, 18 Nov 2021 12:01:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EGNSATux\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637233263;\n\tbh=jvM84Sq9KcEAqouCDtoJT3QIbh7nqebeP8RP7bD6Elc=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=EGNSATuxxbWbRzRs0bBALcXlidekFrwvUA2aucIfV9PgeJ2uavqmiGndVV/Zlzwv/\n\tN4hvJXqBFV4818tPzaX4K9Qke45vikTh+ogutX2IEzIxhXRGhXmBS3//CESglnws9d\n\tTnxN8j6eVs7Zvj5AjCxaZsWMca7FyfS+YwY370K4=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211118095240.358827-1-paul.elder@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<3ace0496-a7b0-a375-b96d-3b9648bc9053@ideasonboard.com>","Date":"Thu, 18 Nov 2021 16:30:56 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211118095240.358827-1-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: capabilities: Add exposure\n\ttime keys only if available","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]