{"id":14589,"url":"https://patchwork.libcamera.org/api/patches/14589/?format=json","web_url":"https://patchwork.libcamera.org/patch/14589/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211112100305.2217099-4-naush@raspberrypi.com>","date":"2021-11-12T10:03:05","name":"[libcamera-devel,v2,3/3] pipeline: raspberrypi: Increase the V4L2BufferCache slot allocations","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6fecd03e6e0a4474f9254a6988e243ff7c82ce84","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14589/mbox/","series":[{"id":2716,"url":"https://patchwork.libcamera.org/api/series/2716/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2716","date":"2021-11-12T10:03:02","name":"raspberrypi: Rework the internal buffer allocation scheme","version":2,"mbox":"https://patchwork.libcamera.org/series/2716/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14589/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14589/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE636BF415\n\tfor ;\n\tFri, 12 Nov 2021 10:03:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E2CE60369;\n\tFri, 12 Nov 2021 11:03:55 +0100 (CET)","from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F6CB60234\n\tfor ;\n\tFri, 12 Nov 2021 11:03:54 +0100 (CET)","by mail-wr1-x42a.google.com with SMTP id n29so14478132wra.11\n\tfor ;\n\tFri, 12 Nov 2021 02:03:54 -0800 (PST)","from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\to9sm5283155wrs.4.2021.11.12.02.03.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Nov 2021 02:03:53 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"AMMhRK7p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=3DsHUzto1xICrV+8oKQbV2fo+5EHRpl8Rwp/bFHynbY=;\n\tb=AMMhRK7p/PTuQPBjoY7S0Qal3ebR8jiz7ZS1zJcskOKTydC4aiEA6kH//ZtemWm+4N\n\tPvvYuy3izapBO2i0HQL1UXrmPtDad78q6PCgm8ldHdgCgVJAQuaEIHmM8utEM6SNE6pc\n\t3UXijfrBWIENNNZC3RKbz8oS+7rDMZRX1/20DKTCKB23cQzp+l97apbsrJ0x3DYKHBZb\n\tsxdXSRsncUs1Tm0rp/13oR4W3RWc8IcedJR+IbUFBWoHjujgvQ1gPmmEdKblfxMdBF3/\n\t6GFpxrkmaxrFqL5DxbRkEJ4uySubDzgF9F1HQ8jnoITJxGV/4AMqrWhym5NVaEfsLql1\n\t5Jxg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=3DsHUzto1xICrV+8oKQbV2fo+5EHRpl8Rwp/bFHynbY=;\n\tb=dsXyEwprUym7wf8pYsRLgzlnS5iqy5eKgroKuPGayXeu7XQO5CScZiz5R61MLLthlU\n\t6znw7pwSsBpPbqg8TU+cd0KB8wcF2iXJwnqsgLdBt7HdZXgKmiNPMSHmQpfVWYL7yfqJ\n\thTKfba2JHMtGN7VFyx3iY8WUylBq+yY81wcqVwwXvF58m0rQhw29iNWz8a85oz+NFR38\n\trEQ8JRTajSrxeZh+7lddJhbUSrQAa15OURaZMIQSjc2GuHzsiH+x8WKe6t7BUXOXbJiv\n\t32xmsLNlqbxaR1EyHBR7lVpATHBgP5LQgQR7YK8DJM1n/aFL09SjF3LaSzAq7voHazT+\n\t62Ng==","X-Gm-Message-State":"AOAM533fIelrMmvEG5xLxOmZDc50wk2t48fnOqmpeQP17oGxIwo7zat5\n\tkPFIhU8fZefU+SoSPOw9xWoR6/pe4DD3wPQh","X-Google-Smtp-Source":"ABdhPJzgmvxamQD3/yqa+Imafnc1ApHcdE10N3WlWK9e5TB7KEkJIxg5Lf868TOEAeizT3sDDsTanQ==","X-Received":"by 2002:adf:d1e2:: with SMTP id\n\tg2mr16599685wrd.179.1636711433839; \n\tFri, 12 Nov 2021 02:03:53 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Nov 2021 10:03:05 +0000","Message-Id":"<20211112100305.2217099-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20211112100305.2217099-1-naush@raspberrypi.com>","References":"<20211112100305.2217099-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/3] pipeline: raspberrypi: Increase\n\tthe V4L2BufferCache slot allocations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Roman Stratiienko ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If a stream is marked as external, double the number of V4L2BufferCache slots\nthat are allocated. This is to account for additional buffers that may be\nallocated directly by the application.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Kieran Bingham \nReviewed-by: Umang Jain \n---\n src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\nindex b3265d0e8aab..67901936d6b6 100644\n--- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n@@ -107,6 +107,14 @@ int Stream::prepareBuffers(unsigned int count)\n \t\tcount = bufferMap_.size();\n \t}\n \n+\t/*\n+\t * If this is an external stream, we must allocate slots for buffers that\n+\t * might be externally allocated. We have no indication of how many buffers\n+\t * may be used, so this might overallocate slots in the buffer cache.\n+\t */\n+\tif (isExternal())\n+\t\tcount = count * 2;\n+\n \treturn dev_->importBuffers(count);\n }\n \n","prefixes":["libcamera-devel","v2","3/3"]}