[{"id":20912,"web_url":"https://patchwork.libcamera.org/comment/20912/","msgid":"<9427234e-d14d-97bf-505c-18bf784a6ca9@ideasonboard.com>","date":"2021-11-12T12:44:20","subject":"Re: [libcamera-devel] [PATCH v4 14/14] ipa: ipu3: Pass the\n\tAnalogueGain control","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM,\n\nThank you for the patch\n\nOn 11/11/21 7:39 PM, Jean-Michel Hautbois wrote:\n> We can set the controls::AnalogueGain metadata now that AGC is updating\n> it correctly.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index dc6f2ced..a8d54a5d 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -628,6 +628,8 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \tint64_t frameDuration = (defVBlank_ + sensorInfo_.outputSize.height) * lineDuration_.get();\n> \tctrls.set(controls::FrameDuration, frameDuration);\n> \n> +\tctrls.set(controls::AnalogueGain, context_.frameContext.agc.gain);\n> +\n> \tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n> \n> \tctrls.set(controls::ExposureTime, context_.frameContext.sensor.exposure * lineDuration_.get());","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3B26BF415\n\tfor ;\n\tFri, 12 Nov 2021 12:44:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 707AD60362;\n\tFri, 12 Nov 2021 13:44:27 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBA296032C\n\tfor ;\n\tFri, 12 Nov 2021 13:44:25 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.254])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9BBE74C;\n\tFri, 12 Nov 2021 13:44:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IO0Pn4CZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636721065;\n\tbh=/kU7OGYQx7wbDFw+0OLuGJBDrT0V9m0qlzwD/LscruQ=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=IO0Pn4CZIJuhuVL8++eqGAfAW7kVCecKXd+8+U2LtjYAm/jVYMm64tUX7FZP+EX/z\n\tXw+AKFvYxH7xxxrQJn6YRUwg5bS7uTG4HKG6emNAn0RcbyXssjT8bi2WaOEWQN1bVq\n\t2bcNjdY7tjwUy6brzx9dPX/eJtYxn/g9tUEUEY+M=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-15-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<9427234e-d14d-97bf-505c-18bf784a6ca9@ideasonboard.com>","Date":"Fri, 12 Nov 2021 18:14:20 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211111140928.136111-15-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 14/14] ipa: ipu3: Pass the\n\tAnalogueGain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20942,"web_url":"https://patchwork.libcamera.org/comment/20942/","msgid":"<20211112232556.GL8453@jade.amanokami.net>","date":"2021-11-12T23:25:56","subject":"Re: [libcamera-devel] [PATCH v4 14/14] ipa: ipu3: Pass the\n\tAnalogueGain control","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Thu, Nov 11, 2021 at 03:09:28PM +0100, Jean-Michel Hautbois wrote:\n> We can set the controls::AnalogueGain metadata now that AGC is updating\n\nimo, s/set/report\n\nSame for the subject. \"Pass\" makes it sound like it's input :/\n\n> it correctly.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index dc6f2ced..a8d54a5d 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -628,6 +628,8 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \tint64_t frameDuration = (defVBlank_ + sensorInfo_.outputSize.height) * lineDuration_.get();\n> \tctrls.set(controls::FrameDuration, frameDuration);\n> \n> +\tctrls.set(controls::AnalogueGain, context_.frameContext.agc.gain);\n> +\n> \tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n> \n> \tctrls.set(controls::ExposureTime, context_.frameContext.sensor.exposure * lineDuration_.get());\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A5C5BF415\n\tfor ;\n\tFri, 12 Nov 2021 23:26:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E703F6036B;\n\tSat, 13 Nov 2021 00:26:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E30E0600B5\n\tfor ;\n\tSat, 13 Nov 2021 00:26:06 +0100 (CET)","from jade.amanokami.net (KD027085206038.au-net.ne.jp\n\t[27.85.206.38])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1EF509CA;\n\tSat, 13 Nov 2021 00:26:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YBsZooWq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636759566;\n\tbh=Akz3b4whAR2eEDaF5PdH+6xbvG/p6P1cL07FGhjgkMw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YBsZooWqZQgPTkkQyVdCs/pEV6IUxovMKhLS0fqaUjhxKlWynF5dWD2q/2ZY2eotd\n\tC8+ERHFCRN6Sl2BP33M6jKYBkgbZNqOrKZGE4/bo4aCcEcl5TLuejGutpvhGfv93lZ\n\tiV+Mvcq3IbyAPxqvwvAeQnmSfDJdy8mNUZC+hQks=","Date":"Sat, 13 Nov 2021 08:25:56 +0900","From":"Paul Elder ","To":"Jean-Michel Hautbois ","Message-ID":"<20211112232556.GL8453@jade.amanokami.net>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-15-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211111140928.136111-15-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 14/14] ipa: ipu3: Pass the\n\tAnalogueGain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]