[{"id":20903,"web_url":"https://patchwork.libcamera.org/comment/20903/","msgid":"","date":"2021-11-12T09:45:20","subject":"Re: [libcamera-devel] [PATCH v4 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM\n\nThank you for the patch.\n\nOn 11/11/21 7:39 PM, Jean-Michel Hautbois wrote:\n> Now that the color temperature is updated per-frame, use the value and\n> set the corresponding controls::ColourTemperature.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n> ---\n> src/ipa/ipu3/ipu3.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n>\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 38e86e58..d3195de6 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -631,6 +631,16 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \t\t\t\t(sensorInfo_.pixelRate / 1e6);\n> \tctrls.set(controls::FrameDuration, frameDuration);\n> \n> +\tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n> +\n> +\t/*\n> +\t * \\todo The Metadata provides a path to getting extended data\n> +\t * out to the application. Further data such as a simplifed Histogram\n> +\t * might have value to be exposed, however such data may be\n> +\t * difficult to report in a generically parsable way and we\n> +\t * likely want to avoid putting platform specific metadata in.\n> +\t */\n> +\n\n\nShould we cover this addition of \\todo as part of commit message too, \nnot sure.\n\nReviewed-by: Umang Jain \n\n> \tIPU3Action op;\n> \top.op = ActionMetadataReady;\n> \top.controls = ctrls;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7EC6BDB1C\n\tfor ;\n\tFri, 12 Nov 2021 09:45:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1BAE76033C;\n\tFri, 12 Nov 2021 10:45:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84E7460234\n\tfor ;\n\tFri, 12 Nov 2021 10:45:27 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.254])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A0EF974C;\n\tFri, 12 Nov 2021 10:45:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"J/32Yjb5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636710327;\n\tbh=mtX/f0bTC7rj1Fwntm4rUgeAKEkREPdRUafox4TGnX4=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=J/32Yjb51UV6AzJikc0geokN9mlDjiOZGaFtPaEk+H18OqfyWFXDLnPsk108UCDo5\n\tu57Qua6R3qwutL/5EupzWvvtbw9LuI3Rn9yfjgedauM8e9QIuJISbKGjTU9nkMyRg8\n\tHF5Di/whVn6gW9yEGiXyaRiXb78SYt7kpcx31jog=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-12-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Fri, 12 Nov 2021 15:15:20 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211111140928.136111-12-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":20939,"web_url":"https://patchwork.libcamera.org/comment/20939/","msgid":"<20211112232101.GI8453@jade.amanokami.net>","date":"2021-11-12T23:21:01","subject":"Re: [libcamera-devel] [PATCH v4 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Thu, Nov 11, 2021 at 03:09:25PM +0100, Jean-Michel Hautbois wrote:\n> Now that the color temperature is updated per-frame, use the value and\n> set the corresponding controls::ColourTemperature.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/ipu3/ipu3.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 38e86e58..d3195de6 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -631,6 +631,16 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \t\t\t\t(sensorInfo_.pixelRate / 1e6);\n> \tctrls.set(controls::FrameDuration, frameDuration);\n> \n> +\tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n> +\n> +\t/*\n> +\t * \\todo The Metadata provides a path to getting extended data\n> +\t * out to the application. Further data such as a simplifed Histogram\n> +\t * might have value to be exposed, however such data may be\n> +\t * difficult to report in a generically parsable way and we\n> +\t * likely want to avoid putting platform specific metadata in.\n> +\t */\n> +\n> \tIPU3Action op;\n> \top.op = ActionMetadataReady;\n> \top.controls = ctrls;\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DD31BDB1C\n\tfor ;\n\tFri, 12 Nov 2021 23:21:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E314D6036B;\n\tSat, 13 Nov 2021 00:21:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7198600B5\n\tfor ;\n\tSat, 13 Nov 2021 00:21:12 +0100 (CET)","from jade.amanokami.net (KD027085206038.au-net.ne.jp\n\t[27.85.206.38])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D1DF9CA;\n\tSat, 13 Nov 2021 00:21:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qinkB17m\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636759272;\n\tbh=lep3go42rYxJPsDYCsgQUub7RhGJ6vXc+SdHTAdoP7k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qinkB17mPjtnCU2z3EkNt1fspY9Na6vIcK1XQsruv/yI/T459jkjkJ9l2+apz3cP+\n\tzBgFC2qJXXXib9lCT1j1rou37qIQHphr1x0MXcPL8t0MB7uQNpYBGHnx1Rs5OaaZLR\n\tgm7pAWvmoPcAznK10H054SV1XC/EsNtvx04pLYQk=","Date":"Sat, 13 Nov 2021 08:21:01 +0900","From":"Paul Elder ","To":"Jean-Michel Hautbois ","Message-ID":"<20211112232101.GI8453@jade.amanokami.net>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-12-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211111140928.136111-12-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]