{"id":14581,"url":"https://patchwork.libcamera.org/api/patches/14581/?format=json","web_url":"https://patchwork.libcamera.org/patch/14581/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211111140928.136111-12-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-11T14:09:25","name":"[libcamera-devel,v4,11/14] ipa: ipu3: Send color temperature in the metadata","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"400067f15516436d3933651d1186b8589da1ab77","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/14581/mbox/","series":[{"id":2714,"url":"https://patchwork.libcamera.org/api/series/2714/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2714","date":"2021-11-11T14:09:14","name":"IPA: IPU3: Introduce per-frame controls","version":4,"mbox":"https://patchwork.libcamera.org/series/2714/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/14581/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/14581/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E46CC324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Nov 2021 14:09:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA1D060362;\n\tThu, 11 Nov 2021 15:09:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68569600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 15:09:33 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:e627:8337:a781:d98])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15F00E51;\n\tThu, 11 Nov 2021 15:09:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rS5WJYG2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636639773;\n\tbh=JMQm9uZfy7p4vYGC16HYi0ldVVfHp8KTz889bsLCWqk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rS5WJYG2JNs2mgmG4T1kSZoLzb+d6Yin1UB15mFyP+c16ATsAO5g5NYAs15FqmUp9\n\t9oHaNE5HNwomfsbEAOKo9KKZ1nRuSEfvWc7pBPQzkRxbLTfabP33XzrWGIwJBosF9H\n\tjK9wNpbXtLpXbIKDJG21kxSoaae47LS6Y1ZCFFNI=","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 11 Nov 2021 15:09:25 +0100","Message-Id":"<20211111140928.136111-12-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 11/14] ipa: ipu3: Send color\n\ttemperature in the metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Now that the color temperature is updated per-frame, use the value and\nset the corresponding controls::ColourTemperature.\n\nSigned-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/ipu3/ipu3.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex 38e86e58..d3195de6 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -631,6 +631,16 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n \t\t\t\t(sensorInfo_.pixelRate / 1e6);\n \tctrls.set(controls::FrameDuration, frameDuration);\n \n+\tctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n+\n+\t/*\n+\t * \\todo The Metadata provides a path to getting extended data\n+\t * out to the application. Further data such as a simplifed Histogram\n+\t * might have value to be exposed, however such data may be\n+\t * difficult to report in a generically parsable way and we\n+\t * likely want to avoid putting platform specific metadata in.\n+\t */\n+\n \tIPU3Action op;\n \top.op = ActionMetadataReady;\n \top.controls = ctrls;\n","prefixes":["libcamera-devel","v4","11/14"]}