[{"id":20862,"web_url":"https://patchwork.libcamera.org/comment/20862/","msgid":"<163664120658.2258438.16022782400545256081@Monstersaurus>","date":"2021-11-11T14:33:26","subject":"Re: [libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Update\n\tprevious exposure value","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-11 14:09:22)\n> Previously, the exposure value was calculated based on the estimated\n> shutter time and gain applied. Now that we have the real values for the\n> current frame, use those before estimating the next one and rename the\n> variable accordingly.\n> \n> As the exposure value is updated in the beginning of the computation,\n> there is no need to initialize effectiveExposureValue anymore in the\n> configure call, and it can be a local variable and not a class variable\n> anymore.\n> \n> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> ---\n> v3: make effectiveExposureValue a local variable\n> ---\n>  src/ipa/ipu3/algorithms/agc.cpp | 26 +++++++++-----------------\n>  src/ipa/ipu3/algorithms/agc.h   |  1 -\n>  2 files changed, 9 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index a34f070e..d736f21c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -80,8 +80,7 @@ static constexpr double kNormalizedLumaTarget = 0.16;\n>  \n>  Agc::Agc()\n>         : frameCount_(0), iqMean_(0.0), lineDuration_(0s), minExposureLines_(0),\n> -         maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s),\n> -         prevExposureValue_(0s)\n> +         maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s)\n>  {\n>  }\n>  \n> @@ -112,10 +111,6 @@ int Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n>         context.frameContext.agc.gain = minAnalogueGain_;\n>         context.frameContext.agc.exposure = minExposureLines_;\n>  \n> -       prevExposureValue_ = context.frameContext.agc.gain\n> -                          * context.frameContext.agc.exposure\n> -                          * lineDuration_;\n> -\n>         return 0;\n>  }\n>  \n> @@ -222,6 +217,13 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>  \n>         /* Calculate the shutter time in seconds */\n>         utils::Duration currentShutter = exposure * lineDuration_;\n> +\n> +       /*\n> +        * Update the exposure value for the next computation using the values\n> +        * of exposure and gain really used by the sensor.\n> +        */\n> +       utils::Duration effectiveExposureValue = currentShutter * analogueGain;\n> +\n>         LOG(IPU3Agc, Debug) << \"Actual total exposure \" << currentShutter * analogueGain\n>                             << \" Shutter speed \" << currentShutter\n>                             << \" Gain \" << analogueGain\n> @@ -239,7 +241,7 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>          * Calculate the current exposure value for the scene as the latest\n>          * exposure value applied multiplied by the new estimated gain.\n>          */\n> -       currentExposure_ = prevExposureValue_ * evGain;\n> +       currentExposure_ = effectiveExposureValue * evGain;\n>         utils::Duration minShutterSpeed = minExposureLines_ * lineDuration_;\n>         utils::Duration maxShutterSpeed = maxExposureLines_ * lineDuration_;\n>  \n> @@ -271,16 +273,6 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>         /* Update the estimated exposure and gain. */\n>         frameContext.agc.exposure = shutterTime / lineDuration_;\n>         frameContext.agc.gain = stepGain;\n> -\n> -       /*\n> -        * Update the exposure value for the next process call.\n> -        *\n> -        * \\todo Obtain the values of the exposure time and analog gain\n> -        * that were actually used by the sensor, either from embedded\n> -        * data when available, or from the delayed controls\n> -        * infrastructure in case a slow down caused a mismatch.\n> -        */\n> -       prevExposureValue_ = shutterTime * analogueGain;\n>  }\n>  \n>  /**\n> diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\n> index 79736283..1d085b40 100644\n> --- a/src/ipa/ipu3/algorithms/agc.h\n> +++ b/src/ipa/ipu3/algorithms/agc.h\n> @@ -54,7 +54,6 @@ private:\n>  \n>         utils::Duration filteredExposure_;\n>         utils::Duration currentExposure_;\n> -       utils::Duration prevExposureValue_;\n>  \n>         uint32_t stride_;\n>  };\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4574BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Nov 2021 14:33:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E45C46035A;\n\tThu, 11 Nov 2021 15:33:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D48EA600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Nov 2021 15:33:29 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 67D9CDEE;\n\tThu, 11 Nov 2021 15:33:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SR3SdLAz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636641209;\n\tbh=rY7i4bV1y7qNMUF1gphPPhQwA0ZnU/E+niiDBAPApVg=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=SR3SdLAzy5R3fGwScHqt8Kpx1TZ7200ZMr9YeFRb/B6dw+Deda7QO3L+ApgpcVVdC\n\tnSlV8vDy42e0c6nzRX7wPyqc/wqTyNg2Oq/Q2hVqULdS7qIEfQgtwQg3l5gFlrKoA+\n\tIENsF2AksWJAtZ3AqbSV2YROSz2HTT6IbHJbL6QA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211111140928.136111-9-jeanmichel.hautbois@ideasonboard.com>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-9-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 11 Nov 2021 14:33:26 +0000","Message-ID":"<163664120658.2258438.16022782400545256081@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Update\n\tprevious exposure value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20900,"web_url":"https://patchwork.libcamera.org/comment/20900/","msgid":"<b2e2d2ec-0667-0d09-0270-c632305b3e37@ideasonboard.com>","date":"2021-11-12T08:53:10","subject":"Re: [libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Update\n\tprevious exposure value","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi JM,\n\nThank you for the patch.\n\nOn 11/11/21 7:39 PM, Jean-Michel Hautbois wrote:\n> Previously, the exposure value was calculated based on the estimated\n> shutter time and gain applied. Now that we have the real values for the\n> current frame, use those before estimating the next one and rename the\n> variable accordingly.\n>\n> As the exposure value is updated in the beginning of the computation,\n> there is no need to initialize effectiveExposureValue anymore in the\n> configure call, and it can be a local variable and not a class variable\n> anymore.\n>\n> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n\n\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n>\n> ---\n> v3: make effectiveExposureValue a local variable\n> ---\n>   src/ipa/ipu3/algorithms/agc.cpp | 26 +++++++++-----------------\n>   src/ipa/ipu3/algorithms/agc.h   |  1 -\n>   2 files changed, 9 insertions(+), 18 deletions(-)\n>\n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index a34f070e..d736f21c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -80,8 +80,7 @@ static constexpr double kNormalizedLumaTarget = 0.16;\n>   \n>   Agc::Agc()\n>   \t: frameCount_(0), iqMean_(0.0), lineDuration_(0s), minExposureLines_(0),\n> -\t  maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s),\n> -\t  prevExposureValue_(0s)\n> +\t  maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s)\n>   {\n>   }\n>   \n> @@ -112,10 +111,6 @@ int Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n>   \tcontext.frameContext.agc.gain = minAnalogueGain_;\n>   \tcontext.frameContext.agc.exposure = minExposureLines_;\n>   \n> -\tprevExposureValue_ = context.frameContext.agc.gain\n> -\t\t\t   * context.frameContext.agc.exposure\n> -\t\t\t   * lineDuration_;\n> -\n>   \treturn 0;\n>   }\n>   \n> @@ -222,6 +217,13 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>   \n>   \t/* Calculate the shutter time in seconds */\n>   \tutils::Duration currentShutter = exposure * lineDuration_;\n> +\n> +\t/*\n> +\t * Update the exposure value for the next computation using the values\n> +\t * of exposure and gain really used by the sensor.\n> +\t */\n> +\tutils::Duration effectiveExposureValue = currentShutter * analogueGain;\n> +\n>   \tLOG(IPU3Agc, Debug) << \"Actual total exposure \" << currentShutter * analogueGain\n>   \t\t\t    << \" Shutter speed \" << currentShutter\n>   \t\t\t    << \" Gain \" << analogueGain\n> @@ -239,7 +241,7 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>   \t * Calculate the current exposure value for the scene as the latest\n>   \t * exposure value applied multiplied by the new estimated gain.\n>   \t */\n> -\tcurrentExposure_ = prevExposureValue_ * evGain;\n> +\tcurrentExposure_ = effectiveExposureValue * evGain;\n>   \tutils::Duration minShutterSpeed = minExposureLines_ * lineDuration_;\n>   \tutils::Duration maxShutterSpeed = maxExposureLines_ * lineDuration_;\n>   \n> @@ -271,16 +273,6 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>   \t/* Update the estimated exposure and gain. */\n>   \tframeContext.agc.exposure = shutterTime / lineDuration_;\n>   \tframeContext.agc.gain = stepGain;\n> -\n> -\t/*\n> -\t * Update the exposure value for the next process call.\n> -\t *\n> -\t * \\todo Obtain the values of the exposure time and analog gain\n> -\t * that were actually used by the sensor, either from embedded\n> -\t * data when available, or from the delayed controls\n> -\t * infrastructure in case a slow down caused a mismatch.\n> -\t */\n> -\tprevExposureValue_ = shutterTime * analogueGain;\n>   }\n>   \n>   /**\n> diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\n> index 79736283..1d085b40 100644\n> --- a/src/ipa/ipu3/algorithms/agc.h\n> +++ b/src/ipa/ipu3/algorithms/agc.h\n> @@ -54,7 +54,6 @@ private:\n>   \n>   \tutils::Duration filteredExposure_;\n>   \tutils::Duration currentExposure_;\n> -\tutils::Duration prevExposureValue_;\n>   \n>   \tuint32_t stride_;\n>   };","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5BF5BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Nov 2021 08:53:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D80896035D;\n\tFri, 12 Nov 2021 09:53:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E62960234\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Nov 2021 09:53:16 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.254])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E5794A6;\n\tFri, 12 Nov 2021 09:53:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n+EmV60s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636707195;\n\tbh=MjgSMxMXvvd65i7v/iFioSOHnIclUxTsiXb/Cui/QGU=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=n+EmV60sdknti3cEpwYpoy4XwXe/ZZIqAkObtxOHC6ESoyUKWKKPnqDv3rOOgGIdL\n\taCkPi3NFWPl45aQuBMV78/8t94PWzPt0G2AwsU/mVpNtU2Iv7ryHTVDSxYPJKEK5Dm\n\teuq9JLuQ1HjU/XvYstShYU4MLSTUGfiI0fZYqECY=","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-9-jeanmichel.hautbois@ideasonboard.com>","From":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<b2e2d2ec-0667-0d09-0270-c632305b3e37@ideasonboard.com>","Date":"Fri, 12 Nov 2021 14:23:10 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.10.2","MIME-Version":"1.0","In-Reply-To":"<20211111140928.136111-9-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Update\n\tprevious exposure value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":20936,"web_url":"https://patchwork.libcamera.org/comment/20936/","msgid":"<20211112231447.GF8453@jade.amanokami.net>","date":"2021-11-12T23:14:47","subject":"Re: [libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Update\n\tprevious exposure value","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Thu, Nov 11, 2021 at 03:09:22PM +0100, Jean-Michel Hautbois wrote:\n> Previously, the exposure value was calculated based on the estimated\n> shutter time and gain applied. Now that we have the real values for the\n> current frame, use those before estimating the next one and rename the\n> variable accordingly.\n> \n> As the exposure value is updated in the beginning of the computation,\n> there is no need to initialize effectiveExposureValue anymore in the\n> configure call, and it can be a local variable and not a class variable\n> anymore.\n> \n> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> \n> ---\n> v3: make effectiveExposureValue a local variable\n> ---\n>  src/ipa/ipu3/algorithms/agc.cpp | 26 +++++++++-----------------\n>  src/ipa/ipu3/algorithms/agc.h   |  1 -\n>  2 files changed, 9 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index a34f070e..d736f21c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -80,8 +80,7 @@ static constexpr double kNormalizedLumaTarget = 0.16;\n>  \n>  Agc::Agc()\n>  \t: frameCount_(0), iqMean_(0.0), lineDuration_(0s), minExposureLines_(0),\n> -\t  maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s),\n> -\t  prevExposureValue_(0s)\n> +\t  maxExposureLines_(0), filteredExposure_(0s), currentExposure_(0s)\n>  {\n>  }\n>  \n> @@ -112,10 +111,6 @@ int Agc::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n>  \tcontext.frameContext.agc.gain = minAnalogueGain_;\n>  \tcontext.frameContext.agc.exposure = minExposureLines_;\n>  \n> -\tprevExposureValue_ = context.frameContext.agc.gain\n> -\t\t\t   * context.frameContext.agc.exposure\n> -\t\t\t   * lineDuration_;\n> -\n>  \treturn 0;\n>  }\n>  \n> @@ -222,6 +217,13 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>  \n>  \t/* Calculate the shutter time in seconds */\n>  \tutils::Duration currentShutter = exposure * lineDuration_;\n> +\n> +\t/*\n> +\t * Update the exposure value for the next computation using the values\n> +\t * of exposure and gain really used by the sensor.\n> +\t */\n> +\tutils::Duration effectiveExposureValue = currentShutter * analogueGain;\n> +\n>  \tLOG(IPU3Agc, Debug) << \"Actual total exposure \" << currentShutter * analogueGain\n>  \t\t\t    << \" Shutter speed \" << currentShutter\n>  \t\t\t    << \" Gain \" << analogueGain\n> @@ -239,7 +241,7 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>  \t * Calculate the current exposure value for the scene as the latest\n>  \t * exposure value applied multiplied by the new estimated gain.\n>  \t */\n> -\tcurrentExposure_ = prevExposureValue_ * evGain;\n> +\tcurrentExposure_ = effectiveExposureValue * evGain;\n>  \tutils::Duration minShutterSpeed = minExposureLines_ * lineDuration_;\n>  \tutils::Duration maxShutterSpeed = maxExposureLines_ * lineDuration_;\n>  \n> @@ -271,16 +273,6 @@ void Agc::computeExposure(IPAFrameContext &frameContext, double currentYGain)\n>  \t/* Update the estimated exposure and gain. */\n>  \tframeContext.agc.exposure = shutterTime / lineDuration_;\n>  \tframeContext.agc.gain = stepGain;\n> -\n> -\t/*\n> -\t * Update the exposure value for the next process call.\n> -\t *\n> -\t * \\todo Obtain the values of the exposure time and analog gain\n> -\t * that were actually used by the sensor, either from embedded\n> -\t * data when available, or from the delayed controls\n> -\t * infrastructure in case a slow down caused a mismatch.\n> -\t */\n> -\tprevExposureValue_ = shutterTime * analogueGain;\n>  }\n>  \n>  /**\n> diff --git a/src/ipa/ipu3/algorithms/agc.h b/src/ipa/ipu3/algorithms/agc.h\n> index 79736283..1d085b40 100644\n> --- a/src/ipa/ipu3/algorithms/agc.h\n> +++ b/src/ipa/ipu3/algorithms/agc.h\n> @@ -54,7 +54,6 @@ private:\n>  \n>  \tutils::Duration filteredExposure_;\n>  \tutils::Duration currentExposure_;\n> -\tutils::Duration prevExposureValue_;\n>  \n>  \tuint32_t stride_;\n>  };\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74A36BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Nov 2021 23:15:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD7656036B;\n\tSat, 13 Nov 2021 00:14:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75F8B600B5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Nov 2021 00:14:57 +0100 (CET)","from jade.amanokami.net (KD027085206038.au-net.ne.jp\n\t[27.85.206.38])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CCC49CA;\n\tSat, 13 Nov 2021 00:14:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v6DDqjGI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636758897;\n\tbh=Tn8TIuvlf1Xf+vL4TSBHpGK64QeZ3vrZ/Vsybco7O/U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=v6DDqjGIGO+TiKbsZV0svuj/kHkaqJJkJGdp2Rxs+gB+a0Tk0js2uXNd/1mKAgy9v\n\tbONrni8FJlhdfkZtuwGNL9FEl2BxzSumeQmZAoU8VQAPQsj24jU0qQ6JksS/R4sODV\n\trwE4s/l5c2PjSt90MKuim4RZoNUZL6zwUVEuao6E=","Date":"Sat, 13 Nov 2021 08:14:47 +0900","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<20211112231447.GF8453@jade.amanokami.net>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-9-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211111140928.136111-9-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 08/14] ipa: ipu3: agc: Update\n\tprevious exposure value","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]