[{"id":20891,"web_url":"https://patchwork.libcamera.org/comment/20891/","msgid":"<20211112024935.GE4088@pyrite.rasen.tech>","date":"2021-11-12T02:49:35","subject":"Re: [libcamera-devel] [PATCH v4 02/14] ipu3: ipa: Report effective\n\tsensor controls with statistics to IPA","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Thu, Nov 11, 2021 at 03:09:16PM +0100, Jean-Michel Hautbois wrote:\n> From: Han-Lin Chen \n> \n> The Intel close sourced IPA requires the effective controls applied to\n> the sensor when the statistics are generated. Report effective sensor controls\n> with the statistics to IPA.\n> \n> Signed-off-by: Han-Lin Chen \n> [Jean-Michel: Reword s/stastistics/statistics and move reset after IPA\n> start]\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/ipu3/frames.h | 4 ++++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n> 2 files changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\n> index 3ef7e445..614701e2 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.h\n> +++ b/src/libcamera/pipeline/ipu3/frames.h\n> @@ -14,6 +14,8 @@\n> \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> class FrameBuffer;\n> @@ -34,6 +36,8 @@ public:\n> \t\tFrameBuffer *paramBuffer;\n> \t\tFrameBuffer *statBuffer;\n> \n> +\t\tControlList effectiveSensorControls;\n> +\n> \t\tbool paramDequeued;\n> \t\tbool metadataProcessed;\n> \t};\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 8816efc5..c984ed12 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -767,6 +767,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \tif (ret)\n> \t\tgoto error;\n> \n> +\tdata->delayedCtrls_->reset();\n> +\n> \t/*\n> \t * Start the ImgU video devices, buffers will be queued to the\n> \t * ImgU output and viewfinder when requests will be queued.\n> @@ -1363,6 +1365,8 @@ void IPU3CameraData::cio2BufferReady(FrameBuffer *buffer)\n> \trequest->metadata().set(controls::SensorTimestamp,\n> \t\t\t\tbuffer->metadata().timestamp);\n> \n> +\tinfo->effectiveSensorControls = delayedCtrls_->get(buffer->metadata().sequence);\n> +\n> \tif (request->findBuffer(&rawStream_))\n> \t\tpipe()->completeBuffer(request, buffer);\n> \n> @@ -1419,6 +1423,7 @@ void IPU3CameraData::statBufferReady(FrameBuffer *buffer)\n> \tev.frame = info->id;\n> \tev.bufferId = info->statBuffer->cookie();\n> \tev.frameTimestamp = request->metadata().get(controls::SensorTimestamp);\n> +\tev.sensorControls = info->effectiveSensorControls;\n> \tipa_->processEvent(ev);\n> }\n> \n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAC59BDB1C\n\tfor ;\n\tFri, 12 Nov 2021 02:49:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 105936033C;\n\tFri, 12 Nov 2021 03:49:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 53F1B60232\n\tfor ;\n\tFri, 12 Nov 2021 03:49:43 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC72855C;\n\tFri, 12 Nov 2021 03:49:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iRCobdhD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636685383;\n\tbh=UZ8y0oEP2GvcW0DpvEoqkw2/ikzbgDo/K7fqLizDHk0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iRCobdhDGn+anTzQKysvUdSA3qw+5mHWeL9SnSNxoy9f+63NadDvUpNsowRNG3qnL\n\t4R3D7ccUeCoPpAYWKi1jrPyicyDejP2AUcjQ0xw2ZtRINQqnMEWg37+mxtBJjAj+5N\n\tBpVbQxYc5XiXMMp+2PNyqF0975IfHSdrN5oGvM0g=","Date":"Fri, 12 Nov 2021 11:49:35 +0900","From":"paul.elder@ideasonboard.com","To":"Jean-Michel Hautbois ","Message-ID":"<20211112024935.GE4088@pyrite.rasen.tech>","References":"<20211111140928.136111-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111140928.136111-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20211111140928.136111-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 02/14] ipu3: ipa: Report effective\n\tsensor controls with statistics to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]