[{"id":20856,"web_url":"https://patchwork.libcamera.org/comment/20856/","msgid":"<163663658046.2258438.8195114800096840685@Monstersaurus>","date":"2021-11-11T13:16:20","subject":"Re: [libcamera-devel] [PATCH v3 13/14] ipa: ipu3: Move ExposureTime\n\tto IPA","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jean-Michel Hautbois (2021-11-11 11:06:04)\n> Now that we have the exposure time calculated, pass it to the\n> controls::ExposureTime and don't use the pipeline handler for it\n> anymore. While at it, use the same line duration value for ExposureTime\n> and FrameDuration.\n\nNeeds updating?\n\n\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 2 ++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 16 +---------------\n> 2 files changed, 3 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 3c1aa5ad..a91550b9 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -631,6 +631,8 @@ void IPAIPU3::parseStatistics(unsigned int frame,\n> \n> ctrls.set(controls::ColourTemperature, context_.frameContext.awb.temperatureK);\n> \n> + ctrls.set(controls::ExposureTime, context_.frameContext.sensor.exposure * lineDuration_.get());\n> +\n\nA long line, but I don't mind that.\n\nWith the commit message updated:\n\nReviewed-by: Kieran Bingham \n> /*\n> * \\todo The Metadata provides a path to getting extended data\n> * out to the application. Further data such as a simplifed Histogram\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 3fcfa777..fe37e9c7 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -47,7 +47,7 @@ class IPU3CameraData : public Camera::Private\n> {\n> public:\n> IPU3CameraData(PipelineHandler *pipe)\n> - : Camera::Private(pipe), exposureTime_(0), supportsFlips_(false)\n> + : Camera::Private(pipe), supportsFlips_(false)\n> {\n> }\n> \n> @@ -67,7 +67,6 @@ public:\n> Stream vfStream_;\n> Stream rawStream_;\n> \n> - uint32_t exposureTime_;\n> Rectangle cropRegion_;\n> bool supportsFlips_;\n> Transform rotationTransform_;\n> @@ -1049,17 +1048,6 @@ int PipelineHandlerIPU3::updateControls(IPU3CameraData *data)\n> \n> controls[&controls::ScalerCrop] = ControlInfo(minCrop, maxCrop, maxCrop);\n> \n> - /*\n> - * \\todo Report the actual exposure time, use the default for the\n> - * moment.\n> - */\n> - const auto exposureInfo = data->ipaControls_.find(&controls::ExposureTime);\n> - if (exposureInfo == data->ipaControls_.end()) {\n> - LOG(IPU3, Error) << \"Exposure control not initialized by the IPA\";\n> - return -EINVAL;\n> - }\n> - data->exposureTime_ = exposureInfo->second.def().get();\n> -\n> /* Add the IPA registered controls to list of camera controls. */\n> for (const auto &ipaControl : data->ipaControls_)\n> controls[ipaControl.first] = ipaControl.second;\n> @@ -1321,8 +1309,6 @@ void IPU3CameraData::imguOutputBufferReady(FrameBuffer *buffer)\n> pipe()->completeBuffer(request, buffer);\n> \n> request->metadata().set(controls::draft::PipelineDepth, 3);\n> - /* \\todo Move the ExposureTime control to the IPA. */\n> - request->metadata().set(controls::ExposureTime, exposureTime_);\n> /* \\todo Actually apply the scaler crop region to the ImgU. */\n> if (request->controls().contains(controls::ScalerCrop))\n> cropRegion_ = request->controls().get(controls::ScalerCrop);\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA512BDB1C\n\tfor ;\n\tThu, 11 Nov 2021 13:16:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3944B60361;\n\tThu, 11 Nov 2021 14:16:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA2FE60345\n\tfor ;\n\tThu, 11 Nov 2021 14:16:22 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 839494A0;\n\tThu, 11 Nov 2021 14:16:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vyVbv5Xt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1636636582;\n\tbh=VW1lUD6IGI4XjSxs4t3g8K2r+pEPSdF1/OFTw5XPnlo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=vyVbv5Xt8z+2WIZklrd0G3BE6dCTHw9bybbyvRUGULarpiJPrnFIAj1frb7B4oR+g\n\tJ6ylKumBqjVaRFMufvix+b7Y8fgrhFijkHE2ZD7uONjqm/4tf7ZQse6gRt68fKHTqN\n\tvnWpOq7MgCt0BFFOX3Wt9TRYfCsNId7engUM54mA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20211111110605.105202-14-jeanmichel.hautbois@ideasonboard.com>","References":"<20211111110605.105202-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20211111110605.105202-14-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 11 Nov 2021 13:16:20 +0000","Message-ID":"<163663658046.2258438.8195114800096840685@Monstersaurus>","User-Agent":"alot/0.9.1","Subject":"Re: [libcamera-devel] [PATCH v3 13/14] ipa: ipu3: Move ExposureTime\n\tto IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]